From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3541035AC0B for ; Sat, 25 Apr 2026 13:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777124705; cv=none; b=D+EU2b6PUcHr2t/IVuJ/I3ty7AvqTaC9lqDrabgQ7IiTZg2azom1lZg4i1TO0yXKUo5oOhPfopA6CFagm/n4qLBEbLIt/a3ce3vH/vjbRIH//9lZSKLhPDUjDO6mUveLqIKyMb55uNtpi/pkxO6Aq/P09/uSW6uTFYdtMWmj7mU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777124705; c=relaxed/simple; bh=IuEBhxOpVg0e78MyKlscPDGHPKJIxMaAtna4KDtrZXI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iV8bu459FR7ymIYTu+wjdZjwnKNxiX1DkXyAxHsyewmKuMzSHpDLskofJBBAsOdfHxBQ63iwh+XxGHvvtG2ir0tib/kC8J8wXJd+AGLc2phdB71c3+ErToO7zviluYflgLlKUc5G9YFNVkhzP7Sg3YaK5XbkMvlCkmIypvfnhaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WpGulW+W; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WpGulW+W" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a871daa98fso57686345ad.1 for ; Sat, 25 Apr 2026 06:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777124703; x=1777729503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GZa8V4V+L1cbe14Qji0FuVA6E1esCIns+Fs7vnMJGGM=; b=WpGulW+WaKQlSZjy/+U/rJ9tDAsWWRHr8MZam0P1J4no8Ry9HzUwQyR/HEfn+guK9T RkYm09DApbiNUncLyTG8L29yVzRI1ZWs5FSFELVXQOJFHFnk3YxFq822B92tlLgOgoPN jG9b7X4N/G6kvl16Oi0jqI6ngaq6ZH09YziNjeofB+VJyuFM95BkUMM00RdREuC9SL1B WS/FCYmq6jbv/4HLXAV0JOIK3NuKQL6HK3Bb5xeQo4qBoqRqHBxGf4MgqTSeSgGjUnj1 GgoGdqfp1pEEM+jEtt8Um2FaZZwyKPahPGycyY1FnemflTUHTicQkNMHBAirOMME13iC LJfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777124703; x=1777729503; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GZa8V4V+L1cbe14Qji0FuVA6E1esCIns+Fs7vnMJGGM=; b=B9N8zCtipfLyMQsrHHLR29xK5yNvhTF7Uyvy5KlbbE1A59mwQAABQFvRa1nglSgKFi hDurHPk7ZHL/DPJQ9JoleOYyRk7hid7705JZxwa4U9jypx3GYUpNAWUQileOUsSNcn92 RqPa0iOodTQD8/1ODNgohKBoDCktLBlC7Yujx26RMWir09Z6ZWcuCZg48AgPHe9TvxMK 5k16LHs3I7RlAL9WB4dMWfpiO5QZI5vi2XB+ij1qUKQKbU5SiXSan0O9hN6rbx5T4CfC OmI6ZmakbJKiWQCJMBZj+WxroBn9Z0+/AEiioHG3WMA1y7hxgwynTFg4WnrDfJ7gzcX0 i58g== X-Forwarded-Encrypted: i=1; AFNElJ8PChrKYpKXrft2M4pQy3KsPTQi6npbrGkmiL9VbGZKGu4xgk3nOs3z4yZuQ3g+Qi+mwWZLk+/wvHB8GoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyCxvy769xCWHbsPO7xiP64nN1/2rgUUNnDUFqGdvogY1mtrGv+ hP0hHA9mm/J/oHCMetV2Wd6mbZVqNSUX2js3JMXS5jN6beS+TpL0Xy9i X-Gm-Gg: AeBDievg8caJCV4VfwNts7PTqs/krAqdgo5Gk4aGSpu1FoFWzU6goA/dcPdl48XGO6e CSxeuGKo8zvtW/nUXzfMsV9cktEFrxc/gMBLepHXbTWpRKtsfk4hga/OgeUvrY7UNU/71W8hXY3 OnXWk4wSnauocW+nuq9E/uwheCKiosWMXi9JGqaLsdmf52VaqsqpXM3WvP/YotNlUsvQ8oTJXu8 hyBg16O0P+iMJJOIVZhqb7laDwixsP6g4bl74MBqoRdaMTK89L6Lc8ek2F1wbJyXNDXpNXWu6d5 v9J2tl4zA5xr6gfH/9qZt028TO2q+C/1sNdd9iTuOHIevy28cpQlgw32ZUkqxK8oQQfCjcX6VdZ o5gPPqlNAfmUdQqa1g3elgEKk37AKKwEs+2uiC8qk+HXlhh2V/7WzVnsPJE376WOe7OW36oS3Df MtvfeT9aT7JKePIUxNCzvtVuI4DX94uKLyNQiqRKpo1QARfqjlIwQXYKNW X-Received: by 2002:a17:902:690a:b0:2b2:50bd:83b3 with SMTP id d9443c01a7336-2b5f9e8196fmr273111755ad.10.1777124703464; Sat, 25 Apr 2026 06:45:03 -0700 (PDT) Received: from tech-Alienware-m15-R6.. ([122.171.21.105]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9fedf0sm310473435ad.6.2026.04.25.06.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 06:45:03 -0700 (PDT) From: Sunny Patel To: Andrew Morton , David Hildenbrand Cc: Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sunny Patel Subject: [PATCH] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page Date: Sat, 25 Apr 2026 19:14:48 +0530 Message-ID: <20260425134453.23769-1-nueralspacetech@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When migrate_vma_insert_huge_pmd_page() jumps to unlock_abort due to a PMD check failure, the pgtable allocated earlier via pte_alloc_one() is never freed, causing a memory leak. Add a pte_free() call in the unlock_abort error path to release the pgtable before returning. Signed-off-by: Sunny Patel --- mm/migrate_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/migrate_device.c b/mm/migrate_device.c index fbfe5715f635..457bab5c7c31 100644 --- a/mm/migrate_device.c +++ b/mm/migrate_device.c @@ -893,6 +893,7 @@ static int migrate_vma_insert_huge_pmd_page(struct migrate_vma *migrate, unlock_abort: spin_unlock(ptl); + pte_free(vma->vm_mm, pgtable); abort: for (i = 0; i < HPAGE_PMD_NR; i++) src[i] &= ~MIGRATE_PFN_MIGRATE; -- 2.43.0