From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C16C040DFDF for ; Sat, 25 Apr 2026 18:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777142224; cv=none; b=JFfq7zajCI79KG+1H8vBXS6eFkSKlaoN2gFDv/6MqyfgDL5+IwzgmhEqbKxiyZhDp0qiKQLbVU+jOzBkaNfKEr0MqiTornLiUnXSaHOdnqB0egXxHCykLeQ+yy++jEJiE/xR2m6zMuw8KZ9pZSQHf/38hjioDsYZQlQTb6Pda4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777142224; c=relaxed/simple; bh=yQKdyHZ4N33P3RNm526pn6iL+q/tbXSD/Pk7sz+TWJ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RXdsSAhKFKwVVQv/uafZf3emlK50/nN72LEp5BWC+paQFEFRTelD0zkfZjEOUA68SW6SADWbwPyfcH5Zq6/R4y1fH8s90Yg7acdGodxcqYzayK0MhxSvmYNXvfU7VLdEitf5Rav3bMmtD/geLdblFcPrbDD37IA3AmAJU38pGWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aHMUTR9j; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aHMUTR9j" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 25F1F1A3398; Sat, 25 Apr 2026 18:37:01 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id ECEDB60535; Sat, 25 Apr 2026 18:37:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id ECDC310720E6D; Sat, 25 Apr 2026 20:36:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1777142219; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=ygGiL08SISsUocfLcaOaYdbsvr1yTK/YMjXbsP0CopY=; b=aHMUTR9jWOCNL9rYYDiyV2r/mSuiSjYjgYsp0P5fb1BPlId6+zQ1d6jbTZpT7pFZl9iU3D TPZ/fmSWiidJ/SjLwuu0achtf1YSIF1t9TPw2/taC2LmZTU3O2DzW0FRc6O6c5mg5tAyla iKq/azt1ceedjdQNjGoCw1deZ6kb4QRjv3e+nEtunOsFPhOm9OjBlbu5Up6equVad4BM4m h0XHuq4hoWWkxlH/kRuUZX0mrLJ+Rcepn42oeSurFKC2GlDtmXgRZx74E2dyfAIV3oyRom oDF4KipR3dfC5EWekaZ/8aWU6JJd5rHsa5HEQWZRDS+sxEZMhfeWCjK0gZ11cA== Date: Sat, 25 Apr 2026 20:36:57 +0200 From: Alexandre Belloni To: Biju Das Cc: John Madieu , "ryan@bluewatersys.com" , "akpm@linux-foundation.org" , "m.grzeschik@pengutronix.de" , "Denis.Osterland@diehl.com" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "john.madieu@gmail.com" Subject: Re: [PATCH 2/2] rtc: isl1208: Balance enable_irq_wake() with disable_irq_wake() on cleanup Message-ID: <202604251836574d655eb1@mail.local> References: <20260425154959.2796261-1-john.madieu.xa@bp.renesas.com> <20260425154959.2796261-3-john.madieu.xa@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On 25/04/2026 16:39:16+0000, Biju Das wrote: > Hi John, > > > -----Original Message----- > > From: John Madieu > > Sent: 25 April 2026 16:50 > > Subject: [PATCH 2/2] rtc: isl1208: Balance enable_irq_wake() with disable_irq_wake() on cleanup > > > > isl1208_setup_irq() calls enable_irq_wake() after a successful IRQ request, but the driver has no > > remove path that balances it. > > The driver is devm-only, so on unbind devm releases the IRQ - but enable_irq_wake() is not undone by > > IRQ release, so the wake count for that IRQ stays incremented. > > > > Each rebind therefore leaks one wake reference; the leak doubles for the chip variant that has a > > separate evdet IRQ, since > > isl1208_setup_irq() is then called twice during probe. > > Is removal of RTC device possible [1]? > > [1] > https://patchwork.ozlabs.org/project/rtc-linux/patch/20230922081208.26334-1-biju.das.jz@bp.renesas.com/#3195765 > I'd say yes if this is not the RTC that is backing alarmtimer or alarmtimer is not compiled in the kernel. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com