From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9084E3815DC for ; Sat, 25 Apr 2026 22:09:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777154944; cv=none; b=JUhO654Kh+H4xYlMb5g5h0tpF1N2oAkRsFYxcjnQt0RDRY1vMi9Vh6VZgLSyQNW5vTCTne09oJyhgcNsrmNh+lGdCeIGdxQhHxvG27E0CTWrAnhD5rnOl8kyclFzR/QLtGoSIzfl3BxvSd89k5JgzSfh3vFMvPxBRLsWwRnMu2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777154944; c=relaxed/simple; bh=bPeySIzvwdl59bI8ZI4Nv+mHr412k88Uyp1LoSfzrgk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q+QMxSdD5bhTrsqOFv6+5u6bl0MGQt5Akmd22tm41fxfykhe0iyOavHRP1lb8CcxgJgpCyOK3ftvWnpkMGPV3hx8c6ALiYtKMQbA6HIX6IgbTQ8velqZD621vYHDmDMxPlxUootLrFjPMgUr1dTsLa/CsfGL4z3EsWn5zl2jick= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T1aMH6j1; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1aMH6j1" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so83053715e9.0 for ; Sat, 25 Apr 2026 15:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777154940; x=1777759740; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IjA4suJY50P3hL0eg2zIeJeFSvUg5EcOPNDUedPN0Yo=; b=T1aMH6j1pRhFzmOiZfLxKTGirNYPR2MbKZyoQgBGdDCuBASDFPL6JqKd8E/MrhXUng CpczMJ+2ePsqF8KMc2kBv8gs8mXrBrsRd64MpyFQyzYrq/OLVo371m8X0WVkQ54GeA+x PmymDfU8PD47sOlyH5Y/I+QjHRzpUZUrM5LTbVW+H2nOyaCOuT8T2d01mByskmKxcptR lp6cBdeYqlalwGSsQmuppDVMyQl8AhLcs87bgoKj7ydvOOV+SgXF/6XYfXsvtC2SofvX /8+cNnzrNLhY5GxZS9ujaGRPDD4SL+iq65tMyDFM1mM0A1s7wEp04gPlcsYu5LXmzuEB cnJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777154940; x=1777759740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IjA4suJY50P3hL0eg2zIeJeFSvUg5EcOPNDUedPN0Yo=; b=rxd7AIvKpNkYiQ+oRTv6oQ+mzB+dQZNFqvOOs2fWiqgpCaSBEm4i42NFvZapU6Y+2y +x5Mlot7JHaWQjgwg0upiIl3AvJzKJZpB6DKFaoooGEdqa9Q5Yb97cLGhH9+OBXp5jHO t4NvZDCSAZVQoDYbYgK8hdP7nM3qW0lmoCun47A+bTIz7wVrR35Cgb0iQk6RWNtCYrY+ EnicYunygR0/qhtyvQ9JCrAsb+Lj3DLYJoX4x5Lz8b9XTjQT+vHogNwlAYYdJ/MGtv7T OZOgdGPf8R49YR8DhieXk5rQCKLHGATQT6eDTuC7HQH+PQejEFlvLp+J7h3ndE06whLm rH2w== X-Forwarded-Encrypted: i=1; AFNElJ8a913Cs83NBfZ6MU9go+xqcYiMra7I1/EuEZBUxsTOfeKeiyYQTAGix+AXVapd1Cbm7KlAjp0FTKoqx5o=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4PDgaFwXE2UW33ka/MLLFWXnKu39mrmtkGjEQAqHPaanvGK6Q B519W4uDZQWrZtZuK7lJjnT09aLPE9EhjYOUuNEUh7ATrE1t6Lt/dVQp X-Gm-Gg: AeBDievgi0Omn9+Jk76lZ3khEd9JbjwJbz8L6KNUd8hUG6ynM8eO8faBB0dBPrB5rIL hPtJ9epriiPXreCnovIe8LSYzWgN0ylpjTbgyt+mp+subGjKQFpTXd9vttciix6ESVCFfhOdU1K FKJjnsZ8ybJ6dLhsfVlG2OZbAe7mf2HjgZtuxW91ejrpcjK604g++QMSgh4velwubH5NamXTTUz m15r9Q11MCTdjOqq8TYYv5bZrVhVzjHeY6qGGtT77AHPqWLfC8+YgugILPh1tCKc2yzolvMTPeQ hiycqWtuyjLMFzOsDRCmwiKvOuwBhdivjA2Q2F9o9xbyDw1LINXMQHfQDviUQ8rwvjElm2Avzqp 3MwlnmOU3C7pDc0OmfHMKU6iX1hKUM8lLmczAhKhNxf9ZqMF0170j3Bs2rN5UekKEmHclYg5YUC Ev2gp+BQv1ViqXI9c+iajNyJ5vX+sHUcLN2IKm5LeRXBL1k6/ZXzVi2rlKVqRUs15NSIneld88D gqgNCjzJrcn X-Received: by 2002:a05:600c:4593:b0:488:c120:480a with SMTP id 5b1f17b1804b1-488fb78bf05mr524932765e9.31.1777154939987; Sat, 25 Apr 2026 15:08:59 -0700 (PDT) Received: from f.. (cst-prg-93-232.cust.vodafone.cz. [46.135.93.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc0b4c85sm651984545e9.0.2026.04.25.15.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 15:08:58 -0700 (PDT) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, adobriyan@gmail.com Subject: [PATCH v3 1/3] proc: allow to mark /proc files permanent outside of fs/proc/ Date: Sun, 26 Apr 2026 00:08:42 +0200 Message-ID: <20260425220844.1763933-2-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260425220844.1763933-1-mjguzik@gmail.com> References: <20260425220844.1763933-1-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alexey Dobriyan Add proc_make_permanent() function to mark PDE as permanent to speed up open/read/close (one alloc/free and lock/unlock less). Enable it for built-in code and for compiled-in modules. This function becomes nop magically in modular code. Note, note, note! If built-in code creates and deletes PDEs dynamically (not in init hook), then proc_make_permanent() must not be used. It is intended for simple code: static int __init xxx_module_init(void) { g_pde = proc_create_single(); proc_make_permanent(g_pde); return 0; } static void __exit xxx_module_exit(void) { remove_proc_entry(g_pde); } If module is built-in then exit hook never executed and PDE is permanent so it is OK to mark it as such. If module is module then rmmod will yank PDE, but proc_make_permanent() is nop and core /proc code will do everything right. Signed-off-by: Alexey Dobriyan --- fs/proc/generic.c | 12 ++++++++++++ fs/proc/internal.h | 3 +++ include/linux/proc_fs.h | 10 ++++++++++ 3 files changed, 25 insertions(+) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 3063080f3bb2..497561ee3848 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -845,3 +845,15 @@ ssize_t proc_simple_write(struct file *f, const char __user *ubuf, size_t size, kfree(buf); return ret == 0 ? size : ret; } + +/* + * Not exported to modules: + * modules' /proc files aren't permanent because modules aren't permanent. + */ +void impl_proc_make_permanent(struct proc_dir_entry *pde); +void impl_proc_make_permanent(struct proc_dir_entry *pde) +{ + if (pde) { + pde_make_permanent(pde); + } +} diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 64dc44832808..1edbabbdbc5d 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -79,8 +79,11 @@ static inline bool pde_is_permanent(const struct proc_dir_entry *pde) return pde->flags & PROC_ENTRY_PERMANENT; } +/* This is for builtin code, not even for modules which are compiled in. */ static inline void pde_make_permanent(struct proc_dir_entry *pde) { + /* Ensure magic flag does something. */ + static_assert(PROC_ENTRY_PERMANENT != 0); pde->flags |= PROC_ENTRY_PERMANENT; } diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index 19d1c5e5f335..dceccd27a234 100644 --- a/include/linux/proc_fs.h +++ b/include/linux/proc_fs.h @@ -248,4 +248,14 @@ static inline struct pid_namespace *proc_pid_ns(struct super_block *sb) bool proc_ns_file(const struct file *file); +static inline void proc_make_permanent(struct proc_dir_entry *pde) +{ + /* Don't give matches to modules. */ +#if defined CONFIG_PROC_FS && !defined MODULE + /* This mess is created by defining "struct proc_dir_entry" elsewhere. */ + void impl_proc_make_permanent(struct proc_dir_entry *pde); + impl_proc_make_permanent(pde); +#endif +} + #endif /* _LINUX_PROC_FS_H */ -- 2.48.1