From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 901BEC8EB for ; Sun, 26 Apr 2026 03:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777175324; cv=none; b=NJxfO/eMKEW4MTw/doJ7xGUyfL/6rjP8jaJ+plX16xx9Kp5AqQ7ghk1krR/Bbs8+54gMvNbu9uvsmfsXieB53eRv46qrP3yPVtgd47jgIkaXtrO+2O1zoyEzrdQ7gaqPB8N90KPX7oVvFJ5MJnISbxIe0XaqBRWhrnN5DiHr7nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777175324; c=relaxed/simple; bh=HHvz2ZaXK2QzcbGlnP6++xk7IMsKeIjuCIvVKEiF1pg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PLSFPqGSBV/h+VE3zSwtK0iAObJ2l+cjiLvalrcqTLcCq50RCPtb0vwJu8m8mMfUlbk3+Sb7aOua+YNET41xednBhJzqu80KDfZpMmSaKxpvp9DAjoSvAW93rkYvhu2nMsgXpCcLAFI+T0S7jL6tD5dnvIZ7Bi87trk+FVpVeX8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OPKN2n1a; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OPKN2n1a" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c6de5ea6879so221408a12.0 for ; Sat, 25 Apr 2026 20:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777175323; x=1777780123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yXMnx4YKj4/qFMA703J2yeE4ZGQGpkhF0QjHKR6Xpfk=; b=OPKN2n1a+c1y4tgJi/KujuFP0MKVLdDUeJrkkzrWrXfR8oprKtc/VI5oIS96/UHXSG CXknyGov+LW3JZCLbftPJiumjL/fQZc/zaCoRWGYPpa9jnYYHWTvogHfDaqD9fI/rD/Q EW07Y/WcEoHGxSmTr7d7tx46uYsEHMPq8ZuxjG1+G2XpCMYruwJtKLvClxSD4QFeM55w 63L1FrvWId22sEBeyRfa8t7r5v81+bG6/snmiPnVWG61nWg22CzyeGLWPmvQcuXkeFgk 6AHJCYc8sFKNp3P4giQ7u0PpiyMZdhjU6jtfcXbru16HpmMJd3IrQIKgIksMdvCoPYWa Npnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777175323; x=1777780123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yXMnx4YKj4/qFMA703J2yeE4ZGQGpkhF0QjHKR6Xpfk=; b=mFjG1+NTz8TnzN1kiZLdqeoKGZBLqxQnyKo9jOyaFXFMU8z22hATHfPBytxBNI4rsO mosK+G7L5n5wfjkMCJDmpmmNHIJBx8h2Ip4/UbXascQDq3IqHL4xkyZEoBp89Sa6rV0q a6r4GTrrEXEImcBjI47cV6qx+UGPRl9PDDAyxwcZza3J0OS8EOlbTE6JkaRYRC9e1ojR eS6PNx3iN19CNlhKMYK4/DJbsx58tDuyFtXgaML3qEMabFep4SWIMe+3MxQtcOCiBSvY t1bJDv0I+93c7ffJPwwi8Y2BxXakKLopTLEIDKQ0/2XouVx7SCz0NhO4P+gmAiHK98NH 2MOg== X-Forwarded-Encrypted: i=1; AFNElJ+obSRr+4Mskp0mYp1SZSxJphUgTbhDnyEgrn80h+1O4nA4xZ4/c3Qyb4+XW9sqUoGb4TuU3BoPCAddp8A=@vger.kernel.org X-Gm-Message-State: AOJu0YyAnlcMWd+o4bV9V7RxWrONReD1vX9GO7yYK+VzcCXxc9AZOrtG j1itNaFCYW8Fhf574tYyzjVBHznh87NcSNv8LZj8NUN/uYOcGY1TQ85f X-Gm-Gg: AeBDievNO9iNI5KKKA788fX5FPQnEERIlWCBZ3PkSElRwg4FbPqKPlrJQqFMzOuyLt9 lGCAlegvL7VlFZgD8UNmeTg4spiBhBjdALTgiAtLAhdnj8DFIA5BVNOYEGVKdTZNpWV+tSjCkNl rOo3jS9a3O39XQFBAddfe5tzX9+PpiaVSySpXHNWNEsw5QgyTmG8gCuWoRqUgFY7TIzH2hS3FNR TFCnQAU7WPIL4ZaNVZqJdbr/BqqI79x9Gi/T38kkZyEzoezitwuCI8yuEw0j/kqsUSc/Yk9QSCa ENZmuzOylLW/gm8ZKx+rhK6GqleVypxjI8UvEBkE8Uf0Ii8EiHOngvsolYvCrhHOq4gXpcwm8B8 rxsfmrVUUeTfbabDGZdjOjQatDeORhx015CoF3tGz7DgwmfaC0XoNGHM9LGi1ua+0DbQu2vbU4a U9qLf6iFmsvh8VcRfIkIRMFEp7mtH6MCrNkkkvFA== X-Received: by 2002:a05:6a00:90a5:b0:82c:dfeb:2aee with SMTP id d2e1a72fcca58-82f8c8f8ab5mr20151736b3a.5.1777175322958; Sat, 25 Apr 2026 20:48:42 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9d2f9asm29537147b3a.19.2026.04.25.20.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 20:48:42 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon Cc: Hyunchul Lee , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, DaeMyung Kang Subject: Re: [PATCH 1/2] ntfs: fix NULL dereference in ntfs_index_walk_down() Date: Sun, 26 Apr 2026 12:47:49 +0900 Message-ID: <20260426034749.409043-1-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260425184243.116396-2-charsyam@gmail.com> References: <20260425184243.116396-1-charsyam@gmail.com> <20260425184243.116396-2-charsyam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sat, Apr 25, 2026, Namjae Jeon wrote: > Is there any reason why you use IS_ERR_OR_NULL(), not IS_ERR() ? No good reason -- that was over-defensive on my part. Inside the loop, entry is only set to one of: - ie, the caller's argument (both call sites pass a pointer arithmetic result that cannot be NULL), - ntfs_ie_get_first(&ictx->ib->index), which is also pointer arithmetic on ictx->ib that we just checked non-NULL above, - ERR_PTR(-EIO) on ntfs_ib_read() failure. So entry is never NULL inside the loop body. I'll switch to plain IS_ERR() in v2. Thanks, DaeMyung