From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DBE5197A7D for ; Sun, 26 Apr 2026 04:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777177848; cv=none; b=ntULPikt3LKZMoKG89jr32GksN8vWYmzbLl0HLfR8cTpCmoZ3n3bXrfRus2UnmaJa08HMQPZCmG0GgC5uidkQEpylJKhJ3SMz+K6FrLqZV5Y1EHITSa5BlqX+tEuVxUH59nCzhLUj2HOtROLh2ZCDHNUZushYo3X+ila9OaqnUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777177848; c=relaxed/simple; bh=3rmFVn7mfBhf5kYzkIctijPsYJdxGwGtHSCiLTSRSUQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LpMDlrgyyGjsH1KVwBy3XxKQ/CLBYbU8KQ1q3N3qZVSXH6Oyz9z3+Jy+M/Gtugh9YtEOHcgFoPyV8ltiAuntRH/8b+6+1cY0d414qmpdHTldymAPI29iCLyXQQdnSm6JPNSrahsfO3pfPwfX+6Bik/6piGufLc1mbLfpfuwDZwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZbmNYZhN; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZbmNYZhN" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2c15849aa2cso12081447eec.0 for ; Sat, 25 Apr 2026 21:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777177846; x=1777782646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BDj9dmWCvMh97BYRSTIuFj2QUSQn2a32UJtWHDEzOtk=; b=ZbmNYZhNN2CYDG9AZUXy7NXLzD2at4EigaYQuqDUsLbv2yEQ1xv9H7sZCgvXDIvCUC 4WwoQ5er0BonPghnBNKX5tzWyEVIABHaI7k2WpcgxK0yMe/6hFK4PgUfdx42re4njchW o9/APxJIXp4c/yDCzAlhG2tf0K03zQ0Dj/n3dBd9LesnX7YBJMFlez/qpzeSgFHWY3CO p1PbYwB5NRyYlYwPT0HylwZtXxgDTIy1iry9OBURkAONXrfedmfdIdQY/Z3D1CdmIG80 uJZk0eYDp9lLbaJmJWmSXIB45j6A3GnkNrRd5dhhC7zErxWO62GZD5jIuzxsGa+ePNj/ wTRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777177846; x=1777782646; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BDj9dmWCvMh97BYRSTIuFj2QUSQn2a32UJtWHDEzOtk=; b=ZvQVrEDz3TbeOCZGi9n0xcYHlC1IolPTFvX5/egCN55wIZhtQ2P+1vz2a4bXrgBR9P mFqGU59d9Uho2aNcG2NVhPkdXiM9C+SqnvvjEEZCPiZeNgs3PFzdwT6W5aQaW+Zq81nH Sv9M975x1iXPxBDe/CQhPJ4a3VcnRoMtRtUkgoZ8cthjFswKClGMxs/7lSkR7DYQCxtM 2tBg+mWFoJnqNWeI7Uz0unC3bH4xLr2A0fZiGpci6vakMmn07XkXNSTpl5zTH+vBS3Nk /zueN/AgUl4ceuxLNMJBJULm5bXRbuLZvE6JzQeFnMGxPHBSgkwCixB3mY3kGlboQ6l9 0ymA== X-Forwarded-Encrypted: i=1; AFNElJ9eJikerwKLFSI+TckkweHm+EA/1G9QVxLOA5ilMScgyKy4dwK2ZONNGtJQAIy56G3O7URcAP0LJ6A3r4Y=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtnr61LylzTL5KfD1Kl6iaB4T2OfF4wDemkyQTtfZBWwYQNRkG wCmPv4xiL6rs9JqxjOYGSPzANPjGqs8MjRIDxVpzwa4vze3pTrMd70fV X-Gm-Gg: AeBDiet48NNNgze2MTFarrN95jVyTVdQkj0l1Ei8ghSABYPbGu1yY7xtXS4ks3lO4Ia ugAdURaZqQZBU1U6gKybHM+25c78+iiaLQgJdSJRCN5cLK1pR4aDrtOWg/MRuTHZQIJbte/9a6z 8nfTW0pBobqZ/Q2b0r0iqMDgxW7czvUrSCdMs8wq6z+9RZZiJm31fV/yrDQD1XC1K2X+gOqNpvc wPgmTI/i1LY4hVexnUCmAmqXDS/9DDwEnZ9ITNM+LDUvWxCPpNb9iG6kKcBJk2I2+9lbSDEDS9z NMwJg1OTeeR352lTlPxWvLkkrIHy4H/MDhX7nt71xp/t7NedH3C8zuRqTdgp0LG2O5acmsV2Fxx /k/F6vpe6Xv/iC7ZWWDQz41q8ygq6c1WH4mQC8xHtZAO/JC6bjv9KMMNlSfWG5OZMrmA575CXil asLraHZBJ4UjpJwCm9wvLh5j1QU8ktslNNM3Rr+Ewn0egOEJZaB185q+ejcScIErCeB+owZ7mUJ s+l4QoAtfZBX2h79W32p6UuNw== X-Received: by 2002:a05:7300:d70d:b0:2d3:f3fc:bb6b with SMTP id 5a478bee46e88-2e4646cca96mr22292805eec.1.1777177846449; Sat, 25 Apr 2026 21:30:46 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:f359:aa0c:530d:9dfd]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53d2cff04sm37796971eec.23.2026.04.25.21.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 21:30:45 -0700 (PDT) From: Dmitry Torokhov To: Luis Chamberlain , Russ Weight , Danilo Krummrich Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] firmware_loader: builtin: ignore 0-size firmware Date: Sat, 25 Apr 2026 21:30:38 -0700 Message-ID: <20260426043041.649202-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, the builtin firmware loader allows 0-size firmware to be returned successfully to drivers. This differs from all other loading mechanisms (filesystem, sysfs fallback) which reject 0-byte files, and forces drivers to add boilerplate size checks. Modify firmware_request_builtin() to reject 0-size firmware. This will also result in firmware loader falling back to other mechanisms if an empty built-in firmware is present. Signed-off-by: Dmitry Torokhov --- drivers/base/firmware_loader/builtin/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/firmware_loader/builtin/main.c b/drivers/base/firmware_loader/builtin/main.c index d36befebb1b9..1dcebe8e7f8e 100644 --- a/drivers/base/firmware_loader/builtin/main.c +++ b/drivers/base/firmware_loader/builtin/main.c @@ -53,6 +53,8 @@ bool firmware_request_builtin(struct firmware *fw, const char *name) for (b_fw = __start_builtin_fw; b_fw != __end_builtin_fw; b_fw++) { if (strcmp(name, b_fw->name) == 0) { + if (b_fw->size == 0) + return false; fw->size = b_fw->size; fw->data = b_fw->data; return true; -- 2.54.0.545.g6539524ca2-goog