From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649003128BE for ; Sun, 26 Apr 2026 09:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777195076; cv=none; b=rpt3z6EDrRK0FfzEMVu1AJDGrU594D/OyNMa7KSqfRjUgZQ96jhSo79TNKVoSdYJv23aJO0Xmu0Aw7NqyzPF/v4igmoHoRewZ7lVGi6O39p5xa3MIgIsVtaZkxho1VsVP/UpXlDtx7AHCNXWXwkTyVQXi/UknLDFCKKlNiW5kfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777195076; c=relaxed/simple; bh=Tl9tD+ph9kNEON0ieUFN/yRGnWD83boxn4tOUTxDMCk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lLFQkQYFo9fiC3y+6N5/e9pWTFTYnjpRlIJORVq5/HanjxcIvbbP8cMxR8X8ZO1p1iq/JeWyfxxk3GFWqnSdyM2SvzUg4dLUOWC24m3e5EcaVoawOnIyaRe6VnC2fOEk2gQtj7PFtuOSKdDtu1++JovlGfUcmJ1KxrJ1wJTgdTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j+iw4C/G; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j+iw4C/G" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82f1f6103afso4256870b3a.1 for ; Sun, 26 Apr 2026 02:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777195075; x=1777799875; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6NOjVOegFQrtS3izH9LBynQBmkc3ptaz6NtorLHbOAA=; b=j+iw4C/GuWXXjyelWyqEYkpmcybvu7u6ItRQ2NtwUInyuVFpfqdU/ClCmZM/s9VV6I 2lqJcx9lQ3lmYhHTWqS4sBYE9rC5Fr2O8etfISHZ0JTlXgt9R13wb4n+K3kZ5RumYccu aa5iQGVnwVJWr5SuVa90FCo0tDpGYmYlpMPCHJWDH9k3LIQgbwoNGBWJiOhSdMDvBl5D gn91Qn2UGCly33V83LHhuWqqTLNiRiDbUvu8HWRQtOcPcHxei/vq0Poftgc47UjHGlmw SXa0YfEajRm53GWFii2DiFdxPjn3A43c6xPqUoB2QIMxc4vkHQIEhynHzGF0cEd4uEF4 a0Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777195075; x=1777799875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6NOjVOegFQrtS3izH9LBynQBmkc3ptaz6NtorLHbOAA=; b=fJrc8MqM+9Hs7iKde7vYLRJqF7IaP88F7AhLcAfkikdAF+dGv6u+LPqakhkFQ3WzU7 PAzYYXo72/WGcLjPCA0F7BYjqHz9cmDDUicaprX3y8aH4VgxJ7r5oqlXHI8L81OjyvSG GtU8oZtX6fpohESY07Mv8vbh+M5IDUgGwOycWa9igwwHKwIlnl40fqi7xOYNkB3MAFrp 6l2YLnKK6qxCR8mDVcVpO9bH4nA7QYbiqCZz5dJI8JuHEPNWvhCTThRehXJJfj+yAm7B TSIgg5tm8YHufqTTuQdJOO2oH9Gw3ZVvcgchqbSjVq//RXy9wfWagaJNIfGbVQwaUlDK fhxA== X-Forwarded-Encrypted: i=1; AFNElJ/oqjVDqNF7Y01PaWnVYAf9ZJnlpR4q0wzPRRiimXWDovtcXhlhAHkwzpJE6VSF0WA6XZwTQYHvL4oDaQ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwxxf+MtvAnayjk4+qpSMcts64ghVwYkkejn/vgZKhhfRm5156 6wsED2OxcbuBrt00krLkNSqiF8ikKsF3FLR4npZkE6kXzOqwVKSIWrl2 X-Gm-Gg: AeBDieuHGL3VgRa32LbjzFYAETBlUYmrtLuxUeR9bIbEm0/K1eTPtdevQ6jpQpQnF3K kdymN2RXrA3xfrdFZXXt4qXpDQ7Y2EOyvXtoGYwxFzATRXX6tNGrTWfMKoYxLKNAVC88XId95nn vCXLPS4jslq/H14t0eSf4fqumQtZ3mCSwrChWouG2tBbItefBeXo542/9Uj+w9cK//uw3XxgslE PX0Hos0bGX5y16jjXv4bnaOeslksYKtvLEVlbcVlZWXY12J9gKx9QT00a908bbYj4TzMXt+bP5x +S7SAHczzMdXCEFkmElbVA0tq7DHG13JTRZKXgXV8PksSB7Wu+ou0A909eWKGr8e/DijZT16+8k dt2yqXP09JbeLSC+ZSgGjSyV6SomY6hsgRPA/Beq3N9FcaMVv4Hvib2vER6wgWF4x8AMf6uP9bH /q3CE79fGr+j1nw4+sFwBGxQ/XGEnZQCu2L6FBVLb+cFmGXu/R0gO/s4IpFdI= X-Received: by 2002:aa7:88ca:0:b0:82c:d9d0:f482 with SMTP id d2e1a72fcca58-82f8c976ff1mr40075723b3a.46.1777195074840; Sun, 26 Apr 2026 02:17:54 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e982fd3sm36145226b3a.10.2026.04.26.02.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 02:17:54 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, mingo@kernel.org, christophe.jaillet@wanadoo.fr, nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org, kyungmin.park@samsung.com, k.wrona@samsung.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 8/9] iio: ssp_sensors: Use dev_err_probe Date: Sun, 26 Apr 2026 14:47:09 +0530 Message-Id: <20260426091710.3722035-9-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260426091710.3722035-1-sanjayembedded@gmail.com> References: <20260426091710.3722035-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- changes in v7: - Drop redundant else with refactor as guided by Andy - Add new change in series for local dev variable with input from Andy - v6 change: https://lore.kernel.org/all/20260415050749.3858046-7-sanjayembedded@gmail.com/ --- drivers/iio/common/ssp_sensors/ssp_dev.c | 38 +++++++++--------------- 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c index 5415efc7bf48..22d26980baa2 100644 --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -517,25 +517,19 @@ static int ssp_probe(struct spi_device *spi) int ret, i; data = ssp_parse_dt(dev); - if (!data) { - dev_err(dev, "Failed to find platform data\n"); - return -ENODEV; - } + if (!data) + return dev_err_probe(dev, -ENODEV, "Failed to find platform data\n"); - ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, - sensorhub_sensor_devs, + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, sensorhub_sensor_devs, ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL); - if (ret < 0) { - dev_err(dev, "mfd add devices fail\n"); - return ret; - } + + if (ret < 0) + return dev_err_probe(dev, ret, "mfd add devices fail\n"); spi->mode = SPI_MODE_1; ret = spi_setup(spi); - if (ret < 0) { - dev_err(dev, "Failed to setup spi\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to setup spi\n"); data->fw_dl_state = SSP_FW_DL_STATE_NONE; data->spi = spi; @@ -593,16 +587,12 @@ static int ssp_probe(struct spi_device *spi) enable_irq_wake(data->spi->irq); data->fw_dl_state = ssp_check_fwbl(data); - if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) { - ret = ssp_initialize_mcu(data); - if (ret < 0) { - dev_err(dev, "Initialize_mcu failed\n"); - return ret; - } - } else { - dev_err(dev, "Firmware version not supported\n"); - return -EPERM; - } + if (data->fw_dl_state != SSP_FW_DL_STATE_NONE) + return dev_err_probe(dev, -EPERM, "Firmware version not supported\n"); + + ret = ssp_initialize_mcu(data); + if (ret < 0) + return dev_err_probe(dev, ret, "Initialize_mcu failed\n"); /* * Managed shutdown action for the SSP device lifecycle. -- 2.34.1