From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2EF230DEA6 for ; Sun, 26 Apr 2026 10:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777199275; cv=none; b=fv2xTvtnnlnl1ZH9n9yP3D2uKjY5dilIYNBh82r7XOvOrPaJgA+O/T+Jh8UKRSr35J8nfRuiV2av0HCfGhZ5YiGqoJyNgADMe2h8QTxjlOCtru9+67uhUYzEdhBYGPSz0sjd6ebsZyiJl0akGsEGLw9WQ4fPohxNQSLR9eIKtLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777199275; c=relaxed/simple; bh=L9ifB2+cy+2LDzEt0ZlP5b8Q2sx5ZkyS3MOtdzgWJDU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NQRJl0Xmpgyz7GUaZST9KMbyxRfqeRIvuOn0tav7GZnhvYzNYIkENzE0tGN0jq8t9ug19MTO2WrlxsCpUiigxEoCYG0QHpQ0qMSPDWai9WTtu1W6hZF8rX/phVMa1+oKj28GiDbAQpAuBX0BCXOmV0dOZebFM4C8z3HJsDcQJzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SKJ65eGR; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SKJ65eGR" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2b461310af5so36220995ad.1 for ; Sun, 26 Apr 2026 03:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777199274; x=1777804074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yu/AcDmMgQxjjXzwRaT9ZvzbaZFSbVyof8iOxklK4fo=; b=SKJ65eGRDCeLUr7mpzPs0veVtJMFd2DT10u7+Gle937ZCDZCQooKlVIt26UpSAMejI bPMOlqKa9iJoL3JyA0xPO7uvc/PJLNDKV3/xvZSuzE15EpYqFECbilcFsStAO5chlLQa ZpbDHmLO5VCPAONZtriBD51PKDUo1vpd8Rix+JVrhG5eBeOEf46FHBKr7egt2NCU3B93 HiCU+fKhPo1NvUpSOUoRVLDoPklZhzlFoDJsParloub+af+kUMvpVUzcsSM5oySSJVG7 h8QPH1g38iCwTDkWK55Luzyy6j/0/kDj5yujRZlHG//f7VRZPVW1OwcZoIe+wOwXqgPh 9z6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777199274; x=1777804074; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yu/AcDmMgQxjjXzwRaT9ZvzbaZFSbVyof8iOxklK4fo=; b=bBKvTFTIwV+ihcpMcpDiRXhj2vRu6GqVWVoHuXfZPA6HbdkfRITPa3gkgrxt01FioT fI1omPA9kuIvp/EomdIDFL06K9wUyLlM0NwiWoc6HrNkT6Hr4wv+yWniRTr+ico9VzXV sccWXbr9LjhIaSRDxSCqFXnA1GpruBQuCp+OSS7Tya8Qvoo6mfNSo9E68oq2HToyAtNA J4IznIwZ8vFlUP6+iNahG1bWJg5npt+21kCwfXN1u/+2jxpc7Cu7hWfrds0r2WJnfmqI M1h1L1uvwvB/4Y2uk1hgMmRQ20ONvdrjxw1Um/s6BxNbHsvGn17YGQO/s6eP7N42phjy Qo/g== X-Forwarded-Encrypted: i=1; AFNElJ/ZbP42eY0oHw95opZKbkeFgioLhjyKotv1vwpnc5B+k1di/M/9nR4Aw3SsSN9aw20ov5rp5tp15r+MNR0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2G9GstRbF6QuGOO057P1J0LEXB0r4YnCaclLyyslMzsIrUsAs v44sFN4//aBwpuOV33Jv9IwjVAhRraBGeLdWsaumq93Lw2MRbm4T5I/S X-Gm-Gg: AeBDiesI3//sKnn4ZbwatOhKUEz2PhjKnpWZBi/IwLmOvqmdeooFakmv4Yq2iFDTaiS ZGPHsBjzQLs+0UeTJHZ0oUER2/ahCuR8kaZlxL6dkh7NyGH/eqx3mgFVtJFdqqmpOsikFahnxV6 PA5oK03FC+3dedY/GvC+O1mrWybutixm/MYiGwcRhQAlPcQRvRqVtbAN9SJzrHTmFcSp9kTuUlI 06Cozmnqrbc+jpX2wXy/oRx5KyfHeQTZqJJz/5WZpOf1FEVgm3lJo8AMHLAFCQeS/E+j5PbN1NK /hnGvsE617ccwETVjDdUMQTeuP1K2o9ABHo40RXUw1kXKixCYscn685gfhpXhSHmt1v6QNEuz6c Dq6qcqAxU4VUYsIyPp9S5CduKmbP24/8pJUd2YYdO1lle35QVrHAedUZVZ7MKy5iunAuRLTRkKN AKV0oQE3tECRdth0x3SC+tQoBpoB4jVT5gsFpVhkr4o2rwXAw= X-Received: by 2002:a17:903:2c0e:b0:2b2:9a70:3f0a with SMTP id d9443c01a7336-2b5f9da626bmr326085495ad.4.1777199274030; Sun, 26 Apr 2026 03:27:54 -0700 (PDT) Received: from LAPTOP-DV5I1MV.localdomain ([27.19.123.93]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0db13sm293629615ad.53.2026.04.26.03.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 03:27:53 -0700 (PDT) From: Yufei CHENG To: mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Yufei CHENG Subject: [PATCH] platform/x86: lenovo-wmi-other: fix uninitialized variable in lenovo wmi-other driver Date: Sun, 26 Apr 2026 18:27:24 +0800 Message-ID: <20260426102725.3204-1-cd345al@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the flag relax_fan_constraint is set, local variable 'raw' is never assigned, and lwmi_om_hwmon_write() will pass uninitialized value to lwmi_om_fan_get_set() resulting in undefined behavior. This flag allows user to bypass minimum fan RPM divisor rounding, but assignment to 'raw' only happens in the non-relaxed path. Fix by defaulting 'raw' to user provided 'val' in the else branch. Fixes: 51ed34282f63fab5b3996477cc56135eb4de5284 Signed-off-by: Yufei CHENG --- drivers/platform/x86/lenovo/wmi-other.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index 6040f45aa..6c2febe1a 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -349,6 +349,8 @@ static int lwmi_om_hwmon_write(struct device *dev, enum hwmon_sensor_types type, */ if (!relax_fan_constraint) raw = val / LWMI_FAN_DIV * LWMI_FAN_DIV; + else + raw = val; err = lwmi_om_fan_get_set(priv, channel, &raw, true); if (err) -- 2.43.0