Re: [PATCH] iio: ssp_sensors: cleanup codestyle warning

Jonathan Cameron
2026-04-26T14:36:15Z

On Sun, 26 Apr 2026 16:26:53 +0530
Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:

> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>
> Reported by checkpatch:
> FILE: drivers/iio/common/ssp_sensors/ssp_iio.c
>
> WARNING: Block comments use a trailing */ on a separate line
> + * */
>
> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> ---
> drivers/iio/common/ssp_sensors/ssp_iio.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/common/ssp_sensors/ssp_iio.c b/drivers/iio/common/ssp_sensors/ssp_iio.c
> index 78ac689de2fe..e83f589fd72c 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_iio.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_iio.c
> @@ -24,9 +24,10 @@ int ssp_common_buffer_postenable(struct iio_dev *indio_dev)
> struct ssp_sensor_data *spd = iio_priv(indio_dev);
> struct ssp_data *data = dev_get_drvdata(indio_dev->dev.parent->parent);
>
> - /* the allocation is made in post because scan size is known in this
> + /*
> + * the allocation is made in post because scan size is known in this
> * moment
> - * */
> + */
> spd->buffer = kmalloc(indio_dev->scan_bytes, GFP_KERNEL | GFP_DMA);

Hmm - I missed this in previous but you dropped a GFP_DMA marking
and it's just possible this platform has restricted DMA addressing and
needs them.

Otherwise it should be easy to cap how big this buffer can get and hence
do similar change to make it fixed size in ssp_sensor_data.

> if (!spd->buffer)
> return -ENOMEM;