From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F06F435AC12 for ; Sun, 26 Apr 2026 11:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777202693; cv=none; b=VFdkX00OGWHrqBYjra3AyKx6pWQCQVdxQRm1xKFTQu0rGr4g9peX5Nrv+A0HXs8m/7ZwXNEeVGTNYQavSk+P/9xjIfPr8pi6ZkhDrVLBRYIXE1LG+EvjU47JSXZDnBnI/hrdJBtuUh7qUJCNB5P1rBx3tAYd2FT1E6Iun9LMOJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777202693; c=relaxed/simple; bh=cth7IxMx4vL9wP/1C5eXMoW+1v/9cyIj7UCsykLIt3g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H7+53k/C8ZyMLc/zC80XkTU86331H7z+QEkJ4yEBwnTq/8k9euSldhsjEecarRy2eXqxKHdQzoXmG3M1ifaTwavwTSkYHRmgwenmI184dpdAeGnFNfr9br3jvU3k6MiB4uR+8a4cIfyAR2yAw3h6ml4vDCgyEiAV7Xc6mONHMAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UMfv58lR; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UMfv58lR" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48374014a77so121886455e9.3 for ; Sun, 26 Apr 2026 04:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777202690; x=1777807490; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DEYBGn4RFp3NqRbemrgiMNi+WUGjPXcEfhUYRQfZnUo=; b=UMfv58lRbShEXUOz946BRsy3PsJ80lcu969JwSRVziP38l6G/ZvrRsfFEVCV2sLMmF n9Ynfu6QwqYiWU5q5WJ6i7KgFns+yjfZo63IuPlR2ACcnllzntJmFrOdUUL3kmOGPB15 qZjG3DjDGEKeW3hzy7DmwC/+moU6tfaW7CGwyTDT8TWTCfv7Wdc8WOWUYT5ejBrqQq48 2/q7zK/y7vQCPap7iZuBO8eBDDkbj2cJi/0DMYlhz44s/WDv04uVoglrRnMTcMhoyJDM Th4MLKTkV4f/8Foy5L87bTYX+MNhEy7WEc/Izoopa/nvijtcsdnq3Ojdzc9J3YQXggkd qViw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777202690; x=1777807490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DEYBGn4RFp3NqRbemrgiMNi+WUGjPXcEfhUYRQfZnUo=; b=chNk9QO9Ayp6qpcHW4iC+8EkFw5rI85+adSD1Uy/MtmKIb/BOd+9av/tcvRb0cetnl V7IDqjAYvXeXyYGCCaSR7M4yqMREo5PgiOaLKmlwfU4QcztdFrLIFIYSdcGTRrtO6jF5 yyJSDfbTh05rWohIgDU+CFouDpmwRUdc1vF7pBII9tJbgeVKhOYJFkH3n2p7SvlbtjSU 99Q6836Pr70ygnmlDDiZdsFxQzND1TtW5jKGfxa/nWoLGxArdN01OoLyuBJCyjVuE4eN 1c+MH2f8XriyJrwHtGtjsu5CT5/UCqJ6bFn9bWc7fpZGqAdyxF+jPf6f8sPfKqiRmA2t tJww== X-Forwarded-Encrypted: i=1; AFNElJ/osF494tkciQPxKWvNyA+Zzf562CyE2hQcTMTKbr4G0fBzPPBO3Vs1sm54b8ox2fo0DMGJksfKmII15Fw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9KFsfXuuXoOcC5SHHz0wJR6nPQt0IA1bHNOWqN6PwwKPUVLrE gBWDcQ1NQ14Wut9Gc2RXQZcTrIijvHLApXVIXZ4BNr1gIoNNBCOAPh3c X-Gm-Gg: AeBDieuna7u58rQf/nxzlDjuTNAS4ycPJtAZzUKXXGgHkhiVnZ0xDJBhMXKoZB0bZe2 R4SMvQx4PA4veSY+amYtQfksqz39fMmGSobUPaWelEJEIHLaO6zZ4y0gyM1Me0WYZ/GtlgNeMnW YC6SsPFuZH97Kc05EpQt+BzXTtN05Ke1w4cEh+uObgfd/jVJb/l26Vd2I4GWODJSAsq0AOjEjEy CR5CkZaXfJfd+7XapiRtZQJMm0QlWNkKsO5J6dmWEs/vsF2Rctn+Ta5lOhqCW8C2KhmEskU8UPf J53T0epjl2HyRL+/Q1ZPGNSyHkhxQyvsisfsib+y2rR2HklhbOlfKjt4fKIKml+62vO51GYwV3b 5LFHsfxjDhMU2ebb+Bg/D2Bk6S27VIkW2cBwCzh9AM/Qok7ZiSCXIm/XmQ4KCsIlijQShVs22nD X81ExRfAO7ZTLN/LJRiYQIhWq+cjyTUMfyjnHF X-Received: by 2002:a05:600c:8b28:b0:48a:5c23:cab with SMTP id 5b1f17b1804b1-48a5c230e78mr267530895e9.19.1777202689993; Sun, 26 Apr 2026 04:24:49 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44123d23e0bsm33285999f8f.15.2026.04.26.04.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 04:24:49 -0700 (PDT) From: Andrey Skvortsov To: Jean-Baptiste Maneyrol , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Marek , Brian Masney , Rob Herring Cc: Andrey Skvortsov Subject: [PATCH v3 3/3] iio: imu: inv_mpu6050: control vdd supply using devm-helpers Date: Sun, 26 Apr 2026 14:23:34 +0300 Message-ID: <20260426112334.3938774-4-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260426112334.3938774-1-andrej.skvortzov@gmail.com> References: <20260426112334.3938774-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vdd supply will be automatically disabled on error condition during a probe and on driver cleanup. Signed-off-by: Andrey Skvortsov --- Changes in v3: - no dead code in inv_mpu_core_disable_regulator_action anymore since st variable is used to get 'struct device' now drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 24 ++++------------------ drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 1 - 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index fc786aaeac5e5..880bb7b8b83b1 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -1863,12 +1863,6 @@ static void inv_mpu_core_disable_regulator_action(void *_data) { struct inv_mpu6050_state *st = _data; struct device *dev = regmap_get_device(st->map); - int result; - - result = regulator_disable(st->vdd_supply); - if (result) - dev_err(regmap_get_device(st->map), - "Failed to disable vdd regulator: %d\n", result); if (!pm_runtime_status_suspended(dev)) inv_mpu_core_disable_regulator_vddio(st); @@ -1948,28 +1942,19 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, device_set_wakeup_capable(dev, true); - st->vdd_supply = devm_regulator_get(dev, "vdd"); - if (IS_ERR(st->vdd_supply)) - return dev_err_probe(dev, PTR_ERR(st->vdd_supply), - "Failed to get vdd regulator\n"); - st->vddio_supply = devm_regulator_get(dev, "vddio"); if (IS_ERR(st->vddio_supply)) return dev_err_probe(dev, PTR_ERR(st->vddio_supply), "Failed to get vddio regulator\n"); - result = regulator_enable(st->vdd_supply); - if (result) { - dev_err(dev, "Failed to enable vdd regulator: %d\n", result); - return result; - } + result = devm_regulator_get_enable(dev, "vdd"); + if (result) + return dev_err_probe(dev, result, "Failed to enable vdd regulator\n"); msleep(INV_MPU6050_POWER_UP_TIME); result = inv_mpu_core_enable_regulator_vddio(st); - if (result) { - regulator_disable(st->vdd_supply); + if (result) return result; - } /* fill magnetometer orientation */ result = inv_mpu_magn_set_orient(st); @@ -2108,7 +2093,6 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, inv_mpu6050_set_power_itg(st, false); error_vddio_off: inv_mpu_core_disable_regulator_vddio(st); - regulator_disable(st->vdd_supply); return result; } EXPORT_SYMBOL_NS_GPL(inv_mpu_core_probe, "IIO_MPU6050"); diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h index 6239b1a803f77..2c0cf53c9a627 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h @@ -206,7 +206,6 @@ struct inv_mpu6050_state { u8 irq_mask; unsigned skip_samples; struct inv_sensors_timestamp timestamp; - struct regulator *vdd_supply; struct regulator *vddio_supply; bool magn_disabled; s32 magn_raw_to_gauss[3]; -- 2.53.0