Re: [PATCH] staging: rtl8723bs: replace NULL comparison with NOT operator

Greg KH
2026-04-27T03:51:31Z

On Thu, Apr 23, 2026 at 03:42:02PM -0300, mgcvale wrote:
> Fix checkpatch error "Comparison to NULL could be written
> "!psta"" in ioctl_cfg80211.c:2432
>
> Signed-off-by: mgcvale <miguelcvalealt@gmail.com>
>
> ---
> Hey, this is my first patch, so I appreciate any feedback.
> Thanks!
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index fd3bae31b0ed..8ae3adecafd9 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2429,7 +2429,7 @@ static int cfg80211_rtw_dump_station(struct wiphy *wiphy,
> spin_lock_bh(&pstapriv->asoc_list_lock);
> psta = rtw_sta_info_get_by_idx(idx, pstapriv);
> spin_unlock_bh(&pstapriv->asoc_list_lock);
> - if (psta == NULL) {
> + if (!psta) {
> ret = -ENOENT;
> goto exit;
> }
> --
> 2.52.0
>
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot