Re: [PATCH] staging: rtl8723bs: replace NULL comparison with NOT operator

Luka Gejak
2026-04-24T13:39:44Z

On Thu Apr 23, 2026 at 8:42 PM CEST, mgcvale wrote:

Hi Mgcvale,
thanks for the patch, few notes below.

> Fix checkpatch error "Comparison to NULL could be written
> "!psta"" in ioctl_cfg80211.c:2432

You shouldn't break line above like that, idealy break it at 70-72
characters, not 58.

>
> Signed-off-by: mgcvale <miguelcvalealt@gmail.com>

Signed-off-by tag must use real name to satify Developer's certificate
of origin, so Signed-off-by: Firstname Lastname <email>

>
^^^^
You also have unnecessary blank line above, which should be removed.

> ---
> Hey, this is my first patch, so I appreciate any feedback.
> Thanks!
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index fd3bae31b0ed..8ae3adecafd9 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2429,7 +2429,7 @@ static int cfg80211_rtw_dump_station(struct wiphy *wiphy,
> spin_lock_bh(&pstapriv->asoc_list_lock);
> psta = rtw_sta_info_get_by_idx(idx, pstapriv);
> spin_unlock_bh(&pstapriv->asoc_list_lock);
> - if (psta == NULL) {
> + if (!psta) {
> ret = -ENOENT;
> goto exit;
> }

So please send v2 with mentioned changes, code itself is good and should
be left as is.
Best regards,
Luka Gejak