Re: [PATCH v7 5/9] iio: ssp_sensors: use local struct device

Sanjay Chitroda
2026-05-03T12:07:06Z

On 27 April 2026 1:39:32 pm IST, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>On Sun, Apr 26, 2026 at 03:16:51PM +0100, Jonathan Cameron wrote:
>> On Sun, 26 Apr 2026 14:47:06 +0530
>> Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:
>
>...
>
>> > Introduce a struct device *dev derived from &spi->dev to improve
>> > readability and reorder variable(s) to follow reversed xmas tree style.
>> It's really minor reordering but generally I'd not do that in a patch
>> that does anything else. So here I'd have put the new variables
>> in as close to correct location as possible, then followed with
>> a reorder if it was worth the churn that results. I'm not sure it is
>> in this particular case.
>
>+1. And ideally that 'i' has to be converted to unsigned type.

Thank you Jonathan and Andy for review.

I will keep this change specific to dev and drop redundant probe failure log.

Also, as a follow-up change will do re-order variables and have unsigned type change.

>