From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37CB93019BA for ; Sun, 26 Apr 2026 21:43:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777239818; cv=none; b=VqIJ6VAwYnSMN+aGVfmYtdVrAB/kzNdGprt0yt6UKoS4S7G0Zsba+8zagTW6lB1ticjgdJGSw55hRLaky7QK1lKUEZbpzWUW18vnsQsyKNvW1gVH0Ag8VSzoTaCOJKXI/JKVZ8YmUNeNEsiNDzuUC5t6Nts5X8yutUvONGxEXFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777239818; c=relaxed/simple; bh=LPWavIZ/gOJwBHcgiOClWB2JoXZPTl0uqt1pe5AXjT0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=umDscvb8xgEhPOh3ODjCHmgcwkQanC4PffCDpmomk4JGHCyPKDhcsH7il8QHEQEAJqjmYHJIXLX6zbTkB348NPRPlifeaiKB4ksZ7COo18+D6QdbNATa4+oZfHm4cbbN91aErIEYesk2qkUMvG9q8Xx4YYtalhTSSFsVVn4zOIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LZiMGVpT; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LZiMGVpT" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so88130955e9.0 for ; Sun, 26 Apr 2026 14:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777239815; x=1777844615; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FUdLgQOCVlyixTrdH7a4UDIcauv75NFTtaENVvxSOB0=; b=LZiMGVpTTndH/DySeXr4HBvh2OA8adnCl8GxEEeTMFge29737Hvs0QkmVbgcySUgMJ pni9QOW3dAgO/UZ7ZdlwXKpzFLaEdV8OVNIcSGysrnIBg009ivqykzihNZRqyLCSsJ+7 1t84g1+UeElc/FShffngKzDXeJY43pYbMN0DaxyfoKUyH80LQtqbvosp6q8pmfcssKmx OTBcgZzxWBfn21q2Vte++KY6EegGmni97sjs0pQp+HyQu+L83IHp0iUPBhUNhFobAGjI WRQeCp7TJU0pUR+bufv9CPU4fOtwkaZTgg5S1ffsEAtsMxgD/1BOQbnGnuPHynpekxvB 1NCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777239815; x=1777844615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FUdLgQOCVlyixTrdH7a4UDIcauv75NFTtaENVvxSOB0=; b=YaFfDepEaEMXQZdCM7nDOegGB3ffDMANHkdRwpGfQtsjoUn6EVSgterYQmZX2MoUCD U5K/9Nu8TGb3WWxPTara1kQ15dTN8io5lYPX5Oa+VQz+n4CzGlmGJNpXunyoWTq6YhDa Nb2HvlwzIIm48wXPU58DTqz56WWN4ADqidBpqYOd09l4gc94RJat+MNrvNsWDR6Zf+6M Z+Em/7cPze5fTuCm22Np27s74QkV0ai/nhowuKS5xykbcBeizE5EQfmA8bB1nx2BHLL4 UB05maYWkkIG1CE6BjIpOaI2FbxAihtxy2kAHhGtGoc4HVjb6xaVtMdsXKsDzHUkWgvX bfiA== X-Forwarded-Encrypted: i=1; AFNElJ8tBDNnes8/L8rFZItELHsGFvkONelhTCw/Z7M4smXjjzPXh4gyNxUBRo6jb7GY6Fu9KEZHaEJLeZNuT+Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz46Nu3m+hLMACcIXMarmJdfJoQkcYol6Qo1HsmaI40EzwEeMBg CB9Eqyy3psuN0GuuRrdakWCHmN4tYV07/bHfL8cFH3f13y+OJzU5XBFm X-Gm-Gg: AeBDietBCeVU9GkJG11mXc+kXSxQk3tkaRDcIXe+p6cFTv51lfkeiB2n8bp7bjepKjI g4oUd0A2oVAcXSXEwrVLgO2z6jibV+IvQR9liCsosuUNXVS+NWrFGHlQyYRe90QFDsumaEYJ+my 1sYW4UU02oTlcTFFypRuDH6GobXS1D7STZ0sMDdoSQ8tEuqXX9hfcCiBb19JGnXWGuc4lKQ6bAC 66keeT6+pX3VXJuXquu/drH+3flnj48ZKd/+j1slHjxNZl7TPpC7jmPVo2v3hc4Vl+eJLxtG31b HAVc2DoP3gD/h+UFSPSQZqBQWj2CGKCHoV0jr/I54wEDyAnB6KII8QBcp1js+FUmY+dIB2TZThn w2iOimD5lYuihP2cP+Kdbrjv0FCNOfYzvdcajLA+lULDq5T0ZXRwvZF607h6BYn0cjmffU36xga WE6U24qJCTKAzx/1C1u7BFgm0kp13+cxu5bEcBYaURYX5lwr2H6GMB4rPWoueKDsR9gl9H9dQj0 as= X-Received: by 2002:a05:600c:c085:b0:488:c530:48a0 with SMTP id 5b1f17b1804b1-488fb784843mr454167245e9.24.1777239815396; Sun, 26 Apr 2026 14:43:35 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a52583fe7sm423356605e9.13.2026.04.26.14.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 14:43:35 -0700 (PDT) Date: Sun, 26 Apr 2026 22:43:33 +0100 From: David Laight To: Andrew Morton Cc: Min-Hsun Chang , arnd@arndb.de, msalter@redhat.com, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] asm-generic: replace ________addr with __UNIQUE_ID(addr) Message-ID: <20260426224333.5916c960@pumpkin> In-Reply-To: <20260426110932.786047b4338843e0a91abaa9@linux-foundation.org> References: <20260307092119.20733-1-chmh0624@gmail.com> <20260322144032.7353997c@pumpkin> <20260425135737.e79c4b546d22b5ebfd96c0b5@linux-foundation.org> <20260425230134.5449498a@pumpkin> <20260425151240.2a46e3a8640fde3902461d41@linux-foundation.org> <20260426114938.4dff28c8@pumpkin> <20260426040925.b25cb2a32680bfe884431abf@linux-foundation.org> <20260426183420.2216d187@pumpkin> <20260426110932.786047b4338843e0a91abaa9@linux-foundation.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 26 Apr 2026 11:09:32 -0700 Andrew Morton wrote: > On Sun, 26 Apr 2026 18:34:20 +0100 David Laight wrote: > > > > > True - don't look at what strlcpy() can generate. > > > > The inline code should just get the constants from the compiler and > > > > then call the appropriate function. > > > > > > I can't actually find an in-kernel strlcpy()? > > > > That is because I meant strscpy() :-) > > > > In particular https://elixir.bootlin.com/linux/v7.0/source/include/linux/fortify-string.h#L275 > > Particularly once it gets as far as calling strnlen(). > > Oh geeze, why did we do that. This is the kernel - string functions > aren't fastpath! Someone please move all that gunk into lib/string.c! It might be worth selecting memcpy() for fixed length copies that fit. Especially since that can get inlined to something smaller than the call. > We'll still need some macro if we are to retain the (imo silly) > omit-arg3-if-its-an-array trick. Try: strscpy(tgt, src, len, spare_argument) I'm pretty sure it compiles fine. David