From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAFF6548EE for ; Mon, 27 Apr 2026 04:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777263369; cv=none; b=NbzJcFRHUlREgo02rjOvoA/jysLRrmXp/gumHNuhk8x+T6ayBKauq0wq4RuROsF0Q2T95y8gT/+WlI2vF62g8ZG6gQGnCUxAKXdj2tZs8ClKlKYifFozGFVjwbfT7w37Foo6fw5VS3OB9lfUAGeL+gCofdayEKSsbMg4YhkjE44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777263369; c=relaxed/simple; bh=JpMtl7hbhulzV3nwZu9W/pbsSbxH1L+bdiYDdJ6ND2U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EG0SXDL7D7MV7NHw+6r+WpUk4hVemW+CDxT6/VjfEfnsGu7d/yF+p4t0giF7tqcHL6pEiQD7+6+szFPl1KrogPwY9Jup5qKN7Ny7VAfJiDGPODIZ1WnP9Cfd6Gxzy2aAfAHcE/vESago1mWOFMttwp3HF25pydGoy6+rygel2LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sJ3FZ8WP; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sJ3FZ8WP" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-362e50b4641so1848560a91.0 for ; Sun, 26 Apr 2026 21:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777263368; x=1777868168; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SBVsMfFl0yEAUw1ZjN5+lI+UR2Jh/4TxSk7il6f/7BY=; b=sJ3FZ8WPGmBqW48uUNDoI4R8bVmctrVA1MavG5jh3ChURgqBYoXjBdL3CSK/CCIMKw RhCYOEkjOSufDfR9ZYm9B0INu1aLQqfESvXFNVR1YRboRzBTPk2X41rs8feLcO7o09ir 0uCKiSTsAD3XYstJ72bySXdPGYvX2ad8DdU6cYaOOteuIwkO8bLrydboHyiTs3rlQS/1 ivkJB6Zf6Eh1zxZ60KX69Ae0vBfI9mnjL8wfyfmk0IXrjO92mfIALC4ZI9SDHB5/LahE qqiPrA1BK4BD1AEtfaG7zVhDxxao5Rvw2dIBZViumFEtABiRtTXOPVYN9Cjn1hLlLa+u SEuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777263368; x=1777868168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SBVsMfFl0yEAUw1ZjN5+lI+UR2Jh/4TxSk7il6f/7BY=; b=HZgXQaZPSclqNVUa0sYdU1tV3C29L1dqFxdKQgzHEuszt3llEStdkj+uPtOFBxIvwZ vyTt0qjUuLeuOULtY9Uy46rp/Gjz3vObPMP0NYJpse7wmnAHgnpg/VJLfnfEWTP01sKT W5/fAVkyXN5V5d/ywTJBOyEg27vV4TV5StatKcaRqi5T7MlbCvG1pDyJ1Yl3LIs3JpNP j9KElcxjSqg0kMRn9eNUvFnImZ00+sti7eiFT2NqQYDIdigAHfFxZCcq5wdc92k/I14U PagSZ6DJYpzblFtpSmaclRUDZeNJdqzxSZkJZS9x4FTk1AjwWfaDD7zVpzXG/dsxHny8 GmwA== X-Forwarded-Encrypted: i=1; AFNElJ9yWi19drLAXMO8r//B3X4yvQSf0dGVu1T0zJX6T1KEUs18Xg+Z0p9QZof7bWbcG+iOC8hLqO0SBTH4PE8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1GCMspt5GLI20kJ7GdjkJP/JXiiojdKXAEIi6oAZnxFRqBh3m hJoTOXiBC3Hx7aChKloiawPNtLDRPD3s/S2KE9BrjR4c0v9y29LsREy9 X-Gm-Gg: AeBDieuhyFspgPYkM1NIVSuqSLgokmGkIbwt3oGBe+I0zSFXtS3dF51OkyCz2lCDLmn AwXmYr2fjWPeNCbtYvX31Hh+q5Tci0bmrGcfBWSEJlNxb42gNmH3/nta5zmrkghnNNPHbMbvlrP zmzM8HwOTIwt7Qz6MBb0mHbUfGvyNKp3htGbSDxEkpTyMUN5/HX7w3Fnycx4EKt+MT0ocgxMTQV nNajjsoJ8dNQxQdSfkRh2Mv6E0Bw7zKTx/KIkm1fm05yDv2JAPSeMTVluzuS2jf1rFvFg20U1yK Q+8KPWTPdIoQVwM1ZswK7Y4UeLI9qr/6avxfsyZ8N4xInOr+tB2AI8yt9T6lhupFOl89xeADGwi yMk6R16y0kkkOmVe5RpGDbFpqcvzjHh5e5hJh69WAB9ziMF61qVq4SZWDra4v1GdcP7mBGGuYls vMejUSeyfbTIzGP+QpvUpDqaIdVfKZpQFOulHBKjfEYMESoY3TTd3+vQ== X-Received: by 2002:a17:90b:3fd0:b0:35f:b5df:449 with SMTP id 98e67ed59e1d1-36140490758mr44947016a91.21.1777263368128; Sun, 26 Apr 2026 21:16:08 -0700 (PDT) Received: from arch.localdomain ([2405:201:8043:c04b:e09f:2c00:55ad:2561]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3614371a7c8sm30239779a91.5.2026.04.26.21.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 21:16:07 -0700 (PDT) From: Debjeet Banerjee To: gregkh@linuxfoundation.org Cc: debjeetbanerjee48@gmail.com, dtwlin@gmail.com, elder@kernel.org, greybus-dev@lists.linaro.org, johan@kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: greybus: uart: document c_cflag handling in set_termios Date: Mon, 27 Apr 2026 09:45:53 +0530 Message-ID: <20260427041553.6323-1-debjeetbanerjee48@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026042618-whole-cassette-b15e@gregkh> References: <2026042618-whole-cassette-b15e@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 26 Apr 2026 21:16:05 +0200, Greg Kroah-Hartman wrote: > Ignoring is fine, but shouldn't the bits be cleared to let userspace > know about this? I think that's why we wrote that FIXME all so long > ago. Thanks for the feedback. That makes sense. I had considered clearing unsupported bits earlier, but held off to avoid modifying termios and left them ignored instead. Your point about userspace visibility makes sense. I'll send a v2 that clears unsupported c_cflag bits accordingly. Regards, Debjeet