From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06F671F30BB for ; Mon, 27 Apr 2026 05:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777267032; cv=none; b=J6dnSfnzOcxite9D1N/bG3lzRNja8a3CELJP9fk25XohPrX1AtHEEvzjGNl0R2ujyVB054J9PGSy3PBmkojvpN2tvN9IJYEuvqo0ivrFsD15nJ+XWjiq3TUP6N9mq254Q3H+573gKmwmK+SLMiU0kggMtSAO3/iOAgXtfRtBF5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777267032; c=relaxed/simple; bh=Iw8U2fQwcXEz9bTcg6ahs4tw3DC91bXwCajKgCZqaOU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R1gexfOq15/1mZKPZLjGr2EIdnXy2839ZGxb9Y84oPf4YNlssbIe/gO0PgYQHEb2gIl+iGO4WpEtNatBcAv94rYb2CQX4u/e7ZgiKwdjpsIF+9hkShctvDTnOnrwRjJVDo5ctZYeSJ0DTUMyF6q8kS4YncjxQXxKoCvzO0+GbnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bhyNLH9/; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bhyNLH9/" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c7961d7bc09so3741152a12.1 for ; Sun, 26 Apr 2026 22:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777267030; x=1777871830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KzqGtYxjboO/NsOIX0ogC3IrKsPmx+IrVHY8Yjl6i7I=; b=bhyNLH9/KKhpsmRcbU/B6BaUdLwGzij8UWlMQNbP6ysNfVCoUAJ96fN/7vixkLPXm7 tiNuEy4fusDq2CDjz4crVzWnUBwALgxX5NSBjtyUSmoyiOxYWIDgCy2FJBMXFppotgxZ mpqq0a7Nmx8sSX1Th6bhi0lgQWZfQ5wGdBhM0PRLPe9fyO/loIe7RpZm8Rqcjk2vwX/R 3JzsLKXZ2tynEn/ZpanjKPSduUwAt5xPKKFIOLStWig11XOkNRUeY/C9EfSPn2klhS0+ ac58yza6fzfQh/W34vRMF401hqeVrvgPB82IY3hteeuhbdWqAA4/dGQrT+UFDT3IufdR MnnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777267030; x=1777871830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KzqGtYxjboO/NsOIX0ogC3IrKsPmx+IrVHY8Yjl6i7I=; b=c90x/bw7YaO8eQXGNVUa2UNtv/ueSopL2OhxjYb1dji4zv7E6POlgok61mIa69d3Wb VQll/LORBkb0/+jVKXoSQJAdrL6hw0I14GYmke2N/82JrrIAFrPCg07JgT23Le20KWSL qbozaNlHBQhwSI40AmOGkQyhUtORaQLEXNte8K3XEWJwKXg05Zi8AF72A8oSBidHRGhP xC7m1MK1SK5yMiR+ondHedfYDVXxFW9OokyfdjMYn2pHnXO5jonxXzgfnXP9D1xX9KqS Qw/eXWCwUqwDs0gO/AWoHCk1WrhMsgflq5lJxRH3JNmcMW//0TaTIlWl7XOfoVisGVj0 AYiA== X-Forwarded-Encrypted: i=1; AFNElJ/Ri5fiR+NSzEpVLpWd4NSj7KHgT3DhF1In1Ic2WfwkrXZj93cBEN8PMcOu81Vr6KXXbrRCeNDBKd6rzvs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywof7Qm9OHzaxncbN7wFXEYEEbXJ3JLCbJ74VbnAh9GiF1RCuMy ixKtCyvdJrDc1vXksZIxigRsKHc29vYg9sOCCvOJ41JIl4cL/T37tunmbLgo9g== X-Gm-Gg: AeBDiev3DZFkmLC5vbuajQXubr7TX9I0HMTzfRYF5HvqpwFduDuGqr87ih1XFUwGyt0 KIxHkvDpzQNMf6pkg5ApE5WzOBJm3D8f2K7qr+iTuwOq97qMOl/Rbga5qFaKhnogRjki1ECSxAT Wd+vVo7fIOOcHkDBgE+ydNVJzoGDfrI27wFLFRpnk9wApl7lB1tYHIQ/bMI485Le8/QmaR4rH42 JC8JTRRxnOj7/1fKwdkIL1WznSNaL7swm5ii4m1x0AmokSU3rwb49ujtFC7rsjRYmoPNfGRQZ34 CX9Sgbh9jIJUTauKbDXdChTV6LwSICAFrqr6CstZKyVk/9ISwG/gpSoRNUJxmZ3CNGrJ+JH/JO6 Yv8DVOEOB4nFWDOxdF2A87OIaiGAUTwT83CKSA+KzhEtiPuPVzO3JQUPa3Af+6UJNEucfMC78p4 8ho6WAB7B7UoejC30BsHQHtc0aMI1zYYcqvnBhq6hKDqptY1/1SCK7+goNmZAKCGSCMo/UpjhW+ rniZC7qau3yj7/mZr6ltHAwxA== X-Received: by 2002:a05:6a21:6d9c:b0:3a3:17f8:bedd with SMTP id adf61e73a8af0-3a317f8cbb2mr21380763637.17.1777267030274; Sun, 26 Apr 2026 22:17:10 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c797702fbfcsm23481238a12.22.2026.04.26.22.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 22:17:09 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Stanislaw Gruszka , linux-kernel@vger.kernel.org (open list) Subject: [PATCH wireless-next] wifi: rt2x00: check for of_get_mac_address error Date: Sun, 26 Apr 2026 22:16:52 -0700 Message-ID: <20260427051652.954059-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit is_valid_ether_addr is already a check of of_get_mac_address, in which case it returns an error if false. Just set a random MAC on all errors except for EPROBE_DEFER. Signed-off-by: Rosen Penev --- drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c index 2d778ea5f1b5..51b836343f07 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c @@ -991,7 +991,7 @@ int rt2x00lib_set_mac_address(struct rt2x00_dev *rt2x00dev, u8 *eeprom_mac_addr) if (ret == -EPROBE_DEFER) return ret; - if (!is_valid_ether_addr(eeprom_mac_addr)) { + if (ret) { eth_random_addr(eeprom_mac_addr); rt2x00_eeprom_dbg(rt2x00dev, "MAC: %pM\n", eeprom_mac_addr); } -- 2.54.0