From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05992368276 for ; Mon, 27 Apr 2026 05:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777268877; cv=none; b=D7BGlN4/O2QsVnHGDUAKi5j2YBnpU+QAVlznKao2f+RQl0yHAQYaS6UoNOO7IMU4/7l7nn8f8+rkKpfvBhet1MzAhDXyr+MqEfCyTIEZOhXhmX7cNZer6T2Y9DOkM4jB5hrL70ceoCvtKfiN1+qTICGAJuzO0ZuVx7btsMs74dQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777268877; c=relaxed/simple; bh=ZNA+Z7uM0T4aC/rYpgG/WXQtXAqoG73zTJrV8YaYuyw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YmGJNRoLyuY0Nwpnh3ijkhS6IaSka2Fy35TADS74R/hLE+HcpCVwgXWQsqJobNAtElQU2TrCRzUEcOMe4ETWunrBWt/wlcpxeou1gEIqf/KjXRlENmMax9+wtqvd/VGU+9dNOH7T2fzkeBNYm8eYtS1wPN8sllAKsFlx973W3mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UDJ2qc9E; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UDJ2qc9E" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-1279eced0b9so14301559c88.0 for ; Sun, 26 Apr 2026 22:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777268875; x=1777873675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XooreDzs+cvNPadpU61rCgaOMb1b4M2JvjEhVgabVB0=; b=UDJ2qc9Er563MLooHzW9ydRExTpEImY7hceiFUwRwSHyKEuS/0401R7rMB2J0yfeWB 6jXsyg2bKrQ4euJvwkG1PnfREAecCK2pyQfvshdLqherDvP+jRIP4MCbf1TSKo+MmJ4T RUN5ice1ReqDmk3BjHT5y0OPqg8mP64Xdo3rp0gKKmTul2X/+6FYTPiJOJBls8N3PJkJ L5pcFhqPW1715hpyY+gNhY9xAtEwUqX6BNm1o505KjXhkyCXZ0aXX8R7bLd7PH6qqzgS eiLV9BXydLgVO8/U/kttDBfjgZYzSSeLJZc9nvBYNURLVo3RZJSnauKUatII9pcCFXfP fXMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777268875; x=1777873675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XooreDzs+cvNPadpU61rCgaOMb1b4M2JvjEhVgabVB0=; b=cp7PkZsJ9pkbJTxP+oUjynEPtq1mgj9VrPLLayo/zdVr0pMTiLSMjQzM9fkGkNvRAp 0iYMOWuicj+mSA9xKeEfj9RNb4IERfqutu/86nUmb45vOrgQaIHSUWDaz7hozVHtjBcB 8AO2SKWOzA2AOj4F0c+4QIRh9sVAdXBdFkgfgWc+C8j/aDhj0WwPKeGJKh0zna4hbjKn Is4XRuNpflpODjGpJRepLqqedqEznH3ETw53kai2N870ZtmkEFvEk/UIs6zd0Q7ujfrm PSzItedutZlCeZxkvD+UIRpusZFmqhfZJcDT18pzN4XB/MTAKPts1N4TmHLLaS/26Q9W ThMQ== X-Forwarded-Encrypted: i=1; AFNElJ9PP16TarGqajtCndsLupupEWjhfL9ysuEx2uCi681/ksrh93HlOq4pA7RmyfJf0TRc5cS8izByk8i+Mb8=@vger.kernel.org X-Gm-Message-State: AOJu0YxPSjPwBqbJtzaTkPdLympyO4O4fDZLskrjjOYwYXsCGJsZBiBc e9rOfDD/Me4IjvNcglG1o2Ek1OAtexOR6BCGeNcahZNB6DxO7alodZ4r X-Gm-Gg: AeBDiet6ZArwAc3+eeQFH2y3qLhiPH1P1O4pd/B8LFfzXCg9hwHHqW0EU3XIKLKAmga M2fxlCYceRY4Je4HF86JmwU2J2gnuEA5ZfuGwKebNuWw8aTG76JJc5jqJYyMulpdPJFcH3HUW8C MvhEkLEmzDtZZ6iORbb4yRQ+5u64myOSo768MEYMW5kvHxZF1YGhakL36wCM9/tJxcC3EvcClVe lx8Ngt8I94N3iSseTTKk+sVEg3L7CDDtaqLDgy/oQXfsjj49fdWWNhEkaXuy3S2nqkdfM8s9p7s HQ3iMxNlOsnwOeYSXu/econCCpXXWYRl+lv1/RKq9rKeSmovki4R/VbTRDJcdnfPYH6a+d9I4Om MreJNJqjXAQFOysPUtSQcOe4Ai13j7y+P2dea0kcTVdWVEgSRBDQaby/XHpQntoDgz1QLLnybop h9D8+MoZtZs92s1xsdsarbhyemltIT+DxWD1KdEzIeVEhZ09ZYMfN9eOPDXaQPKzSjc1ywUHx+s YnF X-Received: by 2002:a05:693c:2b15:b0:2c1:3f85:747 with SMTP id 5a478bee46e88-2e47a1027d4mr24568461eec.21.1777268874938; Sun, 26 Apr 2026 22:47:54 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53d2cfd3esm42350209eec.21.2026.04.26.22.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 22:47:54 -0700 (PDT) From: Hungyu Lin To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v3 2/2] staging: sm750fb: propagate error codes from de_wait() Date: Mon, 27 Apr 2026 05:46:57 +0000 Message-Id: <20260427054657.758-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260427054657.758-1-dennylin0707@gmail.com> References: <20260427054657.758-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sm750 acceleration functions currently return -1 when de_wait() fails, discarding the original error code. Since de_wait() now returns proper errno values, propagate the error code instead of returning -1. Signed-off-by: Hungyu Lin --- drivers/staging/sm750fb/sm750_accel.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 0f94d859e91c..d8e91f7a7778 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -90,14 +90,16 @@ int sm750_hw_fillrect(struct lynx_accel *accel, u32 color, u32 rop) { u32 de_ctrl; + int ret; - if (accel->de_wait() != 0) { + ret = accel->de_wait(); + if (ret) { /* * int time wait and always busy,seems hardware * got something error */ pr_debug("De engine always busy\n"); - return -1; + return ret; } write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ @@ -154,6 +156,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int rop2) { unsigned int direction, de_ctrl; + int ret; direction = LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 = Left to Right, (-1) = Right to Left */ @@ -263,8 +266,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, DE_WINDOW_WIDTH_DST_MASK) | (source_pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ - if (accel->de_wait() != 0) - return -1; + ret = accel->de_wait(); + if (ret) + return ret; write_dpr(accel, DE_SOURCE, ((sx << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MASK) | @@ -326,14 +330,16 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, unsigned int de_ctrl = 0; unsigned char remain[4]; int i, j; + int ret; start_bit &= 7; /* Just make sure the start bit is within legal range */ bytes_per_scan = (width + start_bit + 7) / 8; words_per_scan = bytes_per_scan & ~3; bytes_remain = bytes_per_scan & 3; - if (accel->de_wait() != 0) - return -1; + ret = accel->de_wait(); + if (ret) + return ret; /* * 2D Source Base. -- 2.34.1