From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A191B35CB7F for ; Mon, 27 Apr 2026 06:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777272327; cv=none; b=X+EvgPT/bhTYFggYW9F+/NSXuN34XWEVJLDoWWbqmWQRNKfIKmBuMtjSuRsuvlQqJHJIK9YfSpRaSPu1/5gCW3aoeKaAE7j6nBZ0rpyYgmQxOfX1zvSG5z6O9fGwwG4UFrYmyjrv/LLq5CSIE9e9zYLThxN5eWGYECjYwXl6PTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777272327; c=relaxed/simple; bh=JY69ulEG+UcSyrX8O6aX4SZWbnHvT64kZ2oY47M31kI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CpP4kjqyqf7WQuJBLNOivWdcfGW6S2K27S53I/NhoQaARg5BkHehUAUCtcjZiJACnNGO5bQ45BhhdOQHHy9rbRPrfUTridqs9+WYYEHe/Jm1uA64rAN0p4MUvImUI7JqqoQmGFmD2qXGVVlAvLiQXskaZKTFHAvKN4Wq4NBWXZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GtQsv86F; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GtQsv86F" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2b2429f98d0so56821375ad.2 for ; Sun, 26 Apr 2026 23:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777272326; x=1777877126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6692yq/cQ0USHN6DFzItmBiouuwHI1/l/PPRlXLNKmM=; b=GtQsv86Fkr7ph9dYU7y6P4ZOjGi7OEYGxQL1PQVusKM6s9ugrw27aIlXQMlJCXRA0J o1AyH0cWGP/jWIhi0Yc8U753fSLwmi+zDcf1p5nhIreLy7F1tfW56HZSSujU6jZ9mYz9 C1yDPQnz/jkjjMC2nzso1gFAVq+8sJjXtztYuzeoFAW56vXANWn2u1XjdJ4f4XggX+1q R9G4lwPdjOa2nMUVJSK216aBvLKbvLnifCLxeX5CZw57lozWx7Jw9MCpcSWCTg9Oiqqp NID0NHzmwE7K6lhEHRZa8CegjlIXEhjph79bLNkHKER8rLEZyJMMNHtV8sY3anap+/RN 0RDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777272326; x=1777877126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6692yq/cQ0USHN6DFzItmBiouuwHI1/l/PPRlXLNKmM=; b=s9LDqwXJoqelCVeQUCjzp30F7NTBY5TRxGhESF51JJtlH9QabcuKGqhZHdBMzzluIH 9Oiuz2JFpcTL+MsloEl3iV6kJFwtH0iXtp3OnRulmlpHlQHmt3RgQeVnvAhWeIhXHflW b580EG0RIaNF1G/e3r5dsEWmnYPrsvvjaNSmp6J8yn1RWQmfBxl/Jy/8ibHY9M8Tuy9B d+1RP3YRi8eHOePFzm2zMR14nvipz98QFyBlCJaoJeHgBKvs5QeVFMhdcvuD9eNMNl9X +Ikw8NEQGJl9AuEEg+XB/5sEWzmqpu8r9XVQzYhAxeWlXkpHT1yAbZtwP4BFhioUhtql UjHQ== X-Forwarded-Encrypted: i=1; AFNElJ95zzwo9eUtdlwGEhyaL5J+UxBj3RisCGNQ3H68OcnsAEvVGjsLUuOQxS2D253lsmVcOHKANwL6kGV3ZaM=@vger.kernel.org X-Gm-Message-State: AOJu0YwMiS8h5vvVqxR6r8hsNkTrgYbzCXn/8xQPd0cuJkwoYVz1G5qX RaaiP8BdUjsp8EgX9cev4i2/VBLlkRpORft4SJoxraYJr0/XA3Cm+5hT X-Gm-Gg: AeBDiesBBVcKOoPzk8oocaWs9lTNUrNhEoxFGiekjynzgkpDcYuBcOtTH4QuC1eE762 ZbvoNDveuTJc6m29HuyrW9JMFfFSMIWJ0OHCwWAA53nPCBhBSwfm6ytEU9DE8ykOLVt6xdKubZH TU9uOFIEpDAnYmPC+flI+NxUCOnw8t0pzHVZsan55fHUAN8s2Ui/jWtxKRuDjt1Ij5xrjNNecYz 1FpksYDYEe0Rk+1/ECqv/PJVdo2ofH1GWgrZh1iUNe0a+bWPjYxwvYE0pkJTlCa+UAiav62He85 NWsubHq/mk1vrEfC9HyodI3wAzsUcXwwpMI5YEQ+hjuV+ATButOvCub6c6f0+ZUNmx7Ax4l8TbA UvFf9WkSeuQKbXDXNRWpp1aVXD9dx3hdUljwd5V+CaAWUjuMSBoom85QIiWooTRW176gWeOA61j pmJPGlPxOUfYkjF0GDp3y2dhUfFv0lBkTkh3xTU8oJw8Fq6dYgy1YH/zSI X-Received: by 2002:a17:903:384c:b0:2b0:7e4d:f390 with SMTP id d9443c01a7336-2b5f9fb1b9cmr406146105ad.41.1777272325956; Sun, 26 Apr 2026 23:45:25 -0700 (PDT) Received: from tech-Alienware-m15-R6.. ([122.171.21.105]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa14487sm311671955ad.18.2026.04.26.23.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:45:25 -0700 (PDT) From: Sunny Patel To: ziy@nvidia.com Cc: akpm@linux-foundation.org, apopple@nvidia.com, byungchul@sk.com, david@kernel.org, gourry@gourry.net, joshua.hahnjy@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, matthew.brost@intel.com, nueralspacetech@gmail.com, rakie.kim@sk.com, ying.huang@linux.alibaba.com Subject: Re: [PATCH] mm/migrate_device: fix pgtable leak in migrate_vma_insert_huge_pmd_page Date: Mon, 27 Apr 2026 12:15:17 +0530 Message-ID: <20260427064517.19784-1-nueralspacetech@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <5D99B763-2544-4130-9117-9E6BEFE6A2CB@nvidia.com> References: <5D99B763-2544-4130-9117-9E6BEFE6A2CB@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sat, 25 Apr 2026 10:21:01 -0400, Zi Yan wrote: > I think the "goto abort" above pmd_lock() need to do pte_free(): > > if (folio_is_device_private(folio)) { > ... > } else { > if (folio_is_zone_device(folio) && > !folio_is_device_coherent(folio)) { > goto abort; <-- this one > } > ... > } > > The lock is not taken yet, so you might need to add a pte_free() > before goto abort. You are right. The pgtable is allocated before this check and the lock has not been taken yet at this point, so goto unlock_abort would be incorrect here. A pte_free() call is needed before this goto abort. Sent v2 with the changes. https://lore.kernel.org/linux-mm/20260427063729.17294-1-nueralspacetech@gmail.com/ Thanks for catching this. Regards, Sunny Patel