Re: [PATCH v11 1/4] ASoC: SDCA: Add PDE verification reusable helper

Charles Keepax
2026-04-28T12:06:04Z

On Tue, Apr 28, 2026 at 09:45:51AM +0900, Mark Brown wrote:
> On Mon, Apr 27, 2026 at 01:53:58PM +0530, Niranjan H Y wrote:
>
> > + dev_err(dev, "PDE power transition failed: expected 0x%x, got 0x%x\n", to_ps, val);
>
> The old code included entity->label, I guess for disambiguation?

Hmm... yeah I think perhaps we should push the error message up
to the caller here as it will have better context to print the
message.

>
> > + return -ETIMEDOUT;
> > +}
> > +EXPORT_SYMBOL(sdca_asoc_pde_poll_actual_ps);
>
> All the other SDCA stuff seems to use EXPORT_SYMBOL_NS() or
> EXPORT_SYMBOL_NS_GPL()?

Oh thanks yeah that is a good spot, we should fix that up.

Thanks,
Charles