From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C74F37AA9D for ; Mon, 27 Apr 2026 08:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777280115; cv=none; b=gHlfAp3HpSKI9YN+ajeDk4lM/ahwGn5rXKntcMFLeKWc2xBnThrM6BTyW8fQJ5ejmTsDsvaTAvnGDYmq7bkPvOq3VsItGejj1irNn1yh8Bm/ABoIIiEryGtRsMj0li1Ksyyjqxkme/hv0kJDnYMK1xIiYjfUHiTrJ8OMiS9/V5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777280115; c=relaxed/simple; bh=ex/wBQ/ihuU0frMIpPPFc+k2MJG4Ygkspi/FZ5Lqphk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=a2cDKJS0fyrEx7uufY4QbELk0cX9eQzceYNfvgQCeqahToz62VTbzL2WYjm+A2nCZLmBJX7g0l/Xn3tJlWe8UOHaS5Wo6rW7RRZzX6bTP5Qq3C6Mfz7pMFY5PJqum3NHbAORgcrNWEdGj6Owf9BMZlP95hEYIZzkjZBas1UPAOs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DdVr9G3A; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DdVr9G3A" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4891c00e7aeso73390795e9.2 for ; Mon, 27 Apr 2026 01:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777280111; x=1777884911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=g+pkBk61K0bONezvT3hKFR4CsnavUHfQ0OwvNOKj+rk=; b=DdVr9G3AymhXnxKOZlcJH0uW/U9t8wcJcB2Q9gBKLj9agQUq9fJNk9G8r2l2KrIzj/ 2s0N4+qW/R1D6m38Bk4ED0z1xV400Cb7/HHRHED21Ax8zFNjjC0y1CRZ853EowaFIUXy BFR3gQKDrqwUfAXFZRSEcO+Fvx/bS321ZR0AXSUk0DuQrLjJgS24kxOMaalXrDhlZva4 rXvKNkRBgH7MkV9uAU624mgk8l1mr+TUsrSwRKQpk2h/RtL5t8q/pOT7DL3TcFRNypwE MQkCbvWlLByfLRkcoS2KGdlFTqDUGjf7iDhFv9v1Pm2REVToX6EO8Z1oZ9yg5i+4AA6E xFMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777280111; x=1777884911; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g+pkBk61K0bONezvT3hKFR4CsnavUHfQ0OwvNOKj+rk=; b=otMBc77E0MdenpZK30kfV5Kx7hAF92LVLRj6aTqClC3xkrjHbQu6l6fx6CJl2Qu6c2 3MwVYeDl4rAbQEznnTbHkwZm7EzZ73Rmu1qg0Y+NpFquhmYE8Cdnw/rXZcEmXcu87250 Ci7DloggrLK8CgPfr6JvbUGMRlFy0Z+2oJInvWH0vEv/545vAOkBVEY1urFo1FWqbClo Bv6hxxh0ivgzWDnDMGhAyiGZYscetRq4UKoiFYYkFa2vHqFF0cUJj6fi2d9mk/aC+nLR JZ60KsHtAXvcRjW6cEtzzf63Ic8kzpXS3X5s20Pttr8ItyIsuqQaRm4PjSujIDwmai3F m/pQ== X-Forwarded-Encrypted: i=1; AFNElJ+nDnfqvjascTq/7B6fzC56STuAcJR11dXcRam2U920auWc4feNRM/79Gz94Fv24Xl2xpLbrhLyeY2DzQI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4jdkoqjyjsaX8dlZj9J9OyB2p6YC9ERejSTzuOacYW5KvVcIh WWM0ekQF0TOKpePovRxdzYCwtr/i3CDUBXSXafCZsnrW+HDYrqBOCS5U X-Gm-Gg: AeBDievitcViUv/eRnqgVy+99ADqJ4NlWZNixTa1DVYtnb3j4LCaeL+WlzCjEHbd6YU q74QpXHY8/zmDh0R8I+27C+WeN3IjzWosBbqfEV9NNy/WlgZT+LpmFcG2sOOuyoVz7w0z0ImHUd Tdq+aPJn+LMSLqBAIh+g31dBaDzp01yB+84HeqCvOpW8OruzKKWa6gi1GBrORx1nXop+iSn+tKK +n218OEKQ9Su1eJSkV0ZyzlSwtZXyBsbZLn9obFbehd+hg0rjCcu3psPa0piSAOmcWnabDZJpdJ chlcyQY5qk/TvXAEgi9gef7HJN7XAPvmIXC9fFRVMBlGyAtLEwYmYE8FLte3eoG1XzCZzEXxH0v kofsvc4jpshsPNgjUwozo4kCIwCzTIYPHQALRCNNGaqfM02ChCPBK6cPDiX68VNmsa5aOO8k36l gp7EcPVcn3VqsKYIFHRwpljrE/GEnjJQ/e2zgL1V/bTvLQ6QRyMCMODVVbAws= X-Received: by 2002:a05:600c:4a15:b0:489:1aed:1658 with SMTP id 5b1f17b1804b1-4891aed16d8mr269026355e9.23.1777280111056; Mon, 27 Apr 2026 01:55:11 -0700 (PDT) Received: from localhost.localdomain ([196.235.152.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d5b1sm82248879f8f.30.2026.04.27.01.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 01:55:10 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Salah Triki Subject: [PATCH] iio: adc: mt6359: fix unchecked return value in mt6358_read_imp Date: Mon, 27 Apr 2026 09:54:57 +0100 Message-ID: <20260427085458.38546-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In mt6358_read_imp(), the return value of regmap_read() is currently ignored. This is problematic because if the bus read fails the variable val_v remains uninitialized. The function subsequently assigns this uninitialized stack value to *vbat, leading to incorrect measurement results being reported to the IIO subsystem without any error indication. Update the function to check the return value of regmap_read(). Ensure that mt6358_stop_imp_conv() is still called to clean up the hardware state before returning the error code. Signed-off-by: Salah Triki --- drivers/iio/adc/mt6359-auxadc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/mt6359-auxadc.c b/drivers/iio/adc/mt6359-auxadc.c index 6b9ed9b1fde2..f927bff4a26a 100644 --- a/drivers/iio/adc/mt6359-auxadc.c +++ b/drivers/iio/adc/mt6359-auxadc.c @@ -497,10 +497,13 @@ static int mt6358_read_imp(struct mt6359_auxadc *adc_dev, return ret; /* Read the params before stopping */ - regmap_read(regmap, reg_adc0 + (cinfo->imp_adc_num << 1), &val_v); + ret = regmap_read(regmap, reg_adc0 + (cinfo->imp_adc_num << 1), &val_v); mt6358_stop_imp_conv(adc_dev); + if (ret) + return ret; + if (vbat) *vbat = val_v; if (ibat) -- 2.43.0