From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5024D364949; Mon, 27 Apr 2026 07:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777274632; cv=none; b=Mf2KWPUFGrNvtD4vc+3dkf6XoeMilK2iKo5nX+Bh5geV8V/ob2+cDQZ6C0TJrCOBnNEVw9qhyL6SJT0/MotB9Llra2Yj1fiVpCfwxhaC9D6XQBzthVKzFRKvWMYJebYimg+5SrmowpcQa4IKXg5I3AoY/+9yHrns0TUS2CY6yZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777274632; c=relaxed/simple; bh=Qi6qI6BiZnWfSvCRtvIcDQP7yPAT/kFoKGo4NEHYVeQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=klyzUyboZR9XWTvffmERPcb83Im+L6tOTp5bG7TFDdNA9ArP+qcxqi/PKbST/NuteJWrBR2ETk9ZhM8HMTyv5VAXGwjJb3TZjv+4JWZxT3OlNUALwnBog/pGec7v9y0GM0PB4aSwNso4Joe5fDaIUuPQALlAmjMfXXtsQg9BkUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=KhE9M0j9; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="KhE9M0j9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1777274623; bh=Qi6qI6BiZnWfSvCRtvIcDQP7yPAT/kFoKGo4NEHYVeQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KhE9M0j9OkpMRPiGRnyijbj4Rgt/rxOvWC4Vwr9fkhC3qL23pZb0sFnZRDewRMm2o 94AnzFzOJC75xjH+Xl9U6mJxGl7TIKBgt/7a79Fd76s7PaD/FrnyLSqsOitUSz48tj 5MZIO9LD/+exadNWRC4EUcg3zV43uKiCPPmFISW6OL9lwoMVNvlNWf+ey0F6RBdO1a aoDGie0N7MtAnFMUJahTekruCqap5fs9i4IWWsGChugQu3Hel5advBwtlSIanTDBaa kZJ0HuDVxTvoqa8Tum46ysdG4NdPUXB23EmPm5lh+zKfLnmgnTu099s5PV4O2y76Pg ofigN1tS0tTpw== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6FA0317E1313; Mon, 27 Apr 2026 09:23:42 +0200 (CEST) Date: Mon, 27 Apr 2026 09:23:38 +0200 From: Boris Brezillon To: Deborah Brouwer Cc: Daniel Almeida , Alice Ryhl , Danilo Krummrich , David Airlie , Simona Vetter , Benno Lossin , Gary Guo , Miguel Ojeda , Boqun Feng , =?UTF-8?B?QmrDtnJu?= Roy Baron , Andreas Hindborg , Trevor Gross , FUJITA Tomonori , Frederic Weisbecker , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, beata.michalska@arm.com, lyude@redhat.com, acourbot@nvidia.com, work@onurozkan.dev, alvin.sun@linux.dev Subject: Re: [PATCH v4 02/20] drm/tyr: select required dependencies in Kconfig Message-ID: <20260427092338.4e083a55@fedora> In-Reply-To: <20260424-b4-fw-boot-v4-v4-2-a5d91050789d@collabora.com> References: <20260424-b4-fw-boot-v4-v4-0-a5d91050789d@collabora.com> <20260424-b4-fw-boot-v4-v4-2-a5d91050789d@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Apr 2026 16:38:56 -0700 Deborah Brouwer wrote: > From: Boris Brezillon > > Tyr depends on DRM_GPUVM, RUST_DRM_GEM_SHMEM_HELPER, MMU, IOMMU_SUPPORT, > and IOMMU_IO_PGTABLE_LPAE. Select or depend on these symbols in Kconfig so > the required infrastructure is enabled when Tyr is built. > > Introduce DRM_TYR_STATIC_DEPS to keep the built-in DRM dependencies > selected even when Tyr is built as a module. > > Signed-off-by: Boris Brezillon > Signed-off-by: Deborah Brouwer > --- > drivers/gpu/drm/tyr/Kconfig | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tyr/Kconfig b/drivers/gpu/drm/tyr/Kconfig > index e933e6478027..443ce988b570 100644 > --- a/drivers/gpu/drm/tyr/Kconfig > +++ b/drivers/gpu/drm/tyr/Kconfig > @@ -1,5 +1,12 @@ > # SPDX-License-Identifier: GPL-2.0 or MIT > > +config DRM_TYR_STATIC_DEPS > + bool > + select DRM_GPUVM IIRC, Danilo said we should have some boolean RUST_DRM_GPUVM option selecting DRM_GPUVM for us, just like RUST_DRM_GEM_SHMEM_HELPER does. > + help > + Ensure required DRM infrastructure is built-in when enabling Tyr > + even if Tyr is =m > + > config DRM_TYR > tristate "Tyr (Rust DRM support for ARM Mali CSF-based GPUs)" > depends on DRM=y > @@ -7,6 +14,11 @@ config DRM_TYR > depends on ARM || ARM64 || COMPILE_TEST > depends on !GENERIC_ATOMIC64 # for IOMMU_IO_PGTABLE_LPAE > depends on COMMON_CLK > + depends on MMU > + select DRM_TYR_STATIC_DEPS > + select IOMMU_IO_PGTABLE_LPAE > + select RUST_DRM_GEM_SHMEM_HELPER > + depends on IOMMU_SUPPORT > default n > help > Rust DRM driver for ARM Mali CSF-based GPUs. > @@ -16,5 +28,5 @@ config DRM_TYR > Note that the Mali-G68 and Mali-G78, while Valhall architecture, will > be supported with the panfrost driver as they are not CSF GPUs. > > - if M is selected, the module will be called tyr. This driver is work > + If M is selected, the module will be called tyr. This driver is work > in progress and may not be functional. >