From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09A6E2F691D for ; Mon, 27 Apr 2026 14:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777298666; cv=none; b=H0Tn+6jPGlLGv7bXsFN3l+WFs4gBEiM2EF12/C65YznNRG9fpcgBrxz3CS2RqnxFXnmu730r64nx815TXMK4Kr23DjdpqkmoUROJLlNagLt/i+oWUMjoP6JbyyLNkA6X63WA4Jo43Anac3nnuDlLSz7AbJfEohQ9jodZvxms4L4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777298666; c=relaxed/simple; bh=jEMMmfGSdoox1VvMk7/uQfRnvnb9SxPsH9ArA5SHRF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ViAvb5dFL68rPB8kueXq8JNTkXJIZt2pRCLVt6BtubnwYiqnfe0nFLp0erS3Rx9JEB4H8Nh3XxWAvZcVbQ4qAuh5RYAa0hmWEakDkQ/34enqKwJn6Wq3A/hDCQDRDFQ1AEDpflqt592uSCoPWVJT1Qw8H0w0NTGDEl0dAFnmRsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=e8wrTy8Q; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="e8wrTy8Q" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2d8ffdc31d0so723637eec.0 for ; Mon, 27 Apr 2026 07:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1777298664; x=1777903464; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xsNytmMTjP7HFXqAqLQl9kJMS/VlfS6FjoNqX+XGHx8=; b=e8wrTy8QIQAXe9Jxe03dZ/6eapqM8Zsit32y/v8lRwpkgM4/ApKyBSIZZQQrgIcDbX gpDS0qG96/oZAk5xxHpRrHbGj4bIrlB2y7AV/n/SPzX0qZLKdl4tCa3BwWO6G4rnBVeJ vTTSm9sRUrK+DgVKmZoj/G/CnhuS0KvQxLs0wgTqdhcIf//l8BfGxbSeH0ayt7+2xIqY UdrszbSkr1ZEDUCDCB8NUQEXzQz/K0zMEH6YxHgZuw3HdGil2uZQ0ggbEmvQ1+mtEszC Lf3Z46wmGkOKydVNZfPnmVIeZ/XBIAJJ+m6oa/WLLS7lMO8mxSzvHfnkwzGJsh4KY5Wh g7sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777298664; x=1777903464; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xsNytmMTjP7HFXqAqLQl9kJMS/VlfS6FjoNqX+XGHx8=; b=fRPFd4IT/HtYMIv0n3TtVPGK00qAh1A7Ld2ZAfdPMbKMyfa6Th4pV1KZ+xOnk14RQb 2MCPZNBo/s1c9cHwxwzGL+Xwpr19eXRtXand9mRwouPG1RjxnaD4CMHMweb8T2WCfa72 W3bR0D5PgvR/vWVYa6nsq/LoJu0ElR8UBBOjvTslBRyLPgJ7oww9+JEYFbHWoKDFFKL/ Qb4lcWIK7uBiEctozo9j3tLwGjMmpqbwbuKZkC+Gx0miQ6cMtzAvIepGLx6g/fNrvWc1 JHPexnPec7AcubHLCQdP1LPYhJgmUN0pfQBjYWfPf5ffaUF8eOvNxRZgjzwONPjj6hIF Q+kA== X-Forwarded-Encrypted: i=1; AFNElJ/RoFhYMO9DHSVrvIEjfZ+H9KvghFcFPyXZx3STzObP+POolpysvi1GMGU91m0FKr7ehbQ8bj+VV4nhyeY=@vger.kernel.org X-Gm-Message-State: AOJu0YxRusiiyKS/n0iDTmUzEpnKyWcTQxQyzuesHQWVDE/Uon3P+gg6 gSRzQJ9DhSQRW6T9NwMlBkb7GNeO4+bOwR4YmDUf3FDlDefhPloseuvEwyflc7leAzw+H2seWLY atRhhxno= X-Gm-Gg: AeBDiesvYettJpaAxH1ZNFgzhCNPKIr8ATQKErISTPjm5Q84EKsPVYZI71hluTAZ4wb C039rSNUe+bisKHNXb/hOG7DqgkQydtYtgCixCjXJO+yrGohc4JUdjeFKMFMxOysjKWBH1aYlT8 H8VKms9Ww3M751f4dCU7NLg5A9pC6QBw/NWBltDUkk/fYjuYWGuXlpzc/zXpBjZZCq3Xt/oGVzB iNeNsvvXYCRei8WTjsH06COxBlUh7DAyVI9KD8ibkL/TuIpz4YkI4lPlq6P/IvC96plIqWNcwo6 NAMhYnatN9iiFlrJhY7d8kI55Una+YkR0WdjSLtR8VLm9vpqGGaY8o/PJQCMujJ8DqpE7k7U//h xB5vZYlq4AARbcsVMmBBp3atuKuFf9p6nMF1w7UJF0tiUJpCFWsOYBNtp7lo3VSeH95D7bMkHZt t3vKwHoV1TH8Kjgdqrrrr2eZnUoHSO+DHA7zbpSo9KgFadjXWGnVvK2Rcs+Wv6bGHKwEPITLdmt 9gCE/HF2156LJpw X-Received: by 2002:a05:6820:2d04:b0:694:a02f:75ad with SMTP id 006d021491bc7-694a02f7af1mr14826616eaf.59.1777298592445; Mon, 27 Apr 2026 07:03:12 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50fb92db861sm165173551cf.5.2026.04.27.07.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 07:03:11 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wHMYI-00000003Xlc-0XFo; Mon, 27 Apr 2026 11:03:10 -0300 Date: Mon, 27 Apr 2026 11:03:10 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V (Arm)" Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Alexey Kardashevskiy , Bjorn Helgaas , Dan Williams , Joerg Roedel , Jonathan Cameron , Kevin Tian , Nicolin Chen , Samuel Ortiz , Steven Price , Suzuki K Poulose , Will Deacon , Xu Yilun , Shameer Kolothum Subject: Re: [PATCH v4 2/4] iommufd/viommu: Associate a kvm pointer to iommufd_viommu Message-ID: <20260427140310.GD740385@ziepe.ca> References: <20260427061005.901854-1-aneesh.kumar@kernel.org> <20260427061005.901854-3-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427061005.901854-3-aneesh.kumar@kernel.org> On Mon, Apr 27, 2026 at 11:40:03AM +0530, Aneesh Kumar K.V (Arm) wrote: > @@ -68,14 +71,22 @@ int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd) > goto out_put_hwpt; > } > > + if (idev->kvm && !kvm_get_kvm_safe(idev->kvm)) { > + rc = -ENOENT; > + goto out_put_hwpt; > + } Can we actually do this or is this circular module references if kvm isn't built in? kvm->vfio->iommufd->kvm isn't it? This is why I want to use file *... Jason