From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C9981A6822 for ; Mon, 27 Apr 2026 15:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777303079; cv=none; b=DcyDF86z0J8BOeD5ECZK0D0vdxVyaJUUpdM27+T6xbfALnY9SvsFf7zoyMy+CJy6b9IJi7VzjhVHdraV8mkYVy27N8+Pe7fnjYFpIg8ZCTy4kvNDrPWg33XJSW8NJR4U6bnIceY6PGcJWbcp3Bi/luMt3GfGxxH8WuP1gu+/+KU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777303079; c=relaxed/simple; bh=s5bvPcPyNNrUb+9raWHqJ224ALUsb339+uFEi0OQn1g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uuS0f5+uWlZtuZFZucXbG/kYJooQYho2wNdC9zIWcXu36LHZQbQUMgmHAJC4AYGAMqBmgA5Fr/1MXAZEkaX2Ltfp03GYmfl46+0C42fBuvPVDsvQ73+xyW+vYRieiiZ4mL9ttbHz17RtIP8sxo1w4nqZtR0jV+DBFNk+x0us6O0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mNoBqa3y; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mNoBqa3y" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c70d802cc05so218685a12.3 for ; Mon, 27 Apr 2026 08:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777303078; x=1777907878; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9WOMjsU2c/RPBFFrc3kLBuPV/u3CAkTOWTslSs+Jm4g=; b=mNoBqa3yBNtDLrVNFLiNn9Ybjz2Flbkmp+K5vrv0eI+KGg91L1urN7KJSt4Qqn6p4D vlXreyBOCBcy/vLL73KGhScEyrRJaMw6q36vOSLeNRqNFIYlbi3zM0vO4b6Gz1ptpdmW f6ocm0zxMWXrAtqTG2zMKRB8Gkf0F/8XQSrxJhAKcEtsTq7A5CDtlChfI6bmwocTLoVr A1gTZzGnbvigW4NrcbqPoDoNJPE+cS/zg8gTB5kEsrHe12LcjRpO8dRGAFwj8P3s+hjf 9U41JjC3caLACAiquAwHlCBp+U5OtwMmNRyrwN1tugJRdI06dDnbEvg1cnmR2DdjdNsn lfZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777303078; x=1777907878; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9WOMjsU2c/RPBFFrc3kLBuPV/u3CAkTOWTslSs+Jm4g=; b=G+00exjtVyon4ST549JaVUzfZOYuskvh6GWpRiFzzLeP4XoKArIKagpWyV04uLMXi8 NNv+wn7g2Y8Vy+aQwRIKxOY6hwKv2bUHvSYnwWF7gOCzCdKpeE9nX5mnoRmvfu5+G/VN tS60W+r42tuMsfEmrkXZGSBRJ3yC+4o/aRuHFR6ew/mw59XBvX9F7F3y8I1Un/IGMR1g aP+zCTeXw3Xyy8kgs+112Z6iTox8/fp66fIZmyoSUbJ/ejwOIsoew1lNpwiQTk7inXw7 1AHqYbwDRT/uSttnu4ytF0eHQjgg2ItL1HLc+0WXN5jb6ujmX23e4rL6zZNqbc6nbmve ts5w== X-Forwarded-Encrypted: i=1; AFNElJ9AVTxu/GGlUqhpxAekuUdEj0lvf4rX7oE39UeKtMC/sXacTbA7Q/pBXt+U7fw0o1kbi06gMwtlBJCKixs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzzbs0GUqi5sXvnGT8ePgubpN1khwpT/iDDMUH44dxn+IaZZzPc NlI2J32KX8A2eXj2SDp2f/59zKZvpI4T8UOr3UVwf3uoob4Rx72GSUcB X-Gm-Gg: AeBDievays5Jd1ZnSESkbRVasdT03A7Eq64a8e33aRMUAwwG9sTCeUuZ1PW1F4lugK1 XcWYSBgROnUlcEc9YbNYh2ENPGCFowRWQXlrt34TkQJneioJWVdorm9U9XWR1u1qsKATvyuiToy YbYZrjKcq1MlIuQf3iyEDCJ2I3EV1cfXMKA2BT101xRrgwZTLwZ4ZcKJ7C6/ytaVKSdu0ElFDO7 YEh2x3OlmOv6QAns2IXauZxd0ryMS6zGRaxn6XtRRWZlAcv/c7Ts25w1UmcI/uW0jKneXmIOSTU dTrFWgFH+d8BipS5nw6MfieuE6cKw/acTd5FE4ydHFeJ3XgOjYTeWjiNCNW01xaL/Uhvg9WGqAh 3RxeToeZuTslNaPMGFnNwpNeTdOUq/+4DmCn1HW3haRFL3QgsUBI+0XRfDHDVzhe18NE9+t3qyV nhkRrCHtkkoOnBsSQrtg1WA1NZBCPc27qyWL7QbU58dK9CDRJSaHJE/8JvGtfZwzhdJfftVwPAc ygSZ9W8h4hSqn9mZy9C6maVLVQ= X-Received: by 2002:a05:6a21:4014:b0:3a3:18d4:2590 with SMTP id adf61e73a8af0-3a318d46f24mr12219497637.3.1777303077770; Mon, 27 Apr 2026 08:17:57 -0700 (PDT) Received: from fedora ([2401:4900:d824:7468:545f:3159:76d5:30ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec06cbfsm37652931b3a.58.2026.04.27.08.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:17:57 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ayushmukkanwar@gmail.com Subject: [PATCH v5 0/4] staging: octeon: modernize logging and refactor to per-device state Date: Mon, 27 Apr 2026 20:45:51 +0530 Message-ID: <20260427151556.91153-1-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series modernizes the logging infrastructure in the Octeon ethernet staging driver by replacing pr_warn(), pr_err(), and pr_info() calls with their device-aware counterparts (dev_warn(), dev_err(), netdev_err(), and netdev_info()), and refactors driver state to be per-device. Patches 1-3 convert logging calls to include device context in messages. Patch 4 moves the static rx group array into the platform device private structure and passes struct platform_device through the call chains instead of struct device. Changes in v5: - Pass struct platform_device instead of struct device through ethernet-mem and ethernet-rx call chains (Greg) - Move static oct_rx_group[16] array into the platform device private structure to eliminate file-scoped global state (Greg) - Update kdoc parameter names to match renamed parameters Changes in v4: - Broke the series into much smaller, focused patches to ease review - Removed the global cvm_oct_rx_refill_work by introducing a per-device struct octeon_ethernet_platform, allocated during probe - Retrieved the device pointer via platform_get_drvdata() and passed it down the call chain (NAPI poll -> rx refill -> mem free/fill) as the first argument to avoid global state - Note: Dropped the ethernet-spi.c IRQ handler conversions from this series for now, as those errors are SPI4 bus-level Changes in v3: - Use netdev_err() instead of dev_err() in ethernet-spi.c - Pass the netdev pointer directly to request_irq/free_irq instead of dev->dev.parent - Move the device pointer to be the first argument in helper functions - Fix checkpatch alignment and line-length warnings - Add missing @dev kernel-doc parameter descriptions - Wrap commit message body to 75 characters - Fix author name formatting Changes in v2: - Instead of adding pr_fmt() macros, replace pr_*() calls with proper dev_*() and netdev_*() calls - Thread device pointer through call chains via function parameters - Introduce struct octeon_ethernet_platform to pass device pointer through work queue callbacks via container_of - Store device pointer in oct_rx_group for NAPI poll functions - Use dev_id in interrupt handler to pass and retrieve device pointer Ayush Mukkanwar (4): staging: octeon: ethernet-mem: replace pr_warn with dev_warn in free functions staging: octeon: replace pr_warn with dev_warn in fill path staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err staging: octeon: refactor to per-device state and pass platform_device drivers/staging/octeon/ethernet-mem.c | 44 +++++++++------- drivers/staging/octeon/ethernet-mem.h | 8 ++- drivers/staging/octeon/ethernet-rx.c | 49 +++++++++--------- drivers/staging/octeon/ethernet-rx.h | 11 ++-- drivers/staging/octeon/ethernet.c | 64 ++++++++++++++---------- drivers/staging/octeon/octeon-ethernet.h | 18 ++++++- 6 files changed, 116 insertions(+), 78 deletions(-) -- 2.53.0