From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF3C2727EB for ; Mon, 27 Apr 2026 15:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777303091; cv=none; b=HFl6bkRlrno+jpS+GBGBLovBA9HTvXzNm8Ym7LS+3phwywKLrXiWnO5W/DiqrqUWdK0C6ZvczU+s+SMUVHg9Q5XSP92tLFQv0wh4zD+FWWQ+EJs+Gd2uuMIyG0LF7J6F/gOEtjSzzFw/dx9LgtRC3wGtnElG6b0BL9t3LgGx2Xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777303091; c=relaxed/simple; bh=SeLHWJSm3VQuJCEeSaRLCqVnoUtA8KmutbSxFLsMJII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P2ghUK/p3uczqexSoQzCEoUlXU/uL3SDdyh9ZtEJq7EssnI6YmEu8AJDVV3qaC1kH62Ffp46h6i77c+09G474iOcTu25lFOqsl/ltjSzZFeknYSgJvHmdLDUcB9t467rtigzZg75116rKw5gGo/m/lkDWhw54VcTcwzRP20YY5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IBKkbxV8; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IBKkbxV8" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82f1fbe6899so398011b3a.0 for ; Mon, 27 Apr 2026 08:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777303089; x=1777907889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PeeYoJchmIwBM/6rDWjV5/Iw+D5ZiU05N5VNWiTx3CM=; b=IBKkbxV8EiZOimCAOVAJdcF+LFQaa93CAPrUKiSKNKZQct3Ir/Lm11J+niAk/kn8BJ iEQqiOpYA3HmN20iVAB0PxlUCjx4K4bHChObyhR88ujOp6K6c6wjetjIgDlNa8bHwyx3 7PkfenB+rPPbXDQW9XwbGc5wgwxG1ON3hPKVOoQLHiho8HlrcldzFJf+jDOJxrxvW2nw lBYCLlZaziy41DWrSHqhEX5yZmSIn4Om9inCl8elFUOwdqw8L+reS5AlGneWN51Zobuv Mi/dVyLeYGwQhj+H2mOEzRvBAh2j+fKiZwTawFXU0FBlUeVxBQVJqt1W72XJAe97U8Eh Fjvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777303089; x=1777907889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PeeYoJchmIwBM/6rDWjV5/Iw+D5ZiU05N5VNWiTx3CM=; b=mRIjOYfjXPp0Af7tF9nV5QJb13eWlK8WMwjlxiRyBYy2HjyFeVWpBwkBzrQl1qpdia ZcxPWBzlRuyXRV4AZnuFjUWgeAYVK77bE30n6X8f7gHop7RmTVTZVSfmx5yKasUiQqh7 1fgaJKnGfyxzBBLPLkZEJX8JUuuGu3jUzFktAQg5ptBQj+viW9w7H/OscVaCKCU78emo 1z/bKia9V0TomFaQEghm511MIeDWyjzXeTGQcEKKSoRvhnQqM5/oxZlNMbe0p0oiT4ld FBFcLfe1q3PLtd6TbwOnUq2wwkCZun+3DqALPNK442ssnKAiTgrQ+67bP41HOtrvKfGF 3sgQ== X-Forwarded-Encrypted: i=1; AFNElJ/ouFz+3gsjnVwSTgcWtj47xnVDhQmE58Ax7pNJUslFjHhvXYRuUAd6NIeKrYL4YBSwa3F3XKm5H5kubGI=@vger.kernel.org X-Gm-Message-State: AOJu0YzFGaXflnRKJBwQHpluw4wq996Nqhfv+sZOl3dbNzATVCEay1kI 4M/fxzd0lJqWPSh60fXfR5XQ8fZYsRAK9lsKnTSU312mVQwOHoQhTr4+ X-Gm-Gg: AeBDiet4bU7mpyjGji04xEKPy01ExNq0eU1d2XiOanZgMfU59Kdh1selKBlKCh5JF5G SLoahlFiUl6K5KuCk1IOn2Bu+eS4NRr8B44aduzZqXnmYC7wKjG8A82ciXZvm0+GBADp1VRsy5d rYfHxSAiS7pO+B/xJZz+AhWBwntHplkYvbR5/2UF8xdJQWNouGsF6/FO0MbLZTAq/8plXwyubgK frjVQgGvEXEBDtKQ/W6NlxJ9ZcA/Oq1FEg/ReZqJpaMjjBFDQBv0gOLMVLvCvf4daUMtFK7llGa vpDTyb+AdWPIrL7LsL0XveOeLsWgeQtOZKw9t/jzHXKvWbmSaF/H6iMQzT4Si3XlJ+v5AEDLtqn zgjgAHINgfjG72FG7GSqBiAN7F+vKqcYdyAuMWA4lJoys0NQcXy3ca11eKYKUCba3Nj7GJlIffP fKRR/kNcoEXnQotESc2CtkxN3+PyS04LBrcidai5cGT9BqYZVeTj6gCVadDI6cKPau1ag5O1d8N SSPIpB8p79bQUWtTxzLsatrBrc= X-Received: by 2002:a05:6a21:1b81:b0:39b:80f2:7809 with SMTP id adf61e73a8af0-3a08d8dffffmr26783979637.7.1777303088668; Mon, 27 Apr 2026 08:18:08 -0700 (PDT) Received: from fedora ([2401:4900:d824:7468:545f:3159:76d5:30ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec06cbfsm37652931b3a.58.2026.04.27.08.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 08:18:08 -0700 (PDT) From: Ayush Mukkanwar To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ayushmukkanwar@gmail.com Subject: [PATCH v5 3/4] staging: octeon: ethernet: replace pr_err and pr_info with dev_err and netdev_err Date: Mon, 27 Apr 2026 20:45:54 +0530 Message-ID: <20260427151556.91153-4-ayushmukkanwar@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427151556.91153-1-ayushmukkanwar@gmail.com> References: <20260427151556.91153-1-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace pr_err() and pr_info() calls in cvm_oct_probe() with dev_err(), netdev_err(), and netdev_info() to include device information in log messages. Use dev_err() where no net_device is available (allocation failures), and netdev_err()/netdev_info() where a net_device exists. Signed-off-by: Ayush Mukkanwar --- drivers/staging/octeon/ethernet.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index a7ac29c0a4ca..7c3cfd9efa7e 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -698,7 +698,7 @@ static int cvm_oct_probe(struct platform_device *pdev) pip = pdev->dev.of_node; if (!pip) { - pr_err("Error: No 'pip' in /aliases\n"); + dev_err(&pdev->dev, "No 'pip' in /aliases\n"); return -EINVAL; } @@ -796,16 +796,16 @@ static int cvm_oct_probe(struct platform_device *pdev) dev->max_mtu = OCTEON_MAX_MTU - mtu_overhead; if (register_netdev(dev) < 0) { - pr_err("Failed to register ethernet device for POW\n"); + netdev_err(dev, "Failed to register ethernet device for POW\n"); free_netdev(dev); } else { cvm_oct_device[CVMX_PIP_NUM_INPUT_PORTS] = dev; - pr_info("%s: POW send group %d, receive group %d\n", - dev->name, pow_send_group, - pow_receive_group); + netdev_info(dev, "POW send group %d, receive group %d\n", + pow_send_group, + pow_receive_group); } } else { - pr_err("Failed to allocate ethernet device for POW\n"); + dev_err(&pdev->dev, "Failed to allocate ethernet device for POW\n"); } } @@ -825,8 +825,8 @@ static int cvm_oct_probe(struct platform_device *pdev) struct net_device *dev = alloc_etherdev(sizeof(struct octeon_ethernet)); if (!dev) { - pr_err("Failed to allocate ethernet device for port %d\n", - port); + dev_err(&pdev->dev, "Failed to allocate ethernet device for port %d\n", + port); continue; } @@ -910,8 +910,8 @@ static int cvm_oct_probe(struct platform_device *pdev) if (!dev->netdev_ops) { free_netdev(dev); } else if (register_netdev(dev) < 0) { - pr_err("Failed to register ethernet device for interface %d, port %d\n", - interface, priv->port); + netdev_err(dev, "Failed to register ethernet device for interface %d, port %d\n", + interface, priv->port); free_netdev(dev); } else { cvm_oct_device[priv->port] = dev; -- 2.53.0