From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98ED23845AA for ; Mon, 27 Apr 2026 16:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777309088; cv=none; b=i9cjmX+V14xK/SsQoUKxTCsG4SI7Iyjl2zCNmsKBaeyb6HU9GBMcEO59UkO6RV980mwGSVXFSz0Slam0kKyGeNrHO+KRRvMfWq2KUnD0eMrk/HZSPWz/tKfvXhua89BCxBWXoG7+MJngywRsIaKENrK6ToHdl5AezXlQkYcxMmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777309088; c=relaxed/simple; bh=DkOQpD4lRejOxmK9oIvR5xMEtCH7MLNHROWYAAlBnnc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NmCSKX8xrqnC4FZlRQp+2HHvTCJOzg5K8eego23IyA5JGSo/tAyCC3ly0wT8YD0VE8cQtnmOzmD98A9iJpKm6V/HI/benrCZ7btanyZm0wzYBqDQ2CTjCrEbeHV0pvTlNPA6S5tqkaReJi0ZwZj2uz+MGUS5uaGnjK5ZPYxHMlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qQwz3MpZ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qQwz3MpZ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4891d7164ddso52199105e9.3 for ; Mon, 27 Apr 2026 09:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777309085; x=1777913885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=o3ZI0LJNGOCBI20WP1P2qZ+bTqh4ah0JmxhMCroQ3y8=; b=qQwz3MpZAt0iEh7PC9aI9Oo8XKunCDt78NWJShHej0wPoKyndCRbruLhZbO8klclQ8 S8NnezAcBwRPGi89qmrkFa+I1mMDDx3VuppDipwEXn4jkCpiXZuHdClT0cUtF+v0UkMr 4wzlB7+DvisK5leex0IgWIaOW2QcG3wX1HgzIMCN8x3+UdtUWKeFvUBGgXZ80JVLmVqo Pmzs+X40SgeTe5GumuL254c0OWNM09DFvg9n9p/erqXEOvSJm7LD0bI1mIcg657zzk8q co38yQd7VYciCg9Fl3Mgc1ugNHEVJK/NoyJfKQD+6xCvAshh2lHlA+B08ulAIrWFD6t6 P7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777309085; x=1777913885; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o3ZI0LJNGOCBI20WP1P2qZ+bTqh4ah0JmxhMCroQ3y8=; b=J5bmFguwl4GRHPuiAtTgDIimAowDdkYvzv5OvDkBc64l8EWLjnneQmkXyTjkprthAC LeKDlciXzCY6EALVyQz2v80dE0aTkj2bBbBSZ9NiyrJHnu06ygJ1wy9CtT2OG7+SClVG 2XYcH+pw9eqFw2d3jvfV8QSjjcg0I5Y6ZfRiYY5evEjPOupBpAxykGX1vqz14r30/CCv wINq+z8uAejyYYABJHI1+U7YcIzU1gUe+IsSEsCce4w7Lua3OYdawCCm0UrL88vTQjYj D6s0ewG2y/5E2M8JRgsBOC1q+418z4qWZQRX/+lSs93JvBnT5OJpoaaISSv2+IhH1ylW qJJA== X-Forwarded-Encrypted: i=1; AFNElJ/Z0egVmT2PHrsLgHgPxn9r7dR2n0K5+LoEWjxpwoDE0kSS8pEUF9DmUVALL8ge/KwBfdMzp/IiqFPP8uM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3yytjxhfioziobcjSLaEOT6Lf88UAy+wQxxLLNBkAUSEzLY8t PlF5DwjtC6x3NMCP2po4uSq/Mc/cz+3HqWjDyu8vZ9r9Q+o3EcnYgsjL X-Gm-Gg: AeBDieucUiiMmcKDZPUdmm/ZXLKTIxj5CAjipHlWhYbYwrcCqJpFiDN2vO2qJVNpS+O OFh/q1iQ1LeEAVpTiuT95t06UXKpZf7/QEwGuRy5lzjN7hXXXdcTXN/X0hHMrteI8DDL6Rotz87 WMwPLjMESjtw568Y/ia18iDd5EOr6u4D0SxvP+UCWp9uu1QIB+fN9l8o0zVMvs4FlCp6it9oeX6 OWWPbrgWo1YPGcF0qFsu0U2JLoGjzYsZsHUFFUCbIo13lS8ZnKitBsk+fZH56Vi0wbWIbIWCGsV +Ee0YBoK/8zoqWKGlyZBXDdu1lFgHFIWGjJTFTHGZKmEFHqWgIBDxc/JshrdsGJJtIogewptMr3 cOD2sXpzgC/8vaIQqDl3no4dpwu/J+g1CJY2cwBJKZpZNM5JhINwjhIyaR6GtGRtF0MPPg4z/Cy P4H/4D5nfg3mME0mWCalgSyian8kjugpiVolICEB/dRiHB0LhH X-Received: by 2002:a05:600c:a319:b0:488:fd7e:1063 with SMTP id 5b1f17b1804b1-48a76f91970mr1400915e9.29.1777309084799; Mon, 27 Apr 2026 09:58:04 -0700 (PDT) Received: from localhost.localdomain ([196.235.239.18]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a76f7f483sm2721465e9.0.2026.04.27.09.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 09:58:04 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Salah Triki Subject: [PATCH v2] iio: adc: mt6359: fix unchecked return value in mt6358_read_imp Date: Mon, 27 Apr 2026 17:57:59 +0100 Message-ID: <20260427165759.5756-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In mt6358_read_imp(), the return value of regmap_read() is currently ignored. This is problematic because if the bus read fails the variable val_v remains uninitialized. The function subsequently assigns this uninitialized stack value to *vbat, leading to incorrect measurement results being reported to the IIO subsystem without any error indication. Update the function to check the return value of regmap_read(). Ensure that mt6358_stop_imp_conv() is still called to clean up the hardware state before returning the error code. Fixes: 3587914bf61 ("iio: adc: Add support for MediaTek MT6357/8/9 Auxiliary ADC") Signed-off-by: Salah Triki --- Changes in v2: - Added Fixes tag. - Re-examined the entire driver for unchecked regmap operations. While several regmap_write() and regmap_set_bits() calls also ignore return values, I focused on this specific regmap_read() in mt6358_read_imp() because it leads to an uninitialized variable usage (val_v). This makes this fix critical for reporting correct data to userspace. drivers/iio/adc/mt6359-auxadc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/mt6359-auxadc.c b/drivers/iio/adc/mt6359-auxadc.c index 6b9ed9b1fde2..f927bff4a26a 100644 --- a/drivers/iio/adc/mt6359-auxadc.c +++ b/drivers/iio/adc/mt6359-auxadc.c @@ -497,10 +497,13 @@ static int mt6358_read_imp(struct mt6359_auxadc *adc_dev, return ret; /* Read the params before stopping */ - regmap_read(regmap, reg_adc0 + (cinfo->imp_adc_num << 1), &val_v); + ret = regmap_read(regmap, reg_adc0 + (cinfo->imp_adc_num << 1), &val_v); mt6358_stop_imp_conv(adc_dev); + if (ret) + return ret; + if (vbat) *vbat = val_v; if (ibat) -- 2.43.0