[PATCH v4 5/7] staging: rtl8723bs: rtw_mlme: remove dead commented-out code

Salman Alghamdi
2026-04-27T19:06:09Z

Remove commented-out code and its associated orphaned comments.

Signed-off-by: Salman Alghamdi <me@cipherat.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 98271cea2bf2..47c0d176dbdc 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -750,9 +750,6 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
struct wlan_bssid_ex *pdev_network = &regs->dev_network;
u8 *pibss = regs->dev_network.mac_address;

- /* pmlmepriv->fw_state ^= _FW_UNDER_SURVEY;
- * because don't set assoc_timer
- */
_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);

memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid,
@@ -1062,7 +1059,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter,
preorder_ctrl->enable = false;
preorder_ctrl->indicate_seq = 0xffff;
preorder_ctrl->wend_b = 0xffff;
- preorder_ctrl->wsize_b = 64;/* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =32 */
+ preorder_ctrl->wsize_b = 64;
}

bmc_sta = rtw_get_bcmc_stainfo(padapter);
@@ -1072,7 +1069,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter,
preorder_ctrl->enable = false;
preorder_ctrl->indicate_seq = 0xffff;
preorder_ctrl->wend_b = 0xffff;
- /* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =32 */
preorder_ctrl->wsize_b = 64;
}
}
@@ -1712,14 +1708,8 @@ void rtw_dynamic_check_timer_handler(struct adapter *adapter)
linked_status_chk(adapter);

should_enter_ps = traffic_status_watchdog(adapter, true);
- if (should_enter_ps) {
- /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */
+ if (should_enter_ps)
rtw_hal_dm_watchdog_in_lps(adapter);
- } else {
- /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1)
- * in traffic_status_watchdog()
- */
- }

} else {
rtw_dynamic_chk_wk_cmd(adapter);
@@ -2254,19 +2244,11 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
/* 1. Supported rates */
/* 2. IE */

- /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->wireless_mode);
- * will be called in rtw_generate_ie
- */
sz = rtw_generate_ie(pregistrypriv);

pdev_network->ie_length = sz;

pdev_network->length = get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pdev_network);
-
- /* notes: translate ie_length & length after assign the
- * length to cmdsz in createbss_cmd();
- */
- /* pdev_network->ie_length = cpu_to_le32(sz); */
}

/* the function is at passive_level */
--
2.54.0