Re: [PATCH v4 4/7] staging: rtl8723bs: rtw_mlme: extract local variables for long expressions

Luka Gejak
2026-04-28T06:07:54Z

On April 27, 2026 9:05:32 PM GMT+02:00, Salman Alghamdi <me@cipherat.com> wrote:
>Extract local variables to shorten lines that cannot be wrapped
>cleanly.
>
>Signed-off-by: Salman Alghamdi <me@cipherat.com>
>---
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 56 ++++++++++++++++-------
> 1 file changed, 39 insertions(+), 17 deletions(-)
>

...

>@@ -792,8 +808,10 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
> if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)
> && check_fwstate(pmlmepriv, _FW_LINKED)) {
> if (rtw_select_roaming_candidate(pmlmepriv) == _SUCCESS) {
>- receive_disconnect(adapter, pmlmepriv->cur_network.network.mac_address
>- , WLAN_REASON_ACTIVE_ROAM);
>+ u8 *mac_addr = pmlmepriv->cur_network.network.mac_address;
>+
>+ receive_disconnect(adapter, mac_address,
>+ WLAN_REASON_ACTIVE_ROAM);

Here you declare u8 *mac_addr but you never actually use it. instead
you pass undeclared variable mac_address to receive_disconnect(),
which will lead to compilation failure.

> }
> }
> }

...

Best regards,
Luka Gejak