Re: [PATCH v4 4/7] staging: rtl8723bs: rtw_mlme: extract local variables for long expressions

Salman Alghamdi
2026-04-28T11:46:54Z

> Just write this as:
> if (!rtw_dec_to_roam(adapter) ||
> rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,
> 1, NULL, 0) != _SUCCESS) {
>
> The "roam_failed" variable isn't beautiful and the if else makes the line
> five characters longer than it would be otherwise. Eventually we'll get
> rid of the _SUCCESS but I like it to look ugly so we know which code to
> change.

Should this change be in the same commit it was originally made on?
I'm not sure if removing a variable from an "introducing variables" commit
makes sense so I wanted to make sure before v5.

Regards,
Salman Alghamdi