From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 740583E5EF8 for ; Mon, 27 Apr 2026 19:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777316939; cv=none; b=hHh+Y3/lgzhvTLEWNjp1E1c61P2GtoN/XfNb1XU8lVnN2uDmB9wu2ktTUyz+9VrIPh9zGaB4KNfGcTDf32HsbTZPPV76Bq6OxAUzgE3KJVv1Hz2o3i6i/ssrX6/s7H5k52JNhRxwCP81rcGe72KbCCax7ShayqGj1USGcha2Egk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777316939; c=relaxed/simple; bh=Akn3iB4bFuxCQFbqQ3c7B3zgWSwIMH4AiVxTuqgmFQU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LCg2FZCViT6EOrTxPBtgdpgYKCQpzTH2WilmPmMI1Y0Y2sS8NbFeuNjpinJKh0vRe4sE5tZ/nzcfrwywGBYSjbkPUrZziiTKFm3IldShBpyT8C4nygFH5HwcO4ykgxr1Lgu/ASw80CzC1mmoX1aHBwL8hVDNQLyad1m187o5uug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mSo0dq2y; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mSo0dq2y" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488b150559bso84233935e9.1 for ; Mon, 27 Apr 2026 12:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777316937; x=1777921737; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FwBDxvhhf1dytDgVC9wEZNucPdGR8g31jisecswPi0k=; b=mSo0dq2y4O+zbkz381eVub+nFrNinNY9tnpG8s8zlCfMDgUlDyzqVhbQLD9vY/PIiy K8Korm9+8YMxTsYVjCHOhiv1PQIYCFjjfvZvI24W4EOqVJ/GZTRtqKUncbTHMTwlclUm 9xfGFOKom96a/qvHOGYWnCpZK0M7J7tQ5ctl4qO42NXcmLN+TFOjg5V1RMf10Bt8Lduq Vsprg3muGW6BfInz2+wdXYza+mAxh3ydgvk+pgyz46U5mi+oz71dF8wZtgUqGoG4ARqC lcCxrPGNFf0li1m0FZSCAF+rwYld5YAnCagwkmnpwogD/V5JUNQVxHjXKMRIMxRhCs8J AS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777316937; x=1777921737; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FwBDxvhhf1dytDgVC9wEZNucPdGR8g31jisecswPi0k=; b=fuSx3QsuPf/EZGotmw4NvxznuAfchfBwRW0m7mSyR/4JRRjGMphsvcO1bBDAodHVZ2 f3HnuGDwHP2na/2BB9Qx//dZKqcUTllOWcDssFMIe/PCU4PlxMjTkjRKIehooSBXVBrI RIIIkczqc58/o4ttSGOKHwsqLC0wO24k30nOq02de4lsw3a0AJqimOjjRagocV++KABi LrnUMGy2bKmHu8ykRUSya0cxg7zirh3yz31piEJNK3hsZ3f4Qhhm8KZYGudAfdhBjGaO vJs5IBSsDDkFU7MLjexe8XMm92K/bdlGXvAcIS1GHNq/wpXKdh1QM1jKLs6oTgFr4ky4 LtfQ== X-Forwarded-Encrypted: i=1; AFNElJ8Xg5pKCscwU9SlEffo2yPFwTRZ1hu0KgplOiTpORSQq/7XJOARBta5torONBI+9Bfss6RuOmieE2AQWhc=@vger.kernel.org X-Gm-Message-State: AOJu0YyvN8ieZ/kcSyfsydcjNBnuj1AtOofwNExm3UnZh8NYv8QO1JmK mvt+nIcseTx0SRcxJVQmdbYtqHQG7vFVrFxznC3VJS5o3HFH8v2CaU/GO5wlDN3f X-Gm-Gg: AeBDieusf1R5D8GEH8iXhUTYQ0vfHv2FGFWXkTerMzmQSwsobTASlPxq44aCm6qrLk+ rIN0CyTzZCuyGlAjdbRppXpeJ1WuELozf6AePG0kLrKINcQtwclZkAX4fd2EVwUbC6GKoyyPFF4 mF9tRRxdA5/vGH0HZ12PfHXIJwwhidfHzJjNHo2prrH1q0QkDE9AeLTksFsFekwK2a56J6ySoDP KKCp25719dCSPDdHolTsY0FdA9OpT7CQQMfZjouJCqHSbqCB6seMK0gu56gkrZWNjfFHkfAYyvC Kbf0u7t6+NxGeS4fLVRbtmJOvpggZ7eS0Rk1N+bccTeTo7oik5ZS9Amv/tKO7WVxnTLwmaOZTih AdgQ1qRerV1lMXhor+02muieZX3i446tbA/kYKxh0CN8ytKZegtW5t+a0c6b6kOC8dHOltM+wUY d2FS0Nw8o8GGk4J7OnwKDFxBSSJbd7PPzE1ZeC1dMFkwE4UtHC X-Received: by 2002:a05:6000:240e:b0:43d:6fb7:fee1 with SMTP id ffacd0b85a97d-4464aced261mr153573f8f.46.1777316936724; Mon, 27 Apr 2026 12:08:56 -0700 (PDT) Received: from localhost.localdomain ([196.235.239.18]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463cb59d5esm504286f8f.7.2026.04.27.12.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 12:08:56 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Salah Triki Subject: [PATCH v3] iio: adc: mt6359: fix unchecked return value in mt6358_read_imp Date: Mon, 27 Apr 2026 20:08:49 +0100 Message-ID: <20260427190849.14963-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In mt6358_read_imp(), the variable val_v is passed to regmap_read() but the return value is not checked. If the read fails, val_v remains uninitialized and its random stack content is subsequently reported as a measurement result. Initialize val_v to zero to ensure a predictable value is reported in case of bus failure and to prevent potential stack data leakage. This also satisfies static analyzers that might otherwise flag the variable as used uninitialized. Fixes: 3587914bf61 ("iio: adc: Add support for MediaTek MT6357/8/9 Auxiliary ADC") Signed-off-by: Salah Triki --- Changes in v3: - Initialize val_v to zero at declaration instead of checking regmap_read() return value, as suggested by Jonathan Cameron and Andy Shevchenko. - Update commit message to reflect this new approach Changes in v2: - Added Fixes tag. - Re-examined the entire driver for unchecked regmap operations. While several regmap_write() and regmap_set_bits() calls also ignore return values, I focused on this specific regmap_read() in mt6358_read_imp() because it leads to an uninitialized variable usage (val_v). This makes this fix critical for reporting correct data to userspace drivers/iio/adc/mt6359-auxadc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/mt6359-auxadc.c b/drivers/iio/adc/mt6359-auxadc.c index 6b9ed9b1fde2..0e52effa55db 100644 --- a/drivers/iio/adc/mt6359-auxadc.c +++ b/drivers/iio/adc/mt6359-auxadc.c @@ -489,7 +489,7 @@ static int mt6358_read_imp(struct mt6359_auxadc *adc_dev, const struct mtk_pmic_auxadc_info *cinfo = adc_dev->chip_info; struct regmap *regmap = adc_dev->regmap; u16 reg_adc0 = cinfo->regs[PMIC_AUXADC_ADC0]; - u32 val_v; + u32 val_v = 0; int ret; ret = mt6358_start_imp_conv(adc_dev, chan); -- 2.43.0