From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D44326D45 for ; Mon, 27 Apr 2026 20:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320782; cv=none; b=IUB1VqTLWQZzm7Eu7KYzz6W2IbGRHPoVh07/nSdaR4jgyeIkyVPNjnbjOjwo422Kg7FRita+A3GDUFvH8LGh0M7ssaa2JOZpazAHKRhkqz6heuPGoYDLtz5mAkEaVv5dDYp7ok0OdbsIeO1vUtrSuItmyEDvTMvizRkk4sv81KY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320782; c=relaxed/simple; bh=VDD3EJcDxtsD+v0HZx6dEJV9wSDLF2KCddUisNYKU/U=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bFNVG7g1DqflLBx3k+B4U03K8pDB2OalD+tSX0q3AXjJtPR83zjsc4YKXEf+aDiI7UsCvp1mDZxAPC9Y3gSLA+XsojE9XJW5wg0NT8ti43830EMzOtCU2/q0sWrVXYWGdVHDOEJZ+owIdCJm1itVfvH2Dr8Q3RKjUCs+6YEgfzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iGH2Vplz; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iGH2Vplz" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cfd1f9fd1so6636791f8f.3 for ; Mon, 27 Apr 2026 13:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777320778; x=1777925578; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XX52kU6I+oTtnTaZWgm7ccpRK71cywO/xadAPHW06nA=; b=iGH2Vplz7bIKZ/7mOc7YUAgAlT2IZ6UkfsLNW+/1WNBgtF8XiW109XqzJVeeRkvLBk DyIN0TnEGG9Vo+2pmEqPrEx/im/Lt6aCuumJOoMHzreG7cq9hgu1eor9dnwITeEHtKz1 BXqkLtNQihwHzdBf/4tQu9plVVXV+4RWsUABtem+od8V3rKanQhx/3JwsqkbvBg/fATS fbJ1LsFOTtzReOH0aKOyg+STeT+xc4SzKx6bvi1aRoCSdluF2pvDaSNHzlNSL0o1m1Qx Gj3MdH436bcJ8txnzSBZViLty+0Bq0xkbDC9VqTzox5UHY5azHeoM73T3ab45Gd+L5L3 TV6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777320778; x=1777925578; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XX52kU6I+oTtnTaZWgm7ccpRK71cywO/xadAPHW06nA=; b=rwX0ReKdFtueIKy9vypbpVefH3TvuxreZCYZTNinl/XjEqhHNPIRVa5VqF3h7vlz/x nf+u3olKYINjLY6em69wIN4jc22Z7YN+QcI0/DcggT6sSVk/a+ITVl7N+CnnxMKwYhb5 g4A6Yjn9b6V6gVk1QPPZ/NzWwNKjoRSju5VXfJRoXFuCBy0Xa4cE9iVdCJNWttFsR9ri JKzdrAUJ43u5UGpmY6uC3PNrLqqR5aGBuY0ll3BV/HfOyYMEPsZE4MXZdR7aKyFeqBHL 9UIho2x0xWbAesk9LJBwkqYb6ENg8GT8BqR5kkpcunzZgPo/uKmVGkUnTQjOTUqpMhDo CW/w== X-Forwarded-Encrypted: i=1; AFNElJ+lWjY53AlDM/zwt3ZenIcbYr86ilkRldEHR/XTXXXErc6MWJKxEna/8k7IUqokCaK6FA9HrVLCedKD5zY=@vger.kernel.org X-Gm-Message-State: AOJu0YzNTc7cCZHRDG2+KLkdA6A8zXZtdPv9tGXRLwEsv4+5/3wPz3l5 zn7sXlX3YU9Gtax5/CS5AHoXFi3USWBNHN2sbhqRdekzjcAq6Z3kXCix X-Gm-Gg: AeBDieuVu9KUTkWdCOcpfMSAh89k23zf8aogTbxAUN+PZKBhmKZLJwUo9cIZBVsf5QY gLiY1jTe8ynpZg3HoLhEBnPqi77AEZNNapglnlkgkz1jRvWrdSZLt8k/EFzCgGK5tDR7d3khl7Y XH/dbEeIrlyLHPJnTHMteOSZDV7PeOtFTsh6knElEzVB973xS64pPMLAjAiyii/9WMd654cdt5B DvYGioEHlv8ZX+EDp2xpMFVcCfsItYhQlshG9Hw1fTXDuo+9oxttjTOBeXwcVyXTopnSvnvtjsX vfAyu5Ap/WOy2t2X9+x6pjad4S3SiSwO8teVmJhNc0IJ9O2GwDq72tdokIFNQL/drOe9nc8+de2 nEchA1DCkdPZiWKO3D/SudnhxcBjZveMH+5zDFupKSrq5iS92C4FJS06l+8ingDpBy44B3hHuiP Zg+NxuardLeflQqBApe1RlpOW+uygBAy2C5flztF/w15qz+CIg X-Received: by 2002:a05:6000:26d3:b0:43d:7d6f:f535 with SMTP id ffacd0b85a97d-4464b1b84e6mr423171f8f.35.1777320778397; Mon, 27 Apr 2026 13:12:58 -0700 (PDT) Received: from localhost.localdomain ([196.235.239.18]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463d02f270sm726826f8f.9.2026.04.27.13.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 13:12:57 -0700 (PDT) From: Salah Triki To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Salah Triki Subject: [PATCH v4] iio: adc: mt6359: fix unchecked return value in mt6358_read_imp Date: Mon, 27 Apr 2026 21:12:38 +0100 Message-ID: <20260427201238.20823-1-salah.triki@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In mt6358_read_imp(), the variable val_v is passed to regmap_read() but the return value is not checked. If the read fails, val_v remains uninitialized and its random stack content is subsequently reported as a measurement result. Initialize val_v to zero to ensure a predictable value is reported in case of bus failure and to prevent potential stack data leakage. This also satisfies static analyzers that might otherwise flag the variable as used uninitialized. Fixes: 3587914bf61 ("iio: adc: Add support for MediaTek MT6357/8/9 Auxiliary ADC") Signed-off-by: Salah Triki --- Changes in v4: - Move val_v initialization just before regmap_read() call as suggested by Andy Shevchenko to improve maintainability. Changes in v3: - Initialize val_v to zero at declaration instead of checking regmap_read() return value, as suggested by Jonathan Cameron and Andy Shevchenko. - Update commit message to reflect this new approach Changes in v2: - Added Fixes tag. - Re-examined the entire driver for unchecked regmap operations. While several regmap_write() and regmap_set_bits() calls also ignore return values, I focused on this specific regmap_read() in mt6358_read_imp() because it leads to an uninitialized variable usage (val_v). This makes this fix critical for reporting correct data to userspace drivers/iio/adc/mt6359-auxadc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/mt6359-auxadc.c b/drivers/iio/adc/mt6359-auxadc.c index 6b9ed9b1fde2..1d9724ef0983 100644 --- a/drivers/iio/adc/mt6359-auxadc.c +++ b/drivers/iio/adc/mt6359-auxadc.c @@ -497,6 +497,7 @@ static int mt6358_read_imp(struct mt6359_auxadc *adc_dev, return ret; /* Read the params before stopping */ + val_v = 0; regmap_read(regmap, reg_adc0 + (cinfo->imp_adc_num << 1), &val_v); mt6358_stop_imp_conv(adc_dev); -- 2.43.0