From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73CBE2F7478 for ; Mon, 27 Apr 2026 21:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326090; cv=none; b=qTfFKvJI9w/rID8U67psG56FDbnrp+NeASXvDhCPJFF1P3KUXB5gS2++m4fKIN8fIfMOYiFuVddv6jKoEHXlHsPB1mSH7AD86n3RYIWBYoJefNs/uySqzv6BJwxj0YvMXvRzuoUiE7+jW+ijAelaDSqRLoZF6yOj9qktDljy/Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777326090; c=relaxed/simple; bh=eZX3CDov/wKXGxHlMANg1Y9JRIPqVl+INQsMru3R7jw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EYK91sGVw8Yjqm6upVYoZEosy4pXAhsCgqxvBxw/DVRv9vyf3HP1Ot0avuVdJFUVoAtmH/wjL5orXEUpShLo1kaqrYHLA4CjfOU6t/G6Pj5y0VUgSxC3jsoNSmbvzbd+x9I/qiUGcAa89QPyvSE3zFIoUKe0kmnqRgab2pWcKzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ci+ImqOB; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ci+ImqOB" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-685017d0fbcso5839258eaf.3 for ; Mon, 27 Apr 2026 14:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777326088; x=1777930888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XccsB8eYNsZqIBiFPfFrnn/DwDUI5DYyitE3KWf801U=; b=Ci+ImqOBhp/t+JVUKiQwYz7KgpcsAAuL4Q4WHtr/qhuzOwDErg9k93jmt781xwLLgz pJtjg+6UW8xIMsxbiQVxFhatvigiJuY7tpjQ4t4nTKkQqZ5JsYDfgxJTYOl9qUDAvw8b qtD9ge6atiF0SvrjhS/Y/XikiUkqp5uN1ZHyhdudsrDerZx5GdIaUQpG+0jkLwAuAy5z N/zxPGeZvFxj9UTWGWGW54YzxUaKaDnZZN3MMbASTDlT2gI+HygFl/jbrdXcKo9N0pVM 11NT005yQvaJrkYQkw8xNn2xLm3DXvtxAZJ7ydaUEqaqM4Rq3iFVdmogV7TGr5Uz3fMR DRpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777326088; x=1777930888; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XccsB8eYNsZqIBiFPfFrnn/DwDUI5DYyitE3KWf801U=; b=QpqgkgeX+8ZmuDLqFMrvCg6Jv/wm3ohpfeAusoQYk4ywrJV3E6TAQvh435OUWtn+3e EPRfVv9ZAzR3NuO8NvUo9+afyFgJC929nj/CGUTcadRiAgFvoc0lYbVnn7vXFETZUeWJ TUEslojYkumv01v7Yznzaymk8PoHIIrOPRHEquKekPZ96sPxK0wx9miE5oBpHu2YaEUL IMTvbcjU2T713VsWw7nod3XUcOAzjPx1/WusiyxXfkG6sprXLGVBImgFLdJJlCc2FB56 e2Wz4dnCpPnwdj2rbmlfW7Pin0mmu1aQ02ihoVereJmwcgCBkamihE3tetqfuLToovbq R4dw== X-Forwarded-Encrypted: i=1; AFNElJ8BhJudsavhZF7uX6YHFd0r7mBQ3nbfh4sHqgVaZfH9/ldw/bgnHCivtrGziEqkaJNItkrbpnvhU54n+ZM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzp+lqkDIAO9uCyVkG5T+pbTPdGXn7DGjuibcsfZO8q06XMhRQD H2QAkjBZVnStY3pG3PYa6BIJ3ZpQaJZwh/GnWWtVUB37VFwIatRpLKVI X-Gm-Gg: AeBDieumsGZtWo2GjZVbVK1v9V6TW9u2dGnFYaJqC4YUPRxwDNfO9xRShfbbCYQ/nCM 5DIHYr4ZzBg52Y9eF1furBDpmxXG3X3Dqqw0D7lVAF0+rTbElgZBWzP9APvOpORQo3Im/xokwGf bARkA6DQfP3ot2cwke85v55D7PfdEPsCUvWCtnO+8Z6MZvVZbJajn/qk7BwJgCe/7xvQPvI+X3Z i7aRsL/L7uW1+MQLWPm+iOR+5EcSLYH84GyZtmbvM+bFTrVJL71omc4gin7eE2wo1TKpZSkWo7N GmODAflGWeIjEyF2vbCgMobp9owgrFIUdGa62ylQBGGagrwkNuHSA1DmVGgjMNIPKXaeRw8DxAo zzlaFnwbZIjRDmLFCjo1DrvKZq5igRyV2aYagit91sY0Rknqe3aslMb6wwXgtWSdgO9PjNvJfOB 4hG6ohgPGEj7wUbVvK/VjHPTBNwn9XaDg07Ac4sD7ALAU7PDnk9nK8iLpHSa9gVi3aMuam X-Received: by 2002:a05:6820:2005:b0:696:23ca:a8 with SMTP id 006d021491bc7-6965cbafc8emr180949eaf.54.1777326088256; Mon, 27 Apr 2026 14:41:28 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6965ba3686bsm348322eaf.9.2026.04.27.14.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 14:41:27 -0700 (PDT) From: Maxwell Doose To: linusw@kernel.org, brgl@kernel.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] gpio: sim: Replace sprintf() with sysfs_emit() Date: Mon, 27 Apr 2026 16:41:26 -0500 Message-ID: <20260427214126.17818-1-m32285159@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace sprintf() function calls with sysfs_emit() in the configfs show callbacks. This will help harden the driver and will bring the driver up-to-date with more modern functions. Suggested-by: Bartosz Golaszewski Signed-off-by: Maxwell Doose --- v2: - Rebase commit onto tag 7.1-rc1. - No functional changes from v1. drivers/gpio/gpio-sim.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index e19701c2ed67..d1e5f0ad56ad 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -695,9 +695,9 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item, pdev = dev->pdev; if (pdev) - return sprintf(page, "%s\n", dev_name(&pdev->dev)); + return sysfs_emit(page, "%s\n", dev_name(&pdev->dev)); - return sprintf(page, "gpio-sim.%d\n", dev->id); + return sysfs_emit(page, "gpio-sim.%d\n", dev->id); } CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name); @@ -711,7 +711,7 @@ gpio_sim_device_config_live_show(struct config_item *item, char *page) scoped_guard(mutex, &dev->lock) live = gpio_sim_device_is_live(dev); - return sprintf(page, "%c\n", live ? '1' : '0'); + return sysfs_emit(page, "%c\n", live ? '1' : '0'); } static unsigned int gpio_sim_get_line_names_size(struct gpio_sim_bank *bank) @@ -1056,7 +1056,7 @@ static int gpio_sim_emit_chip_name(struct device *dev, void *data) return 0; if (device_match_fwnode(dev, ctx->swnode)) - return sprintf(ctx->page, "%s\n", dev_name(dev)); + return sysfs_emit(ctx->page, "%s\n", dev_name(dev)); return 0; } @@ -1074,7 +1074,7 @@ static ssize_t gpio_sim_bank_config_chip_name_show(struct config_item *item, return device_for_each_child(&dev->pdev->dev, &ctx, gpio_sim_emit_chip_name); - return sprintf(page, "none\n"); + return sysfs_emit(page, "none\n"); } CONFIGFS_ATTR_RO(gpio_sim_bank_config_, chip_name); @@ -1087,7 +1087,7 @@ gpio_sim_bank_config_label_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%s\n", bank->label ?: ""); + return sysfs_emit(page, "%s\n", bank->label ?: ""); } static ssize_t gpio_sim_bank_config_label_store(struct config_item *item, @@ -1122,7 +1122,7 @@ gpio_sim_bank_config_num_lines_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%u\n", bank->num_lines); + return sysfs_emit(page, "%u\n", bank->num_lines); } static ssize_t @@ -1168,7 +1168,7 @@ gpio_sim_line_config_name_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%s\n", line->name ?: ""); + return sysfs_emit(page, "%s\n", line->name ?: ""); } static ssize_t gpio_sim_line_config_name_store(struct config_item *item, @@ -1203,7 +1203,7 @@ gpio_sim_line_config_valid_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%c\n", line->valid ? '1' : '0'); + return sysfs_emit(page, "%c\n", line->valid ? '1' : '0'); } static ssize_t gpio_sim_line_config_valid_store(struct config_item *item, @@ -1241,7 +1241,7 @@ static ssize_t gpio_sim_hog_config_name_show(struct config_item *item, guard(mutex)(&dev->lock); - return sprintf(page, "%s\n", hog->name ?: ""); + return sysfs_emit(page, "%s\n", hog->name ?: ""); } static ssize_t gpio_sim_hog_config_name_store(struct config_item *item, @@ -1295,7 +1295,7 @@ static ssize_t gpio_sim_hog_config_direction_show(struct config_item *item, return -EINVAL; } - return sprintf(page, "%s\n", repr); + return sysfs_emit(page, "%s\n", repr); } static ssize_t base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 -- 2.53.0