From: Bjorn Helgaas <helgaas@kernel.org>
To: Ziming Du <duziming2@huawei.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, liuyongqiang13@huawei.com
Subject: Re: [PATCH 0/4] PCI: Fix procfs PCI config access issues
Date: Mon, 27 Apr 2026 17:19:26 -0500 [thread overview]
Message-ID: <20260427221926.GA198396@bhelgaas> (raw)
In-Reply-To: <20260414024544.2975605-1-duziming2@huawei.com>
On Tue, Apr 14, 2026 at 10:45:40AM +0800, Ziming Du wrote:
> Hi,
>
> As suggested by Bjorn, this series aligns the implementation of procfs with
> the sysfs counterpart and fixes procfs PCI configuration access issues.
>
> The first two patches refactor proc_bus_pci_{write,read}() to align
> with pci_write_config() and pci_read_config() respectively:
> - Rename variables (pos->off, cnt->count/size) for consistency
> - Remove rebundant bounds check
>
> The last two patches fix potential overflow issues:
> - Prevent overflow when offset exceeds reasonable range
> - Fix implicit 64-bit to 32-bit truncation in read path
>
> Link: https://lore.kernel.org/all/20260303193253.GA3817951@bhelgaas/
>
> Ziming Du (4):
> PCI: Align proc_bus_pci_write() with pci_write_config()
> PCI: Align proc_bus_pci_read() with pci_read_config()
> PCI: Prevent overflow in proc_bus_pci_write()
> PCI: Prevent overflow in proc_bus_pci_read()
>
> drivers/pci/proc.c | 115 ++++++++++++++++++++++-----------------------
> 1 file changed, 57 insertions(+), 58 deletions(-)
Can you take a look at this:
https://sashiko.dev/#/patchset/20260414024544.2975605-1-duziming2%40huawei.com
and see whether there's anything we should do?
From a quick look, there might be a temporary regression and possibly
a pre-existing proc_bus_pci_write() issue.
prev parent reply other threads:[~2026-04-27 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 2:45 [PATCH 0/4] PCI: Fix procfs PCI config access issues Ziming Du
2026-04-14 2:45 ` [PATCH 1/4] PCI: Align proc_bus_pci_write() with pci_write_config() Ziming Du
2026-05-03 23:02 ` Krzysztof Wilczyński
2026-04-14 2:45 ` [PATCH 2/4] PCI: Align proc_bus_pci_read() with pci_read_config() Ziming Du
2026-04-14 2:45 ` [PATCH 3/4] PCI: Prevent overflow in proc_bus_pci_write() Ziming Du
2026-04-14 2:45 ` [PATCH 4/4] PCI: Prevent overflow in proc_bus_pci_read() Ziming Du
2026-05-03 22:38 ` Krzysztof Wilczyński
2026-04-27 2:22 ` [PING] PCI: Fix procfs PCI config access issues duziming
2026-04-27 22:19 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427221926.GA198396@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=duziming2@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liuyongqiang13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox