From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2925E47AF69 for ; Tue, 28 Apr 2026 18:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401231; cv=none; b=M+MtUgGlIMT0/HvwgwzN0miyng/P3QEVkiNoo/xuTC5lx4ppU1+E2vB+glbZ7wsICxrLqM5ExK0gJlYsVgSmAvayLiLPjqcI5hyOya2hlVGtQLlJpBGIamkGOVle0X8Rmsv90ZL4ORmQqdeyo1YbdJ30hh6Knh12o+px/fstfuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401231; c=relaxed/simple; bh=0gYTXT5cwiHXgjhwQq7mPkQl0OAfMOcDPdrEdHjjCvo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BQ5ys3TOX4TSq/T/X82fqcI3Is26WC7wm3JugV4dYD2Jbobkx12fXbK5ogx5nfyz5WpWALWhukZytymDQZXpeVNifeB6khxMI2vuUMSiKdvFWGXQLwlFbm0omqYc+X8j+P8mIj/VKunaEz1zYEPW7ko9gmLRIVNwft88PphhKUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ozaf3kur; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ozaf3kur" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20157C2BCB3; Tue, 28 Apr 2026 18:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777401230; bh=0gYTXT5cwiHXgjhwQq7mPkQl0OAfMOcDPdrEdHjjCvo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ozaf3kurp+MOugnbZiHhV4mumqMt0CWIXc3TmjJz+9k3+HFT50AoOX/4/pjC+sMeU 6hN1sgaklIpfra0+9/dpdNEvF2/pO75kLMChMyWERY4Fcnca3z8+a7XsxgKWInEK45 yueKt+AUXhou39YqbG2SGlKBzuSctYulIb4cCgY/8mVLjHX6eGwp056dam7wl19pyy fptxJnUvTrYJlj/BlO612zFx70bZ5/s/YpSyc9GsoE4iDnqxrVwp1R54/fk4+CfJrw /f26taxgq2kPyPP0mDmWn30WCyvs1XsHnebSIHBmftzeYJ10iQStSZPZE+d1Kw1rbR SG+KYDolsM3vA== From: Sudeep Holla Date: Tue, 28 Apr 2026 19:33:25 +0100 Subject: [PATCH v2 01/11] firmware: arm_ffa: Check for NULL FF-A ID table while driver registration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260428-ffa_fixes-v2-1-8595ae450034@kernel.org> References: <20260428-ffa_fixes-v2-0-8595ae450034@kernel.org> In-Reply-To: <20260428-ffa_fixes-v2-0-8595ae450034@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 The bus match callback assumes that every FF-A driver provides an id_table and dereferences it unconditionally. Enforce that contract at registration time so a buggy client driver cannot crash the bus during match. Fixes: 92743071464f ("firmware: arm_ffa: Ensure drivers provide a probe function") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/bus.c b/drivers/firmware/arm_ffa/bus.c index 9576862d89c4..601c3418e0d9 100644 --- a/drivers/firmware/arm_ffa/bus.c +++ b/drivers/firmware/arm_ffa/bus.c @@ -26,6 +26,8 @@ static int ffa_device_match(struct device *dev, const struct device_driver *drv) id_table = to_ffa_driver(drv)->id_table; ffa_dev = to_ffa_dev(dev); + if (!id_table) + return 0; while (!uuid_is_null(&id_table->uuid)) { /* @@ -123,7 +125,7 @@ int ffa_driver_register(struct ffa_driver *driver, struct module *owner, { int ret; - if (!driver->probe) + if (!driver->probe || !driver->id_table) return -EINVAL; driver->driver.bus = &ffa_bus_type; -- 2.43.0