From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 296CE47DF80 for ; Tue, 28 Apr 2026 18:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401242; cv=none; b=InGuQJk6u/XAUFinuz8PE3p2vccZvETghn38THwYmyFV2ZCejEcYRiR4njTXQhe0PYQeeII+nDond5nSxzeZFeufBhfraIfUzcsg0E307XDEDA90KvN6y8CkrMF/BlzdwCk5Q4bp4r0TVXEW6diUhXBhi/ouWjTUDpl5z8z7nos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401242; c=relaxed/simple; bh=C+4w7EMpQKOpxtLgrnXYA5pSlXeRslLcugB75oDKjPM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aqUIdvvaB8yRS0JKutdF+Ghj3USMbYkgowCx6Pay3LnmGnmF/081GZmnifKi1man31wJMXJguT1MTQIXOuKps51qHsi+1gr3noLsnbQ8nfsJG9svVXPmU5wyscbTBdYT8rrcE+YE/5u41ZujPWapOEULNShQeLERVINK7YmMDHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bn3VpF3J; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bn3VpF3J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56222C2BCB3; Tue, 28 Apr 2026 18:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777401242; bh=C+4w7EMpQKOpxtLgrnXYA5pSlXeRslLcugB75oDKjPM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bn3VpF3J1jinjnSX1CFpVa7iHxLyRW6wR+pwi2XsaBQUoQs1vMrk7iTc3NrDBw2+a CVpmuQ+maQLwD0488fA8mr7fZ+MPU5UnQZJfpjNYNPCJ7O2S90MpK20WadiA+SUL+K CYCU+2p2X7g/TEq9i2Y/qQYt8pOvYG7q0MROAAcULsYBBfB83jFwaQUPW/G/cr1s7v 54QJ+6pXZftz3A60sWGA+EE03joBcfS5D3yjinPWJFIgc+sJjRjyiZ2vF9DPOQ67Pr y1T6U97hJZWQinJUWuhqSh3GXkAcI+fWR1aOJOrERomP6hY4KKRPA0n1BnMGmokJuS SQxtEAMmUHepw== From: Sudeep Holla Date: Tue, 28 Apr 2026 19:33:35 +0100 Subject: [PATCH v2 11/11] firmware: arm_ffa: Fix sched-recv callback partition lookup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260428-ffa_fixes-v2-11-8595ae450034@kernel.org> References: <20260428-ffa_fixes-v2-0-8595ae450034@kernel.org> In-Reply-To: <20260428-ffa_fixes-v2-0-8595ae450034@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 ffa_sched_recv_cb_update() used list_for_each_entry_safe() to search for a matching partition and then tested the iterator against NULL. That is not a valid end-of-list check for circular lists and can fall through with an invalid pointer. Use a normal iterator and detect the not-found case correctly before touching the partition state. Fixes: be61da938576 ("firmware: arm_ffa: Allow multiple UUIDs per partition to register SRI callback") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 2e9820395162..7bf8555c09da 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1209,7 +1209,7 @@ static int ffa_sched_recv_cb_update(struct ffa_device *dev, ffa_sched_recv_cb callback, void *cb_data, bool is_registration) { - struct ffa_dev_part_info *partition = NULL, *tmp; + struct ffa_dev_part_info *partition = NULL; struct list_head *phead; bool cb_valid; @@ -1222,11 +1222,11 @@ ffa_sched_recv_cb_update(struct ffa_device *dev, ffa_sched_recv_cb callback, return -EINVAL; } - list_for_each_entry_safe(partition, tmp, phead, node) + list_for_each_entry(partition, phead, node) if (partition->dev == dev) break; - if (!partition) { + if (&partition->node == phead) { pr_err("%s: No such partition ID 0x%x\n", __func__, dev->vm_id); return -EINVAL; } -- 2.43.0