From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D89347B42E for ; Tue, 28 Apr 2026 18:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401232; cv=none; b=ldp/9fg1VjlMYQ1ZbtqvNJih7Ht2zIicMLBXYTZI7aU7PN3D5pzEHF4dIQekUHSXPXwqSj+5+gmHxqf5Qt/Fw/kYjwXb9ZT0zkl0+2WaG4k6UraVpvMA3cbuNUeLPDv2AmE5gJQJpLq++nPlUNiL1d38OBFPySaapspGuKJCLBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401232; c=relaxed/simple; bh=c4BcYMZ0KWMorH09+B5vNrAhFQ4rDIDYqWvY5VR5Gws=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=awrpABr8HvCK9CdOTLbozt+CWHzKOKk1+jEHXJ1OALIngSVW6lFicnfwEIeGthfS8MtFVui+F8/Ret0IrbDiogJPMEMjeYJlvWb2hmPSgdCBYqtA31nC01UKn0McpWhLiFF03PpOwm1TPO/Fxx0scRG6SpRGwCxTabdM6b7nUJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PizZMWo5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PizZMWo5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36F85C2BCB8; Tue, 28 Apr 2026 18:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777401231; bh=c4BcYMZ0KWMorH09+B5vNrAhFQ4rDIDYqWvY5VR5Gws=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=PizZMWo5iF5mC7v77JX2jAYXoibEaCFXb9qH/C2ZiF7e2nBNkAFo137PUezHHAqZG HWLqvgwuuQ7e2CK6X2b75VVmxpTVmXA9/pxWLASnmzN05XFINbsyP47f0TM77hYK51 lCC0/O20y4N9+YIDtzNJTnfFx5SS8FTfNT7gv0bEHmyomkCmLlzBSu3nu9R6vsEXFG DQeMQZkLNgO+uynrqKl6xbVG1W7FEsfNbwK1at2qTvLYAtvpqRylboe741wp8cPtBU CBXGIeZL9ioYF4WNDL7Yr4vlVAFB7G31XOVC4SS3ziycePGTWM0KwvK0iX/UyewmWW h26+M4fWtjoIQ== From: Sudeep Holla Date: Tue, 28 Apr 2026 19:33:26 +0100 Subject: [PATCH v2 02/11] firmware: arm_ffa: Skip free_pages on RX buffer alloc failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260428-ffa_fixes-v2-2-8595ae450034@kernel.org> References: <20260428-ffa_fixes-v2-0-8595ae450034@kernel.org> In-Reply-To: <20260428-ffa_fixes-v2-0-8595ae450034@kernel.org> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jens Wiklander , Sudeep Holla X-Mailer: b4 0.15.2 If the RX buffer allocation fails in ffa_init(), the error path jumps to free_pages even though no buffer has been allocated yet. Route that case directly to free_drv_info so the cleanup path is only used after at least one RX/TX buffer allocation has succeeded. Fixes: 3bbfe9871005 ("firmware: arm_ffa: Add initial Arm FFA driver support") Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index eb2782848283..e6a051b20cb7 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -2067,7 +2067,7 @@ static int __init ffa_init(void) drv_info->rx_buffer = alloc_pages_exact(rxtx_bufsz, GFP_KERNEL); if (!drv_info->rx_buffer) { ret = -ENOMEM; - goto free_pages; + goto free_drv_info; } drv_info->tx_buffer = alloc_pages_exact(rxtx_bufsz, GFP_KERNEL); -- 2.43.0