From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A29651FA272 for ; Tue, 28 Apr 2026 04:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777350633; cv=none; b=U16vY/fGTOLNAToPYndLVyCYSxP8vToUj5Vqpd86BSst/5zSSP4W053X6CIUB2JRjk9wEyavfw6Gc3gV/hHe2EvriQncrOnxGqEM5u3uWLaSw/N+F5ZWyKbtqaYEwGZeqw4+ZvcnxPVeqUv8cQ3TPdSlPUluNDGyD0NPhw0kK1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777350633; c=relaxed/simple; bh=lAw7ByP8NQVMmaHIXOiQsoholucbwdEXesa5oUVmQ8Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jyWOWRZX+/aAsL2tAq2HgLC1szFPH0jXjQ3wP8zIhqXQcItdl4yeLIZTvbYUdbEccvM6iKoI6em13JbwbrX58XaNVZZGsm9TaCVyxCZPW8tK3uwNmljLR9GIe4moNI1GeuWoApOCbvSdDWn5k6sQGoi4ylTXAI0i1nO2R6joIY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQlENrCX; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQlENrCX" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2c15849aa2cso14643074eec.0 for ; Mon, 27 Apr 2026 21:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777350632; x=1777955432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ncax1hLXhL4s1JyqOrJU1m4Lr9wzrisl50UIYascFK0=; b=aQlENrCXn85RFWbqrzARRaYZB7zgMjyian1M+20tixrYhS7Zqy2BKzritWOpeEkiax QP4he3yXFa6XxUMUzhc/PoZ68AC+Y0Ij3+QumCS2NBMmv8WNg4C+FMPyZ4xYr6uVkQGr x9HGb8xkFnoRHGbIsm39k6WHDRaybVD0oPHO6CKELXue+l/gvHHepxFfwlx0HWXZNay9 f1WcpiuXA1/Qc5KuzX+0vHJNwHhckdChc8598Kbi0fdJ0VvlbpWSrJK4LpKfbkM/wCY/ a5xsjR4DnkaKshyex4HhIIkT5Q8vX/yMzwnZLp4pnwE/V4AtCv3JYtbVVBnL7BDlJERf wK8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777350632; x=1777955432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ncax1hLXhL4s1JyqOrJU1m4Lr9wzrisl50UIYascFK0=; b=Afp8DdwDa855cyVh+1Ka9ZRKqeRRM7JxTxwF2i9YFaQwFNVBhUwD57mu0pS57Ey6Zy 4rNVSXMoXJW65E7CEUYgHbByBgwCnI/V3DSiQu6NndFUYibACndQL9m6DaISO6vnhXGk DkpbUHbYwWBDqapBU8q3MYM1hBFtKfPQ+eUBIiIIR7Jh3fQ+JFrPcywApSKZ1i5DD3hQ A2EcCbkc7G+rD2sAbK7L/xSmGO/umj7nlTYJWfAp3hM/+IGCmHytJ2Wtt6zCdyceeVl1 mhhplDAwI249WC41dhAqLDjncZir8PqjFkg1HuizXgjYPhXnk0HAoqE8+fk+TJSu9Ks1 qEbQ== X-Gm-Message-State: AOJu0Ywnr5Jwl1ePvrEQRtvackzJyaSMLlkCSFJjatAxj7Iby1kjmUxa Gs+VD6ms788S4xVhmriAtRSQY2F12fbCxZEg2FfBt0EyZuQH7ul+E+G1 X-Gm-Gg: AeBDietHOwCe9A33tuVlB6aB8c4f9zVJkDG1LXEBXYUlMkQzcRufj973mY2TcYo5cTR 2k1SqCAK592LTwdkfMkpJCSOPmxIQS65EAUoogp8uSCeRmj+57v5foBP3NQMPsRCfRAR0TfKMVr 5qe+rwXmXDQ/Qjak4sVm4PuhPzBfGn3jtyO3vXbY6krbjm2bkVf4xCSczR44lY6Sw9OeILufJ5F RPUag4LzkFeouZ0F4aWKbItcogHClQZUTV8Bshx2cuhjOH6+rXLT/Um+doD6jL7+NyTSp7rWGts 20bAQWEwJq71qjIN66I7xQmcDopjvITRRyM8ExNrGG8wptkRh21dfvrHKS16n63RfONUzHKO7/3 dfjqXfuoZhd6WH6Dd1M4R/9yF4ETbJHpTjB6G5yT6s4NCb1tLWgDUcOnijXyscDk5akBHGT4cIE fm1wOymbEP5uhi9Rc+T6zlCJVZG22fvuYsfbEy X-Received: by 2002:a05:7300:f18f:b0:2ea:4228:ab11 with SMTP id 5a478bee46e88-2ed09fde4cbmr702624eec.3.1777350631199; Mon, 27 Apr 2026 21:30:31 -0700 (PDT) Received: from soyboi ([2402:8780:1073:993:9321:304a:9347:5e0e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ed0a13eaafsm1283826eec.28.2026.04.27.21.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 21:30:30 -0700 (PDT) From: Robertus Diawan Chris To: jpoimboe@kernel.org, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH RFT] objtool: Validate find symtab in elf_create_rela_section() Date: Tue, 28 Apr 2026 11:30:26 +0700 Message-ID: <20260428043026.160465-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit find_section_by_name() will return NULL if the section is not found. If the symtab section is not found, using the return value of find_section_by_name() directly will cause null pointer dereference. So check the return value from find_section_by_name() when finding symtab section before using the information. This is reported by Coverity Scan with CID 1445573 as NULL_RETURNS. Fixes: 627fce14809b ("objtool: Add ORC unwind table generation") Signed-off-by: Robertus Diawan Chris --- Currently still not sure _when_ symtab section is not found. This is reported by static analysis tool, which can be wrong. I apologize if this turns out to be false positive. tools/objtool/elf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index f3df2bde119f..ce7246d3b302 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -1625,7 +1625,7 @@ static int elf_alloc_reloc(struct elf *elf, struct section *rsec) struct section *elf_create_rela_section(struct elf *elf, struct section *sec, unsigned int nr_relocs) { - struct section *rsec; + struct section *rsec, *symtab; char *rsec_name; rsec_name = malloc(strlen(sec->name) + strlen(".rela") + 1); @@ -1654,7 +1654,13 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *sec, } } - rsec->sh.sh_link = find_section_by_name(elf, ".symtab")->idx; + symtab = find_section_by_name(elf, ".symtab"); + if (!symtab) { + ERROR("can't find .symtab"); + return NULL; + } + + rsec->sh.sh_link = symtab->idx; rsec->sh.sh_info = sec->idx; sec->rsec = rsec; base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 -- 2.54.0