From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31418355F36 for ; Tue, 28 Apr 2026 11:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777375997; cv=none; b=b7308vzUsJnc/5Byq51uKiXQFHlllFs+mDDgOFIN6OfU1JCkVrrRqwPgzFdLWWaWznlOM8QdS0tFfkxTyNvTIDPtJOczkw8Swy0UDQSqpn+XHBJsDi84N5sVUMcCLhA0iw7xe9CuVuwdoopuLu20yWsRvVJcd7u9nDSlvbkMf74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777375997; c=relaxed/simple; bh=HfA2jm2PlyzEpeCPUBoKS49ADYLzApf6IHW140CSIEU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SRp4z5LbLrCH2Z0bCstjFDmR0iwSP5o/xqgAgCHj87gcBE0xVF7qkHE4M6QmdxaSKrA3jssnCsBCbStc8FbQrZ/oMr8IXcMWNOz76rcWSHsToZwoJkdJhXVJzqw3b9ZVBG1z4FyCK2KyopntMg9N5L8Es5hug19sXBUBHwVnNFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b3J1KFvz; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b3J1KFvz" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7de4e6c5a30so3788625a34.0 for ; Tue, 28 Apr 2026 04:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777375995; x=1777980795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=snUsLloMWiOv2ToYV4UGwd0LNmqsP/o20Ldn23wlG1A=; b=b3J1KFvzYRxaeRqoOXpKbfzyDlgSDJMJDO+VYhHEZKTLZ6RS5UF7ZMRTjvVDAnBFtp ms8yyDEv45WJNYCb3JZUUCutcmJmRb1mhgmsyZstY1YdjXp0RZs0yOGqfSALvNoWHa3l aAR9V1gSyeavQ/Tdvoicpa6Fgs2RotOsYbfpPd97iDpmm8kDNrexu4Oc940/lvoe5mXw IDqst+c8gIb2AcQuFSH1zmKvhL9GD4Q5bJ7nNdIVp+39gdgiWNQYvOEVepEHJMU2OVVa WXcGOpkKyzU3auFYG9fsJjJSpwOXrwDXM99k4CpozeG0TZWkp6E6pf2P30IHFHiGzt40 aOFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777375995; x=1777980795; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=snUsLloMWiOv2ToYV4UGwd0LNmqsP/o20Ldn23wlG1A=; b=Cndul/L8GZDB4+MDHC6TmCdqwUCUFbsgJjbwJO9hfbUlhY+9nQ16xie+R+J9h234FJ WLQ2wAF1VWY6n7BEZacXm0i8LCxaxK/0h3UpLwfI6T0GgaIauWcj0cbUY3hFEET+xggF E8NM/1WOb/DgfqbVJEEnN9XeRIWOBxQHDA2ykMzeoyyuFZRMtFfeAAUzIK8QKU+zdS1Q Tu42roNpjwvEN0jBgIbD+aQaGa67ruRjSoGx48KI2bB3aWbE1G7bEP7WKGS9dKxAqO0T n/z8dJFYuW4i+SQUFL7zimAd/S7+ARl3YOykZ9JWHmUz9M2ChFRFV2hPwIoUMRo4i3rj 6nGQ== X-Forwarded-Encrypted: i=1; AFNElJ8Iw9Ce0cT39BWX+ipG22LALT11xVOc0QmPw5yzJv8vejMQDyq4+xLysDJp5kg+BFeNhWWQ7wLL9veJVqs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz53TemSxj5ZLhRpRm6vdo/iBX0hVzMy9py1p3aBq1wiwkFOxxL bd/07ysBkk/SwQDDSm5a8Iqb6qBKZnL9pP+No9vxRVtY9XYCo/IlMoyl X-Gm-Gg: AeBDiet09meWPVLTaw1OxA3/LB+lpT/pynn5U4nCukiFTEDWRWBefPj9+8jBm3MTBvw tRjAfxJR9GRs/Yyk75VsvwloEzOShbAUW7K/2FZ3cC8eFcQAvO6uP6HTm4xAXOQKEmISGJBIuK1 UDpzz8IbzjNSJflW6Nitsx0TZ8InuGHH0ieWRpZ+fbeR32llRP+kcLpy5zyan4H00m5Q882/Fyx Hjnpcne8Jv1JBCnGvDH+Ana81Ua69PLv2fg+W6GR+43x0eaiZ0R4J73FVir2FakCWoEY9TuUdwt Oj3IdvH1QAwhOjUVpz+pzP82BWgnWK2+JgYXkoKib3RZ/iGoJnxMhsbQkhNngP6e4tNKuht7LWp BPL46r6RwdhsKkYGe8dQhPlPs3VwVMLzDTg3PMqauiFr/RY5bGQYv6qQYVoBrrAV+tddDgAguiW VXYYLcBfJZ2ib3PqMuhmtFKYv2iY+6Ig25UGddGKpCaIhDH/EszFqEMlylVy1Gw8x9zgZZ X-Received: by 2002:a05:6830:64c9:b0:7d7:f15b:bdcf with SMTP id 46e09a7af769-7de9a185379mr1495830a34.28.1777375995058; Tue, 28 Apr 2026 04:33:15 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7de9866c62fsm1550989a34.13.2026.04.28.04.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 04:33:14 -0700 (PDT) From: Maxwell Doose To: linusw@kernel.org, brgl@kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] gpio: sim: Replace sprintf() with sysfs_emit() Date: Tue, 28 Apr 2026 06:33:13 -0500 Message-ID: <20260428113313.9070-1-m32285159@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace sprintf() function calls with sysfs_emit() in the configfs show callbacks. This will help harden the driver and will bring the driver up-to-date with more modern functions. Suggested-by: Bartosz Golaszewski Signed-off-by: Maxwell Doose --- v2: - Rebase commit onto tag 7.1-rc1. - No functional changes from v1. v3: - Add missing sysfs_emit(), caught by Bartosz Golaszewski. drivers/gpio/gpio-sim.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index e19701c2ed67..b1f31861f40d 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -695,9 +695,9 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item, pdev = dev->pdev; if (pdev) - return sprintf(page, "%s\n", dev_name(&pdev->dev)); + return sysfs_emit(page, "%s\n", dev_name(&pdev->dev)); - return sprintf(page, "gpio-sim.%d\n", dev->id); + return sysfs_emit(page, "gpio-sim.%d\n", dev->id); } CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name); @@ -711,7 +711,7 @@ gpio_sim_device_config_live_show(struct config_item *item, char *page) scoped_guard(mutex, &dev->lock) live = gpio_sim_device_is_live(dev); - return sprintf(page, "%c\n", live ? '1' : '0'); + return sysfs_emit(page, "%c\n", live ? '1' : '0'); } static unsigned int gpio_sim_get_line_names_size(struct gpio_sim_bank *bank) @@ -1056,7 +1056,7 @@ static int gpio_sim_emit_chip_name(struct device *dev, void *data) return 0; if (device_match_fwnode(dev, ctx->swnode)) - return sprintf(ctx->page, "%s\n", dev_name(dev)); + return sysfs_emit(ctx->page, "%s\n", dev_name(dev)); return 0; } @@ -1074,7 +1074,7 @@ static ssize_t gpio_sim_bank_config_chip_name_show(struct config_item *item, return device_for_each_child(&dev->pdev->dev, &ctx, gpio_sim_emit_chip_name); - return sprintf(page, "none\n"); + return sysfs_emit(page, "none\n"); } CONFIGFS_ATTR_RO(gpio_sim_bank_config_, chip_name); @@ -1087,7 +1087,7 @@ gpio_sim_bank_config_label_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%s\n", bank->label ?: ""); + return sysfs_emit(page, "%s\n", bank->label ?: ""); } static ssize_t gpio_sim_bank_config_label_store(struct config_item *item, @@ -1122,7 +1122,7 @@ gpio_sim_bank_config_num_lines_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%u\n", bank->num_lines); + return sysfs_emit(page, "%u\n", bank->num_lines); } static ssize_t @@ -1168,7 +1168,7 @@ gpio_sim_line_config_name_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%s\n", line->name ?: ""); + return sysfs_emit(page, "%s\n", line->name ?: ""); } static ssize_t gpio_sim_line_config_name_store(struct config_item *item, @@ -1203,7 +1203,7 @@ gpio_sim_line_config_valid_show(struct config_item *item, char *page) guard(mutex)(&dev->lock); - return sprintf(page, "%c\n", line->valid ? '1' : '0'); + return sysfs_emit(page, "%c\n", line->valid ? '1' : '0'); } static ssize_t gpio_sim_line_config_valid_store(struct config_item *item, @@ -1241,7 +1241,7 @@ static ssize_t gpio_sim_hog_config_name_show(struct config_item *item, guard(mutex)(&dev->lock); - return sprintf(page, "%s\n", hog->name ?: ""); + return sysfs_emit(page, "%s\n", hog->name ?: ""); } static ssize_t gpio_sim_hog_config_name_store(struct config_item *item, @@ -1295,7 +1295,7 @@ static ssize_t gpio_sim_hog_config_direction_show(struct config_item *item, return -EINVAL; } - return sprintf(page, "%s\n", repr); + return sysfs_emit(page, "%s\n", repr); } static ssize_t @@ -1335,7 +1335,7 @@ static ssize_t gpio_sim_hog_config_active_low_show(struct config_item *item, guard(mutex)(&dev->lock); - return sprintf(page, "%c\n", hog->active_low ? '1' : '0'); + return sysfs_emit(page, "%c\n", hog->active_low ? '1' : '0'); } static ssize_t -- 2.53.0