From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F62042B747 for ; Tue, 28 Apr 2026 14:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777388273; cv=none; b=IRpkA0l3p18Z2FbshgfGSw0AuH+zuhoJuhePBjsAsxJhc1wdCGw2WyQ8DIci3BNO6ziy8xdvkUuz7RgykIofk3pcZi6nqFeAhiuk44ErdEFZSqjUtD3K1GNxBFjp+V3HikdK+3Yu8ysm8yqFBlhMQImuo4IuNv7YOW5HlnnMSME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777388273; c=relaxed/simple; bh=vUmBN7ysT7cMsEZ/akVA56U/xX3hVHiiL7r5zeDPk2s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Bq6K8ZYitV0A9gQiCEQZ8QZ7qKmpVs3Gsi13OwTtXbJWYRSJTNt42iN1fRgj22qjmqTeyo22vircngdxJ01dk0NctUQ4nKk9e7jGpMWJJ6awX/ZtkuKqqnvVrfPhNBL92NdjRB8kOKeok/N86QQYmgqWAFsivRoLR6tKFfTHb2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LxHi9u/j; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LxHi9u/j" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2aae146b604so77201155ad.3 for ; Tue, 28 Apr 2026 07:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777388270; x=1777993070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bFUk8datTypjawkPIlOc1SYezMUIN63Uxev+tDnIiuU=; b=LxHi9u/jjQybejxpq3qK09pvcP4BNVP6Yw05dcVN7u/a6nPnmfrGLZaHXOkWSLnkc7 2MXZACX+1edZcrMTdNSxQhwpe0I2GJ4WFvvy60bOZ3y6V2tmXVcs1z+rSJr8DGnYa7ao e4jA5jsCOBZ9ZzAMFrTxn0OekyjaEwwVDmIAj5yTkpApwItYwMEn3LqWwtNggBZ9O5+G Bb7uxrRdAp2UHC0/MYuTVtn9GxvI+NGKwTedhTmo2qqxmrNlonRAoaVlXioDzwfEZH3o h7+FUfKFnH3Y6eReBXlf6IMia0QH23zDhFMxu/dRNOe0e8hbL2vsLLBVO2x4FfGtUISx L2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777388270; x=1777993070; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bFUk8datTypjawkPIlOc1SYezMUIN63Uxev+tDnIiuU=; b=EMmeUJxbg6oKx8HD5EAFDT41ufeHABGewqJ/sSsYqQnpvdzAy8dBlM3qFbcnutVJS3 j53npsVxGAXV5k2v3uZ65uGJi2ZpGHHNsUpqgxdXnr0RNdDWi101a65NppwyTLpK0CPE ygZUAbME6WMypFO3r0cB2aLJ4gcEpB8rRHwHl/vxAqSbE2cD+sVN/PBIDRs5cIDvYHta Jiw+plBtITf3fM1V/dglXNpyJDV0Sf7DFOvfF2YDm4fGQiS3MIXnofMYwea0hQC7t6ts PlsRh71j2mEkcW5qO+ZDsEraMMeP5ZSia3yEQLjBxndCV+y0j/rPKrx4Sccc93cljuFI PnZw== X-Forwarded-Encrypted: i=1; AFNElJ/khwOQOyLpOEh+G1l6fpAgaAIIVZbfUvaNHSen8+a7TNAT6dROGVoohv/vE4ysyVlpZWsiRPIV1CSkpmk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3SEnRTpFmbsiVTxk5yysDdLFsgcwzBWhRcI5H3IRpfqmgYAN3 KAV+Wei/6eVQnddTMBPdyfCusJfLIztXsWsoGUYoyQ8TE+IxSofOUIii6dtZum+F X-Gm-Gg: AeBDietBKtbbBcsicaYOLAMUpiDzryLgKfNtIw/uen+O+Rl4Gr6EShXId8ePuO4mKIv nfFXCB6A64vWPDdnyLQkMiHWQwp+dyyWbbpnbuRNgOd9xJR154V1cGP0soBUr+7Lv9pLHkSpS80 vEBbriiz6h4hNBfh6DNgrJTTPfY+ViIrW3GMc0k41Raa8osl8RtR8vEnVmV0Tg2AerS0Ucz8Abf kzhMSvZn4qjq5GThlmqnfJ5vSB7Gy2Fm107DSmr91f9/js2Z11CIXCT6SC6CBpoQYLDRiDD5tdO k8C1PflXZQ3kImDYfA7lYH/nA4ueNFhpqToz/Ro5pwa8sbvxvqAlgr5YruEEVWKZUCOsHQhrenu SRl43dMNPhB11/1b8L7YI4DRAPTzLHFcUHpmrhZKWW0sSAmgu+a/I2jGybfvKJtbQ/IfrBU2vBr IeNo6eTbM0yMnAD83y1vzwWGvqpLcIyAiJg0ENM5CV X-Received: by 2002:a17:902:da81:b0:2b0:62dd:3a80 with SMTP id d9443c01a7336-2b97c4396e6mr39454135ad.17.1777388270383; Tue, 28 Apr 2026 07:57:50 -0700 (PDT) Received: from lmao.. ([2405:201:2c:5868:93f1:2c21:e056:f551]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b97aa7b858sm28796665ad.8.2026.04.28.07.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 07:57:50 -0700 (PDT) From: Manas To: jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, rakshitawasthi17@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Manas Subject: [PATCH] net/sched: sch_dualpi2: Add missing skb check Date: Tue, 28 Apr 2026 20:27:30 +0530 Message-ID: <20260428145730.26375-1-ghandatmanas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A packed is dequeued using the function `dequeue_packet()` but there is no check to see if a packet is dequeued. The assignment is always considered as true resulting in null-ptr-deref Fixes: 8f9516daedd6 ("sched: Add enqueue/dequeue of dualpi2 qdisc") Reported-by: Manas Reported-by: Rakshit Awasthi Signed-off-by: Manas --- net/sched/sch_dualpi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_dualpi2.c b/net/sched/sch_dualpi2.c index 241e6a46bd00..e360bf16d617 100644 --- a/net/sched/sch_dualpi2.c +++ b/net/sched/sch_dualpi2.c @@ -588,7 +588,7 @@ static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch) now = ktime_get_ns(); - while ((skb = dequeue_packet(sch, q, &credit_change, now))) { + while ((skb = dequeue_packet(sch, q, &credit_change, now)) && skb) { if (!q->drop_early && must_drop(sch, q, skb)) { drop_and_retry(q, skb, sch, QDISC_DROP_CONGESTED); continue; -- 2.43.0