From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 955C0282F27 for ; Tue, 28 Apr 2026 16:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777392308; cv=none; b=ENF4DlTeXqWM6krDjOxN0Y3zuDEvf0XHeAcRb/5v8TqbKFy+/aUsZI4pbWVQHmAGqs427XKIuJ4L35siPvwYzJiwefVs9FQpSSU0Rp5WOnLwxdn2sKzSBgX+79UnIe+0N9ZHnokSer22F6t6y+3tZMMplPmlenvf+sy+umOMSCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777392308; c=relaxed/simple; bh=unb613ArUtHNmbYG8ncLfxpVXNyrrwHjCOXYm0rXdKk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FNimsl4uWrwhzd4GExYBekFvERJMz2DmWNMFMe2i0BoIVrgGU/DJQrh6VbQmumPjPEd2fDcyjrqmc7W/CrXo0eEa3R7AnpTFddyQYk3zilD0/4HbU7orEs0HzyS+8G8IX16NiW2OEpaPDvGR2HCpfHPHu4wkqDRpHUbK5/c7qCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IpaFQ1FM; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IpaFQ1FM" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43eb012ac4fso7011713f8f.0 for ; Tue, 28 Apr 2026 09:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777392305; x=1777997105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q8TpQ2z2elgGgJCbPwcJ/dLg9MFQkIdo6qMRqpy61TY=; b=IpaFQ1FMizYsSaYtUOefoPFHU9+0uODCPtahaq4g5P5Fsl3JSiYNWvU2glbMlUG66q PRhb7KgPu1Tn+ekPImn2CdBQTIFs1pExZObzCwihsjI5CECT4Jjn678StptPXG050Yk0 23Y0ne43zrQ+wH6ar+pOG/E3mMlf0I8aMcnqVrqlAtOWQYC1V0XvLeQwAl+Rqci7dPu7 QpXsB+5Tba3l5bZrvXA2w4zHMcVB8ajyScCjB5EDdIVlus2D4ZfZDOwZ/YiaAz9IMcQ1 rxEanoiYlFWjAQBwNTai6+cLsMImK6PdtjhoOwLfipN+X7JluJeWVJgYipMysJxkvIUQ FT2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777392305; x=1777997105; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q8TpQ2z2elgGgJCbPwcJ/dLg9MFQkIdo6qMRqpy61TY=; b=qXf4yV5YxLHR73VDjhQMpRAmZAEUIcLVoNJRbVgh2783I8CIgL/3zPYkgsiKWZvtf6 7hzFasyenIml4jSbbKZa9eLRGeiuZZb/HH4YI+pfJwPo5+DDLKJZY+BF2YnzjTMGWyhm MEfNfczSJ325il2hO9PYuPIHcckM7jNr0vd6OJ2fhMUL2z5kPjMEgzv8gg/zQ81uDFzg +p+7fly02TXsUWWR/G4ogFPT3bK0sviYtgZgX7P18f5up/guVjsVojLzAYdgTn8Czydb +Ldw7RaByu8nDL1+t4waWtTMWahAm82teegDvFWr9Hg2Yl9+wblNXydRdEqr2U1+gqWO 7ohw== X-Forwarded-Encrypted: i=1; AFNElJ+XLIY7Xv//GBlWikNNGUxZQxFyc5U2MfwBvHIOnOmsZcCTPKpMNmNM3yq4yLsRWNd8AO02si2G8ThDvRA=@vger.kernel.org X-Gm-Message-State: AOJu0YwRwmkt8oZ2UAsOme7OQ16X++XaRRLij+S8idEFXDiLatBK94JY lgp2l5CkFmYIqWdX9+OcxekUgFBMLlrwB2RGAJmi840gESnrd9BzKiNW X-Gm-Gg: AeBDiesYllBVoPSBlx4CAbC7uxtF91F8xUV6/6NhgtNPQV3oi7JQqaRNjZE6RvJy/zK frbi/WmhxYKqvcMHc66IRiZbwen0jG943dxyfzYhTtt2C2KTJ5ueV4dJhxDRJuhjXwV5/HOogmx udioIv4QWUBGV/8UWrG/x52x3o+mxb69sKMHhV5NyCZzXI6E3s9pTWb3tKw8g+fuXzucrxqU2vT dkxtZ2+DzGovM7FbngPD7pjkskmQmaSI7zk0RCPrezyOOMhOZUnzngNfir8Eku5oRXKDeq1lgVb Mb3+/jPyhhmI0mij23+vqEkPqzcAV4rBJBpDsvC71W5tCHd1ICtvMmIFsvnvqzzqmaSctjNuzA1 0rr9oLpIGaFsZHk2rOMulmRelnkiA9dToQF+mjUqhygtqDHY0R0kOY7frzktu+Zx6rnyYZlCLbt 68sME+sfQBZkL0mO/zcuMxwGu1tr1JsASkrAyO+qVZbciIWuSoZ9DhetwuIbX0n47lnDQxTlt4B Ev7sI+nMddUdNioMd4wY90yOqQr6XZPRROzZrKopzvNK9pLKaaIv4Q= X-Received: by 2002:a05:6000:2287:b0:43d:1c21:ead4 with SMTP id ffacd0b85a97d-44647dcf861mr6912906f8f.18.1777392304584; Tue, 28 Apr 2026 09:05:04 -0700 (PDT) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4464004edc8sm7532923f8f.37.2026.04.28.09.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 09:05:03 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH RESEND -tip v2 1/7] x86_32/segment: Always return correctly zero-extended values from savesegment_*() Date: Tue, 28 Apr 2026 18:03:35 +0200 Message-ID: <20260428160443.3593331-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On 32-bit x86, reading segment registers into a 32-bit type can expose undefined upper bits on older processors (e.g. Intel Quark X1000, Pentium, and earlier), where bits 31:16 are not defined. Introduce __seg_return_t as an intermediate type for __savesegment_*(): u16 on CONFIG_X86_32 and unsigned long otherwise. As a result, __savesegment_*() now returns correctly zero-extended value in all cases, avoiding propagation of undefined high bits on 32-bit systems while preserving existing behavior on 64-bit. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/include/asm/segment.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index dbd90fede5e7..070ed87063e0 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -341,13 +341,23 @@ static inline void __loadsegment_fs(u16 value) #define loadsegment(seg, val) __loadsegment_##seg(val) +#ifdef CONFIG_X86_32 +/* + * Bits 31:16 are undefined for Intel Quark X1000 processors, + * Pentium, and earlier processors. + */ +typedef u16 __seg_return_t; +#else +typedef unsigned long __seg_return_t; +#endif + /* * Save a segment register away: */ #define SAVE_SEGMENT(seg) \ static inline unsigned long __savesegment_##seg(void) \ { \ - unsigned long v; \ + __seg_return_t v; \ asm volatile("movl %%" #seg ",%k0" : "=r" (v)); \ return v; \ } -- 2.53.0