From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214D23CA4A3 for ; Tue, 28 Apr 2026 16:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777392310; cv=none; b=VX3G9dQ3/6z/u7ZSlFBsphWkWalWwPnWoYRjfzvRnYSVb3QdvOxCQNLA9PfBLvf3xoTXIxJ56e1XryzdpUMtsKOrnrriN4hTdA3KqTXy6rbKUVwYititeQuHYFDKbsA66WvHNstO5A4Qkz3Ne5nw2ixj9TxwMYGnZfz3yw83anI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777392310; c=relaxed/simple; bh=HdrXlyrDfeIxdtTXugj2P6dtjXh8wn0SUXzUqc1Fr0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R34goEndjiI2MJeKqewY2GIeJiQmkGIjYnGzQ8B2frS6GFDkZUoXucO6kW0Rv46j3lgArvgqTyElU7rWSnO7WDSagSCr153WSwxjsZTSf56twjxZ+pLSGxD5oIIBBASXllTtmu/75Af0f4mWFMxKENXDNuBJWbbJ7K0rUbzDGNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mLVSgRrS; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mLVSgRrS" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43d70b3e159so6222840f8f.0 for ; Tue, 28 Apr 2026 09:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777392307; x=1777997107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=diidTTRQxn1V6YLV0Sd4MSnGO0p1HVxLP6kA7XwnSN8=; b=mLVSgRrSD44+SbpxrVOc4jxasbR4AgmIoxONvFuXslcuRUm9xLatXXLuQYD5lMg9T3 BASyuNYNwTCqsu/YtmltvOjX2tZpcZSvu+Px9ymay1/YIUH9WQXM8oV3oPDub4RZk65K bmc7RcQOGKAiO803Xp1jCqJGMROQ+jIyuSKiTgnatvmHpkQBGyIhmJjgjsEKlwTHky3T 0w/7Ol87uErMd9Zed2buP7l1hsVCbyyZk5+oWGxaHyu+2d+GoULfk5Dop/NdOKFWgcuh p01IirqehIg5CambCLJJlMlNKqdK8sjeSjWnD7OSCmBq0AiJmWn0a64dCtKlkvCriuSS eEAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777392307; x=1777997107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=diidTTRQxn1V6YLV0Sd4MSnGO0p1HVxLP6kA7XwnSN8=; b=fkP3bqkPjd2DD6FmkZK7mlZAufbeGr2IKjpPy4sWheUrDE6crWJgBnEcd9WsrLaP+U TDbLVIluSIbz9Q3MjJpv6erPlWfesCJ7heq2Q9ravsGTjcOQTr/n7T37tTYXOdhckpEq bf8Hl7gpuv5//wdXXkWC+9koEkPaL20CT12L05dqvxPT2yfKLPMiDBmmga3zKFq4HMou tlL7AIfvnFeiC8lPygO5AhFavjuP7Euu/v8uyTk/SUf2pdzasU5wQr0yms3YNButVxj2 8/bb2hXndZU1OrSCenyd4s4FQCvHuqqTeFaHfIfK+k3BtZKrsEhRPOUgQSLojuRd3L9o TYgA== X-Forwarded-Encrypted: i=1; AFNElJ95iZCPF0U5JH00abcQJ4XbGH+eA9YXqv/Samw0uYdstsMm4+D0ZeHAD5ACqX8T6v9xuwEpXRvnHPydlwM=@vger.kernel.org X-Gm-Message-State: AOJu0YybO/J+SbeQzJKhQ5nyNq79otmQOMLI3Z7HS07Z6izB5fm3jCXn w6/QbSzV+0FFD6QFx1Suuzh32Zm1tJ063drBwEGKjehzPUfu/PZsb9dl X-Gm-Gg: AeBDievjbg+nG/wDvVFMiIZn5U03t7/ZOasl4YEb1w1PJixdDknWAqEE8DyeMTLgJUV 90bHz9DgbXYHrCDbbxLrNOv5ctPsaNzfvLJLWqtwiFNlOGhDgPMTuDHVbHWIETt+g6Ryhqef4a5 FUKpNwEa+WBNx5iQnu80z6xFZkxVlBhaKKj8MItVkqPCDwJGma8el3Udv2vmspCU1Ys9hMhzYkz QkpOnHAYu9jjX/Y0UjrJleNn+RYqea9Rm7JD6TEfhkpuKRoc2q+Ls03QYIf6UDEgnqESRO/F7Q4 iWJo28WFIZ37XNMSSZJq3TJOKMtsNN2DVhxn2XAU95OlkaBmYalD5lNXCdOldT7iOux4QJRiVa1 BXpWVJWZZzdMWrNzkQ36fQS6vIqVul53Ae7vX5pJgDHqKW63u4tL9NtLOuRDlUHq0CCRWgyEiHx 9/A2fOdKdWOMmAUSJvHgxVWqDuvMv2xEm+4lVXMS2XIrSORz3pOBXp8DCcU2qtK/BHCqU5lHsBD MiDJ7I8kTCteUcQlpbwBCVyujq1AjPbFk1acODk8UNt2iIsGK156Yg= X-Received: by 2002:a05:6000:1862:b0:43d:77c6:be6d with SMTP id ffacd0b85a97d-44647808875mr7087528f8f.7.1777392307420; Tue, 28 Apr 2026 09:05:07 -0700 (PDT) Received: from fedora ([46.248.82.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4464004edc8sm7532923f8f.37.2026.04.28.09.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 09:05:06 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Oleg Nesterov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH RESEND -tip v2 3/7] x86/ptrace: Use savesegment() in get_segment_reg() instead of inline asm Date: Tue, 28 Apr 2026 18:03:37 +0200 Message-ID: <20260428160443.3593331-3-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260428160443.3593331-1-ubizjak@gmail.com> References: <20260428160443.3593331-1-ubizjak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace direct 'movl' instructions for DS, ES, FS, and GS read in get_segment_reg() with the savesegment() helper. This improves readability, consistency, and ensures proper handling of segment registers on x86_64. No functional change intended. Signed-off-by: Uros Bizjak Acked-by: Oleg Nesterov Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/kernel/ptrace.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index 3dcadc13f09a..4cb00aa0645f 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c @@ -251,32 +251,31 @@ static u16 get_segment_reg(struct task_struct *task, unsigned long offset) /* * Returning the value truncates it to 16 bits. */ - unsigned int seg; + unsigned int retval; switch (offset) { case offsetof(struct user_regs_struct, fs): if (task == current) { - /* Older gas can't assemble movq %?s,%r?? */ - asm("movl %%fs,%0" : "=r" (seg)); - return seg; + savesegment(fs, retval); + return retval; } return task->thread.fsindex; case offsetof(struct user_regs_struct, gs): if (task == current) { - asm("movl %%gs,%0" : "=r" (seg)); - return seg; + savesegment(gs, retval); + return retval; } return task->thread.gsindex; case offsetof(struct user_regs_struct, ds): if (task == current) { - asm("movl %%ds,%0" : "=r" (seg)); - return seg; + savesegment(ds, retval); + return retval; } return task->thread.ds; case offsetof(struct user_regs_struct, es): if (task == current) { - asm("movl %%es,%0" : "=r" (seg)); - return seg; + savesegment(es, retval); + return retval; } return task->thread.es; -- 2.53.0