From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22172C08DC; Tue, 28 Apr 2026 23:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777418575; cv=none; b=Wn43w9r3hNyW9LM0Ttkz9BCWAk4fmz85HNm7mG+ZRs6r0kZAHyDbXwcikuBGABBGS8cTyyNvo1bY5RDs8qDTiL7O1KoJF6QDqjQ9SdLETXqkd1Hkc4gxTKw/gZ7PYUgBa5AxAoGiDBeI6nL2fB6vnT1KtJjrnuh82IdLlx63FzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777418575; c=relaxed/simple; bh=l8W1qxSrVvflCqGmyesfCsVCe328OIy0LwoIhCBOM1k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uJfdRmDsYSTkB/HWBXE/1xKKy31a5Jckoi7t8MRJIWAYWMEb2zMLkJMgEMEmb42jPsBpi0o5ELB59kG63yKHAj8B9Vxwpodd4AWV6FA/jIbg8I7lClV/CXza6t9UvTZxKzyDp3swzbuje6RAlHC6uxNyPMftOFsarbeZuRgQJCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LVn9by+i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LVn9by+i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E775C2BCAF; Tue, 28 Apr 2026 23:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777418575; bh=l8W1qxSrVvflCqGmyesfCsVCe328OIy0LwoIhCBOM1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LVn9by+iLoKBLMnBlHU+Y/zYOUPoHgd/Mmb1fWnwxS9RE++hyw1bKIFXyUO9nQQ/i yuwuEf2j8bmOxDUe8L+ia9/9tAPu5pDA5BIwEu0T5EXwOqPf346+Svm5dBS9uGcQNb wKRmUxAJsx68abOBhEOV+AY5e1HhZZA3D2qNgYOIAyaXE7YhEG+VhcFFTX3VQigdFX xM+Q5G3WtkpXdD2pYVwZToAf0C47CdHvRnXpmevN6tjg87JcfdSY3Aby5KOT+ubXZ5 h0nn/pYfERcnDv2CWxHa6on3sRbpaec1EoxtMIEDMiHLB/DpSy9yA05UjmsAXxQC7j qIaav6eCtrajQ== Date: Tue, 28 Apr 2026 16:22:53 -0700 From: Jakub Kicinski To: Jordan Rhee Cc: Harshitha Ramamurthy , netdev@vger.kernel.org, joshwash@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com, willemb@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, maolson@google.com, thostet@google.com, jefrogers@google.com, alok.a.tiwari@oracle.com, yyd@google.com, jacob.e.keller@intel.com, linux-kernel@vger.kernel.org, Naman Gulati Subject: Re: [PATCH net-next v4 3/3] gve: implement PTP gettimex64 Message-ID: <20260428162253.2228dd5f@kernel.org> In-Reply-To: References: <20260406234002.3610542-1-hramamurthy@google.com> <20260406234002.3610542-4-hramamurthy@google.com> <20260409201646.6af5235d@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Apr 2026 08:49:31 -0700 Jordan Rhee wrote: > > > +static int gve_cycles_to_clock_fn(ktime_t *device_time, > > > + struct system_counterval_t *system_counterval, > > > + void *ctx) > > > > Does this do anything GVE specific?? > > No, however, I would caution against adding an API to the kernel to > convert TSC to ktime since this could invite further abuses of TSC. I don't understand. You caution against doing something you're about to do? In case I didn't ask for it already - please make sure you CC time keeping maintainers on v5.