From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D0F433AD9D for ; Tue, 28 Apr 2026 16:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395441; cv=none; b=FM62xbEaJuEu4gqam/J/Quw+QDNcPKvM6hQr9ysI1pGaJRWTkGMwDDAI+lwiwmn6lpYKh7gaGBtzHo+ZLaKM73wrPFcEN7l0pvxejbdtCIpX2eNNnvRolpSy6PCkeqftCGRYuVCf32XkJsrhjf17zAzvTMWhn9TXnLrT+zwViw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395441; c=relaxed/simple; bh=BVSzmo/MPr3Pb1LofysZD9miRmecuUu8SXgUuZjWfyo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Cs8Hyyxo2rJHZVb51ZSw9gWsQZ6Jb1n5YdhLEapIiHyLcbtRN1CXZUZMW7zoT+fPIuCBfldZHh3RVs3nNKEGp9MuFk4ZhI+eufWOjKusSnFESJti7zDdNco7uGbuypMZW8KDS/qfw9wOG+AD2cLdJWuX5N6SWH8lLVjgCnM9qBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f88SCW7H; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f88SCW7H" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35da9c0c007so9990086a91.2 for ; Tue, 28 Apr 2026 09:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777395440; x=1778000240; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eNIfAFIh9VUEeZyZ7+5hHhr7ZygZVo9QnMVxJndWS1U=; b=f88SCW7HSWwTCbiOe4tOEY/WKbkTuds/2MGuotmyFU2l27VqdakjC0/qAkTsXe4hX4 90bR7lrJtnTvv4Vv8Axc/gqooP1U9tFvwusbaX/ThrqzJOaEoueTLEvhzwlD3Nb+YLyz vu/V7NKMW66ksWyWxOVKlyKRPecLJ/jcxkuj6R99FpD10paAV+R6SVP+TLrzExN7JyJd s0vG2Ew1EFVQoMJmwvaYqUq2ADHn2pgzmiv8D8KlTP76aKCSxYRyr+kj38txWhOaEWvL xdKRdcsMYicstkInRnyPsjeujC7rFudfz+A3q+8df4r61rntA3bFvE9ah6QSN0pxPao3 PYmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777395440; x=1778000240; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eNIfAFIh9VUEeZyZ7+5hHhr7ZygZVo9QnMVxJndWS1U=; b=Iu6XX3VOJK5Y7o/U8+/k4xiY6SsIGDQZwlw8hmnB+D+ukAra/sYluyuRgykEMHzxkB mio67XebHpUuPPgMRM7uAkwlF6f1yoNN/dwB/Yvb/5P2eUr7mwoX44eKg+lMd6XzMcgD rs51mkAZQxMQwvs7EaBO51rD68bzet8jILUs+zQmybekvfvehkSkE1iMnMQsAFKSXrQT aHDyPI0AdGHQVgHKvtyDr3N3m8rxVrat90eVcTDBVfmxSBn4ITjUZAEzWDzR44Bs0Rta enAVpUZc5EjWyl7lQo2K+iLAtmv3hJAQRZ5c+wrEAD8Ryv5brwRIxUFQjlDAt0h0G3lO PTAw== X-Forwarded-Encrypted: i=1; AFNElJ9C3K+tXW2V7fKEoHT0cokV4wYYUlMbmA97QPEh9ju/JF+vMNWQDuZYglviXudvdtHVwoK9TP9IMJK8kM4=@vger.kernel.org X-Gm-Message-State: AOJu0YwyI6BICFIsXAGLz2qEuWtpvhPHUYGwwgvY81tJDySsxQuklNWc 2+0xiJ0nlR3gVIr91Mxf9FI+dyTW0v2QWWOpR5Tird9VNkyyBiiviLIw X-Gm-Gg: AeBDiev5xs5iFny3y88y4aWBlX9PnWCgHqddftXbSNe+aX7GGYlHxhI+tdIvYH5+2GD 8fpjJEJeq34Fd1EOVBc1x0YS/ccHITMKJA78DFz7Wu5lIPBTPx4xqGtVK4rkovsDqCnpT7mcsoq BHm/ck+bj5fAuU/ojYAVrkLvortzPySwtnOd7rgmdHsJkCM3w9x584JwPbdShJD5xBNjQX+e2dR hqDE4ci9X+NnS1YOX1MGesmR9FfUybaFu3BTuzfgBnItI/bEdrZITGbgbpNNwRYiMlVOKbasodT DYO2t/urPEqxlSwF1P20FVwji9JTKSa/I8QKUUU+Y3iBTnNax1vTKFbRdZhjBsiSpffdsxwiIbF jNu4FJq3phwVyHmkx08GUQnTuMaeUJvSXzK/OJvyqr9LXBPeNfWtrAWfZ7JF7ahEJGHOc6lDxFE +bj8+MUHWdxMRz915tDdh3yBVuMy4yNIClAwXW1wsxm2pJ7ACT X-Received: by 2002:a17:90b:1a92:b0:35b:e56e:a17e with SMTP id 98e67ed59e1d1-364920a55e8mr3951141a91.17.1777395439948; Tue, 28 Apr 2026 09:57:19 -0700 (PDT) Received: from ubuntu.. ([49.205.39.136]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-364a0109e6asm238590a91.2.2026.04.28.09.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 09:57:19 -0700 (PDT) From: Ajith P V To: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ajith P V Subject: [PATCH] staging: greybus: add missing newline to sysfs_emit Date: Tue, 28 Apr 2026 16:57:08 +0000 Message-ID: <20260428165708.3565022-1-ajithpv.linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sysfs attribute is missing a terminating newline. According to the kernel documentation for sysfs, attributes should be terminated by a newline to follow standard userspace conventions. Fix the formatting by adding a '\n' to the sysfs_emit string. This resolves the checkpatch warning: "return sysfs_emit(...) formats should include a terminating newline" Signed-off-by: Ajith P V --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute = @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } static struct gb_audio_manager_module_attribute -- 2.43.0