From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B01CA32C94A for ; Tue, 28 Apr 2026 16:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395466; cv=none; b=QOqLq4UevM5mJAoRHZLSh3nqKJW6eS7uOyi1Xs4l1hSaPdyolEoeO67EV4bnkbB+8sDKSsWDuRLsAM5FETq8pFll6hNUhzwobMYuR6DTQ7HrodKAlbaZmfy8BtEggVeAdy/9HQ/pdEbc4FYxYPpK6hgaH8vRmLA80rAUvLN1s+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395466; c=relaxed/simple; bh=vsoulUNuQqQHNX9oKC4vtpX947oQ8/AiVwpRZbftkfs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cqx3edK7yjYEOPVqabdd5VTrGleYunBEhfgdY/QEKq0iNQpg4YWI3Pt8uE3AxCwrYFWqXz2IdXg9C+XmskUhwMhV/iyMhf2XA4Ew/XOCZgHkapG5i3/Ae5FezRdoE3WunUXX+tQfCHSKY7bunug7lnIyj6aHluRxd8drI4qO+ZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nwe8Cvtj; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nwe8Cvtj" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777395462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CgLQ9Y1K8hEZbbpfjEz4NsFKN2z5LFsryS6T3jsNdJM=; b=nwe8CvtjJ6J7XSt+xYIYVdXiNI0Ux9tcPvtC2gesL8JwoA5t5HWAm3u+Z4C0q+2gSd/FQm qsZOG/ZRMChFgu8200jWpveKKOYrXT1E9YaARjPvLNQXA2EdY46gMpadP9u5jhXgENmDJq 5Z6QSr/U75++0bkyoXdFrnZU1wj5kSY= From: Thorsten Blum To: Michael Tretter , Pengutronix Kernel Team , Mauro Carvalho Chehab Cc: Thorsten Blum , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: i2c: isl7998x: inline i2c_check_functionality check Date: Tue, 28 Apr 2026 18:57:20 +0200 Message-ID: <20260428165719.590376-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=825; i=thorsten.blum@linux.dev; h=from:subject; bh=vsoulUNuQqQHNX9oKC4vtpX947oQ8/AiVwpRZbftkfs=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJkfnr1veLDliPW59d4XQxd9ynnBunEO490ds//1fDL0W 7SUJfuQSkcpC4MYF4OsmCLLg1k/ZviW1lRuMonYCTOHlQlkCAMXpwBMxMWTkeGrgmFexrqPhw5M WeGlt+VXldHKyGwjxZzZT6Tldt8v4s5jZFhzwEP5+l3e5+8kP3T/3uBu9KLA6312akwpm8/6T3s Zt/ACAA== X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Inline the i2c_check_functionality() check, since the function returns a boolean status rather than an error code. Signed-off-by: Thorsten Blum --- drivers/media/i2c/isl7998x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c index 5ffd53e005ee..96702c5eaa35 100644 --- a/drivers/media/i2c/isl7998x.c +++ b/drivers/media/i2c/isl7998x.c @@ -1460,8 +1460,7 @@ static int isl7998x_probe(struct i2c_client *client) int nr_inputs; int ret; - ret = i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA); - if (!ret) { + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) { dev_warn(&adapter->dev, "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n"); return -EIO;