From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95B6324B1F for ; Tue, 28 Apr 2026 16:58:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395523; cv=none; b=UQuJah44ikp0+E6NlbRW/QL0zefhejhKf+gEoJjwj4yC0qiEaAP6bC0W2vdL4/Ri09G1yZrM24aHUMU4fbX+/y4RI/SxXl8uDphBHqIBpN61T5ZY0kdmjPAOySzn9dsCyHZWf2J9Alf9biK1NNVAPMtrKbfbVoKo2FhFG+RB3D0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395523; c=relaxed/simple; bh=R++0ZX+Hi7H5oz+b/ZWFJmR+IwhbFQyCO1Xou/4ppf0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UhxnM/qcue7xB5/QM65U/npWAvCmMjxlsijx2S74gYsbvUsg7+H5TqKvE7BdBMRpeouCAG4KOQQNT9retSue+4q73m/flfziPy8WnDWC8atBK6g5ZYOXrhzP1gJGuzIeVTzzdg/vpKeuIZK9je1wmgEbLr/MZyP8VoIJgpLQ1Dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EiBrZmzN; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EiBrZmzN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777395519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kFRTQ1wPmWY8f+tqq9XJS1IGjy+sOPC7OJSCpwtcS1M=; b=EiBrZmzNGVbtEflwkqXONnEs0Ix0KIbEZLP9SVsMQFBtVhKTQ11vvtqjNOO2WHa+2qbPci xkiY/kbU5CaMyi5MsA8ybbNM7S4b67JN+SpgQairVCSKUDBwCFpGzz69UaHuoVGVT/gKfg 58hIiaco/O1iqP6dpY4zjHQiLxcHfoQ= From: Thorsten Blum To: Andreas Werner , Lee Jones Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH] mfd: menf21bmc: inline i2c_check_functionality check Date: Tue, 28 Apr 2026 18:58:01 +0200 Message-ID: <20260428165800.590496-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=974; i=thorsten.blum@linux.dev; h=from:subject; bh=R++0ZX+Hi7H5oz+b/ZWFJmR+IwhbFQyCO1Xou/4ppf0=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDJkfnksse7t0SXD53n9Vhw99Ofv/xc7lWfdS7/AfYA2bN /1Rd3nOqY5SFgYxLgZZMUWWB7N+zPAtrancZBKxE2YOKxPIEAYuTgGYyNzTDP+rslfMmuIpOudO /5p6U7Nkh/6ts9cJaa70kpB1lVHWv9HJyLBgn3DzL+O4zyVr6zbyFIkJS+5Y8b/T/I/i81MnPyW czGAHAA== X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Inline the i2c_check_functionality() check, since the function returns a boolean status rather than an error code. Signed-off-by: Thorsten Blum --- drivers/mfd/menf21bmc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/menf21bmc.c b/drivers/mfd/menf21bmc.c index 1d36095155e0..0f24de516d72 100644 --- a/drivers/mfd/menf21bmc.c +++ b/drivers/mfd/menf21bmc.c @@ -54,11 +54,9 @@ menf21bmc_probe(struct i2c_client *client) int rev_major, rev_minor, rev_main; int ret; - ret = i2c_check_functionality(client->adapter, - I2C_FUNC_SMBUS_BYTE_DATA | - I2C_FUNC_SMBUS_WORD_DATA | - I2C_FUNC_SMBUS_BYTE); - if (!ret) + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA | + I2C_FUNC_SMBUS_WORD_DATA | + I2C_FUNC_SMBUS_BYTE)) return -ENODEV; rev_major = i2c_smbus_read_word_data(client, BMC_CMD_REV_MAJOR);