public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dragos Tatulea <dtatulea@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Björn Töpel" <bjorn@kernel.org>
Cc: Martin Karsten <mkarsten@uwaterloo.ca>,
	dtatulea@nvidia.com, Gal Pressman <gal@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>, Joe Damato <joe@dama.to>,
	Frederik Deweerdt <fdeweerdt@fastly.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH net-next 0/2] net: napi: Fix timer arming during busy poll timeout
Date: Tue, 28 Apr 2026 17:51:29 +0000	[thread overview]
Message-ID: <20260428175134.1197036-2-dtatulea@nvidia.com> (raw)

Under certain conditions a queue can be left out with interrupts
disabled and with the napi re-scheduling timer permanently stopped.
This behaviour is triggered by the napi busy poll path when
gro-flush-timeout and defer-hard-irq are set.

The first patch is a fix and has a more detailed description of how
the issue can occur.

The second patch represents an improvement which needs additional
review (hence the RFC).

The strategy for the non-RFC version is to send the first patch
as a fix to net and then send the improvement to net-next because
of the behavioral change (skipping the poll).

Is this the right way to go or should the 2 patches be squashed into
a fix for net?

[1] https://lore.kernel.org/netdev/20241105210338.5364375d@kernel.org/

Dragos Tatulea (1):
  net: napi: Fix interrupts permanently disabled during busy poll

Martin Karsten (1):
  net: napi: Skip poll when arming GRO timer in busy poll

 net/core/dev.c | 49 ++++++++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 21 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-04-28 17:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 17:51 Dragos Tatulea [this message]
2026-04-28 17:51 ` [RFC PATCH net-next 1/2] net: napi: Fix interrupts permanently disabled during busy poll Dragos Tatulea
2026-04-28 23:40   ` Jakub Kicinski
2026-04-29  0:04     ` Martin Karsten
2026-04-29  0:31       ` Jakub Kicinski
2026-04-29  8:13         ` Dragos Tatulea
2026-04-29 22:52           ` Jakub Kicinski
2026-04-29  0:38   ` Jakub Kicinski
2026-04-29  8:43     ` Dragos Tatulea
2026-04-29 12:13       ` Björn Töpel
2026-04-29 12:43         ` Dragos Tatulea
2026-05-04 11:30           ` Dragos Tatulea
2026-05-05  1:00             ` Jakub Kicinski
2026-04-28 17:51 ` [RFC PATCH net-next 2/2] net: napi: Skip poll when arming GRO timer in " Dragos Tatulea
2026-04-29  0:37   ` Jakub Kicinski
2026-04-29  1:02     ` Martin Karsten
2026-04-29 12:37   ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428175134.1197036-2-dtatulea@nvidia.com \
    --to=dtatulea@nvidia.com \
    --cc=bjorn@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fdeweerdt@fastly.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=joe@dama.to \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkarsten@uwaterloo.ca \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox