From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C2D647B410 for ; Tue, 28 Apr 2026 18:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401434; cv=none; b=BB5RBxuELvCv1nuLCUAICEmBz733omofFDP3FUQl7FvLV58isQd8Xp7D+ICJPvLeHKxQ43KBaOgn9l1awL/cCdBVZZfEBnZ090jjK2YfJwN0tj3R0s+sWIgwD6Ydx+BCnq4gv479LDw9pRZxU7B2wHcjhJn40B0mC/WT9Hofr/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777401434; c=relaxed/simple; bh=0rU1L8BvPHQ2fDeUrdj36D6kTqUKvcHED5L5ySfdups=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=kyR37ByRq+6DB83FoZetYwgah955hvYN2JLH+Zostd4bfPtGo1yipCgjCWa/yeYWmSPjQWRPK0LpyGdvn49vLZV8DGZck/RWBI+Kfz1oIa5MwyhfFyru4hht7hRdEDOy1fvqfqIJ6KxxNv4IER+EeELYT9aBKK8PtQ96Uv909qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dylanbhatch.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QFEt5Gsi; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dylanbhatch.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QFEt5Gsi" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-82f6a5b4f88so15566590b3a.2 for ; Tue, 28 Apr 2026 11:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777401432; x=1778006232; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MgLPe5eAKuVa5a2kQmP4Ur6cn6qfh4/sYx0yOH1k728=; b=QFEt5GsiNbeFzVyiFmYC6BeKifK1SBvlxCswW2GYvHFz8/NHexXvB8PFptbXuQc/lP 6Ir4OZL+hwh3E3VYKGSm2FCoZRcZNRr2+dFDmfdvisAQ2XQtuXh9xE1vg4V3sfOgqzhr osu28xxQE5MEd+ApYTuzjUeHW5rV7zvEk+vrijdJUWmPo6gtDNc7g/OtPTBBVZRdTY8T V3mypR3NAm8Y1xHR1ifDC+WmXmZ8ePngL4ofp0kvothTF/3A0lSiuzeBxlEeAfZEZgTx zJI9MplZqOtdB668KCbVMLZPCKTDC4r72JTUIaC2uq+EAfyrGZP4CpqqW5zp4PJgfgY/ cXAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777401432; x=1778006232; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MgLPe5eAKuVa5a2kQmP4Ur6cn6qfh4/sYx0yOH1k728=; b=MZeW0fK04KoMrqtJRElBnlv/k8iNgTOI6o3JHJau8iGwL/hp6GDObIl0VhOSCaAqjt jB7LbBePSV9MbFUcmq21P7B2wahCmiGrxqhAn802StI3msJFhXDLJwA3sf9ZZ7anPbw/ zpcrez5dpEP9E3Uwo2rvw0o4DhO1q7yRC3Onz7Epssw108tHx41w+Q21H5HgP6Mw1uyV 1QH19meotbxWPf+DQGPbJTbwnDBuIHT57Zq+fw/cjs8vd7pjXmnmW7F8hDVHECMS+Lr/ AtCR39/u0Tn1I5AtV6r/kblVxqJhirp5VcYAaefPFV3qRYoPl965j7hyx8KuzkIL8Hni tGzg== X-Forwarded-Encrypted: i=1; AFNElJ/7DxKSNq8HRg6a7Q0scF3liKhFYqSeUgYk56BAWgYeyje/dKqlwy+0ScxQv6Jww4DqnJMcTmGB77vDAB4=@vger.kernel.org X-Gm-Message-State: AOJu0YxWeKZCWQYNKwhw8zQEgEwaxjr6WCLkUxcl8mN/nHxw//y8n80E xpE83Bo1yViP6+6G4CBKJzHqLOfKTy0EWxqVKOzwtPZGVdzH/j78Rh4y4MJ62wjeVA0zJmaSJ8R eYwfxJ8sH+JOU7jjGwv2LVIKp3Q== X-Received: from pfnw4.prod.google.com ([2002:aa7:8584:0:b0:82f:473b:a2d5]) (user=dylanbhatch job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:340c:b0:82d:2086:de2a with SMTP id d2e1a72fcca58-834ddc643d1mr4609851b3a.35.1777401431392; Tue, 28 Apr 2026 11:37:11 -0700 (PDT) Date: Tue, 28 Apr 2026 18:36:37 +0000 In-Reply-To: <20260428183643.3796063-1-dylanbhatch@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260428183643.3796063-1-dylanbhatch@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260428183643.3796063-3-dylanbhatch@google.com> Subject: [PATCH v5 2/8] arm64, unwind: build kernel with sframe V3 info From: Dylan Hatch To: Roman Gushchin , Weinan Liu , Will Deacon , Josh Poimboeuf , Indu Bhagat , Peter Zijlstra , Steven Rostedt , Catalin Marinas , Jiri Kosina , Jens Remus Cc: Dylan Hatch , Mark Rutland , Prasanna Kumar T S M , Puranjay Mohan , Song Liu , joe.lawrence@redhat.com, linux-toolchains@vger.kernel.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Randy Dunlap Content-Type: text/plain; charset="UTF-8" Build with -Wa,--gsframe-3 flags to generate a .sframe section. This will be used for in-kernel reliable stacktrace in cases where the frame pointer alone is insufficient. Currently, the sframe format only supports arm64, x86_64 and s390x architectures. Signed-off-by: Weinan Liu Reviewed-by: Prasanna Kumar T S M Reviewed-by: Jens Remus Signed-off-by: Dylan Hatch --- MAINTAINERS | 1 + Makefile | 8 ++++++++ arch/Kconfig | 21 +++++++++++++++++++++ arch/arm64/Kconfig | 1 + arch/arm64/include/asm/unwind_sframe.h | 8 ++++++++ arch/arm64/kernel/vdso/Makefile | 2 +- include/asm-generic/sections.h | 4 ++++ include/asm-generic/vmlinux.lds.h | 15 +++++++++++++++ 8 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/include/asm/unwind_sframe.h diff --git a/MAINTAINERS b/MAINTAINERS index cfc7dec88da4..a7d75f9cb5f4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -27561,6 +27561,7 @@ STACK UNWINDING M: Josh Poimboeuf M: Steven Rostedt S: Maintained +F: arch/*/include/asm/unwind_sframe.h F: include/linux/sframe.h F: include/linux/unwind*.h F: kernel/unwind/ diff --git a/Makefile b/Makefile index 2b15f0b4a0cb..6c94a5257679 100644 --- a/Makefile +++ b/Makefile @@ -1110,6 +1110,14 @@ endif # Ensure compilers do not transform certain loops into calls to wcslen() KBUILD_CFLAGS += -fno-builtin-wcslen +# build with sframe table +ifdef CONFIG_HAVE_UNWIND_KERNEL_SFRAME +CC_FLAGS_SFRAME := -Wa,--gsframe-3 +KBUILD_CFLAGS += $(CC_FLAGS_SFRAME) +KBUILD_AFLAGS += $(CC_FLAGS_SFRAME) +export CC_FLAGS_SFRAME +endif + # change __FILE__ to the relative path to the source directory ifdef building_out_of_srctree KBUILD_CPPFLAGS += -fmacro-prefix-map=$(srcroot)/= diff --git a/arch/Kconfig b/arch/Kconfig index d7caf2e245ce..8d27b3249e7a 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -520,6 +520,27 @@ config SFRAME_VALIDATION If unsure, say N. +config ARCH_SUPPORTS_UNWIND_KERNEL_SFRAME + bool + help + An architecture can select this if it enables the SFrame (Simple + Frame) unwinder for unwinding kernel stack traces. It uses an unwind + table that is directly generated by the toolchain based on DWARF CFI + information. + +config HAVE_UNWIND_KERNEL_SFRAME + bool "Sframe unwinder" + depends on AS_SFRAME3 + depends on 64BIT + depends on ARCH_SUPPORTS_UNWIND_KERNEL_SFRAME + select UNWIND_SFRAME_LOOKUP + help + This option enables the SFrame (Simple Frame) unwinder for unwinding + kernel stack traces. It uses unwind an table that is directly + generated by the toolchain based on DWARF CFI information. In + practice, this can provide more reliable stacktrace results than + unwinding with frame pointers alone. + config HAVE_PERF_REGS bool help diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 38dba5f7e4d2..f7ae8eaaadc4 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -112,6 +112,7 @@ config ARM64 select ARCH_SUPPORTS_SCHED_SMT select ARCH_SUPPORTS_SCHED_CLUSTER select ARCH_SUPPORTS_SCHED_MC + select ARCH_SUPPORTS_UNWIND_KERNEL_SFRAME select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT select ARCH_WANT_DEFAULT_BPF_JIT diff --git a/arch/arm64/include/asm/unwind_sframe.h b/arch/arm64/include/asm/unwind_sframe.h new file mode 100644 index 000000000000..876412881196 --- /dev/null +++ b/arch/arm64/include/asm/unwind_sframe.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ASM_ARM64_UNWIND_SFRAME_H +#define _ASM_ARM64_UNWIND_SFRAME_H + +#define SFRAME_REG_SP 31 +#define SFRAME_REG_FP 29 + +#endif /* _ASM_ARM64_UNWIND_SFRAME_H */ diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile index 7dec05dd33b7..c60ef921956f 100644 --- a/arch/arm64/kernel/vdso/Makefile +++ b/arch/arm64/kernel/vdso/Makefile @@ -38,7 +38,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO CC_FLAGS_REMOVE_VDSO := $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) \ $(RANDSTRUCT_CFLAGS) $(KSTACK_ERASE_CFLAGS) \ $(GCC_PLUGINS_CFLAGS) \ - $(CC_FLAGS_LTO) $(CC_FLAGS_CFI) \ + $(CC_FLAGS_LTO) $(CC_FLAGS_CFI) $(CC_FLAGS_SFRAME) \ -Wmissing-prototypes -Wmissing-declarations CC_FLAGS_ADD_VDSO := -O2 -mcmodel=tiny -fasynchronous-unwind-tables diff --git a/include/asm-generic/sections.h b/include/asm-generic/sections.h index 0755bc39b0d8..336d27011a58 100644 --- a/include/asm-generic/sections.h +++ b/include/asm-generic/sections.h @@ -31,6 +31,7 @@ * __irqentry_text_start, __irqentry_text_end * __softirqentry_text_start, __softirqentry_text_end * __start_opd, __end_opd + * __start_sframe, __end_sframe */ extern char _text[], _stext[], _etext[]; extern char _data[], _sdata[], _edata[]; @@ -53,6 +54,9 @@ extern char __ctors_start[], __ctors_end[]; /* Start and end of .opd section - used for function descriptors. */ extern char __start_opd[], __end_opd[]; +/* Start and end of .sframe section - used for stack unwinding. */ +extern char __start_sframe[], __end_sframe[]; + /* Start and end of instrumentation protected text section */ extern char __noinstr_text_start[], __noinstr_text_end[]; diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 1e1580febe4b..090da633db92 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -491,6 +491,8 @@ *(.rodata1) \ } \ \ + SFRAME \ + \ /* PCI quirks */ \ .pci_fixup : AT(ADDR(.pci_fixup) - LOAD_OFFSET) { \ BOUNDED_SECTION_PRE_LABEL(.pci_fixup_early, _pci_fixups_early, __start, __end) \ @@ -911,6 +913,19 @@ #define TRACEDATA #endif +#ifdef CONFIG_HAVE_UNWIND_KERNEL_SFRAME +#define SFRAME \ + /* sframe */ \ + .sframe : AT(ADDR(.sframe) - LOAD_OFFSET) { \ + __start_sframe = .; \ + KEEP(*(.sframe)) \ + KEEP(*(.init.sframe)) \ + __end_sframe = .; \ + } +#else +#define SFRAME +#endif + #ifdef CONFIG_PRINTK_INDEX #define PRINTK_INDEX \ .printk_index : AT(ADDR(.printk_index) - LOAD_OFFSET) { \ -- 2.54.0.545.g6539524ca2-goog