From: Bjorn Helgaas <helgaas@kernel.org>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Improvements to PCI hibernate path
Date: Tue, 28 Apr 2026 16:51:48 -0500 [thread overview]
Message-ID: <20260428215148.GA257618@bhelgaas> (raw)
In-Reply-To: <20260427205024.254677-1-superm1@kernel.org>
On Mon, Apr 27, 2026 at 03:50:18PM -0500, Mario Limonciello (AMD) wrote:
> A few cycles ago I sent out a kernel series for using the S4 paths when
> the system goes to S5. Some parts of it got merged, and Rafael suggested
> to split the other parts into smaller pieces across multiple kernel cycles
> to make bisecting easier.
Thanks for posting this again. Sashiko had a few questions:
https://sashiko.dev/#/patchset/20260427205024.254677-1-superm1%40kernel.org
I didn't look at them in detail, although I did think the ACPI r6.5
sec 16.1.5 reference was a little bit obscure. The diagram in sec
16.1 certainly implies that wakeups only occur in S1-S4 and not in S5.
Sec 16.1.5 does mention "Remote Start", which is completely undefined
by the spec but searching does find sec 7.4.2.6, which clearly says
the system requires a complete boot when awakened. Possibly a little
misleading to refer to Remote Start as "awakening" when it's
apparently not a "wakeup".
That section also says "OSPM does not disable wake events
before setting the SLP_EN bit when entering the S5 system state."
next prev parent reply other threads:[~2026-04-28 21:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 20:50 [PATCH v2 0/6] Improvements to PCI hibernate path Mario Limonciello (AMD)
2026-04-27 20:50 ` [PATCH v2 1/6] PCI: Stop setting cached power state to "unknown" on unbind Mario Limonciello (AMD)
2026-04-27 20:50 ` [PATCH v2 2/6] PCI/PM: Disable device wakeups when halting or powering off system Mario Limonciello (AMD)
2026-04-27 20:50 ` [PATCH v2 3/6] PCI/PM: Split out code from pci_pm_suspend_noirq() into helper Mario Limonciello (AMD)
2026-04-27 20:50 ` [PATCH v2 4/6] PCI/PM: Run bridge power up actions as part of restore phase Mario Limonciello (AMD)
2026-04-27 20:50 ` [PATCH v2 5/6] PCI/PM: Use pci_power_manageable() in pci_pm_poweroff_noirq() Mario Limonciello (AMD)
2026-04-27 20:50 ` [PATCH v2 6/6] PCI: Put PCIe bridges with downstream devices into D3 at hibernate Mario Limonciello (AMD)
2026-04-28 21:51 ` Bjorn Helgaas [this message]
2026-04-28 22:02 ` [PATCH v2 0/6] Improvements to PCI hibernate path Mario Limonciello
2026-04-28 22:12 ` Bjorn Helgaas
2026-04-28 22:15 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428215148.GA257618@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael@kernel.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox