Re: [PATCH v14 5/7] vfio-pci/zdev: Add a device feature for error information

Farhan Ali
2026-04-29T16:59:13Z

On 4/29/2026 2:40 AM, Niklas Schnelle wrote:
>> +struct vfio_device_feature_zpci_err {
>> + __u32 flags; /* Indicate feature in non CCDF reserved space */
> The "non CCDF" feels a bit subtle for marking this as a vfio-pci
> feature specific field. Maybe call it "vfio_feat_flags"?

I was a little hesitant about naming it with vfio as it's not exactly
tied to anything in vfio framework. But if you feel strongly will change it.

>> + __u32 reserved1;
>> + __u32 fh; /* function handle */
>> + __u32 fid; /* function id */
>> + __u32 ett : 4; /* expected table type */
>> + __u32 mvn : 12; /* MSI vector number */
>> + __u32 dmaas : 8; /* DMA address space */
>> + __u32 reserved2 : 6;
>> + __u32 q : 1; /* event qualifier */
>> + __u32 rw : 1; /* read/write */
>> + __u64 faddr; /* failing address */
>> + __u32 reserved3;
>> + __u16 reserved4;
>> + __u16 pec; /* PCI event code */
>> + __u8 reserved5[28]; /* Non CCDF reserved space */
> While also vfio-pci specific for now, the reserved5 would potentially
> become CCDF if that ever grows. Maybe the comment could say "Allow for
> future expansion"?
>
>
Sure, will update the comment.

Thanks

Farhan