Re: [PATCH v3] iio: magnetometer: rm3100: Modernize locking and refactor control flow

Maxwell Doose
2026-04-29T19:00:17Z

On Wed, Apr 29, 2026 at 1:26 PM Andy Shevchenko
<andriy.shevchenko@intel.com> wrote:
>
> Won't fly. I am pretty sure most of the maintainers find that bad. The problem
> is that the caller should be crystal clear to show what the critical section
> is. Hiding that information behind macros drastically reduces understanding of
> the code,
>

Was just a thought. Even if it were to be implemented, it certainly
wouldn't be a macro.

best regards,
maxwell

>
> > I think that would be sound
> > for a separate patch. I'd ordinarily include that in this patch, but I
> > feel at that point we might be deviating from the original purpose of
> > the patch.
>
> I agree.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>