From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 464993BFE4A for ; Wed, 29 Apr 2026 09:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777454222; cv=none; b=IVa6cFHNs/lTK/9n9r6E7hzxZHsLW5ie1Pjh/w0DUysmmPsDeUoXbGQkwGG8gAxCeKrGyEZojpPgTdkSsJBAa6Zb6TwmduD/8QlMVTV2hSkJilIW1CpGb8X3YmjD1nKgAKtOGTMiTkGFRDRANl0TJBrMPzA6f00ldNH7lIS7Ego= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777454222; c=relaxed/simple; bh=1SuR6UH2DsN7PTT/NUCgzSGsYpfp8unFOGhnizEc+WA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jJIup6iodkcwfOwEZK/FaaPfB8HKBWhfSxxJsg0Cz12CpOchWCb3NxTu0ZY0n1HXjmf4qZhA9DyvbkFKG+oXoKChjN4kyZKmc1X950/d8Vs0MrfoJ1LxQZNDZIRDZMRlsKq98RiHiJPeyARFpVxM+34akbckMHkR5R01BbVjNCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n9C3ic/B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BdfpNIxF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n9C3ic/B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BdfpNIxF" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63T8pxAx963224 for ; Wed, 29 Apr 2026 09:17:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aHuTkaAZtY5ZkKn7XTvSxnz29uYRoxbW0NTxEIzBxS4=; b=n9C3ic/Bv5HcPC3Y tMICNSpH66R+6cuMAxdyoddld3fN3zFgfydWns2/OeLFpktmyXisxWb0FM9dtY1A pd1cUOTE8ukuXEcweUvaWlVobHganl70swB1PDly7ewCzTA6uyA6XKa5GUPxotAB fpPfiwK4NRSp2SQbj82VlpIaycDtFoS3X8IBHO2jBUzJYO240k2ySzElNUt7vbac VqNhN10oZIttmL2leHeFWwKwB1M5iiJ2Kr0T6y1GRzm5Ks5bO+Qdz5X2kioG/rP3 B+SNNmPi7zvcVg04gPgiZWy9jG47XFn3UYDxGGtCJzSiJtDIwdlU0Ez7BorjRHZ0 2rfLJw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4du2m4tnyq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 09:17:00 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c76cb2dce57so7677532a12.1 for ; Wed, 29 Apr 2026 02:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777454219; x=1778059019; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aHuTkaAZtY5ZkKn7XTvSxnz29uYRoxbW0NTxEIzBxS4=; b=BdfpNIxF3Sz/FKm3jJINYqiKkOPH18cCRkIHXmgRfjsrs5/+0SlI2yOKE0Nyh//Oxo 9diMtnahjDsj6VSA7wQwJcPP+MzbmGgmg0ecYXZ9rVm1NaDEs7TI94Ye0s0O2NIU3r2+ QfoRD2b8fZ/xEMSwrUrZaywvUHuxMfP5VK175Ke2d1NxVOk74v7gs4XiLw4JjrqeOkPD /WzzcRG2rgVfxU7Y0YGaH8yu4JVG1lAElMCOFORbtUpMPxHfJzT9dTzWTkw7faXp4+KT fO8B+W9QvgfWoNBs68GiZ9eOU368hZrb+K8rMEmSJ6duEehi81X3GmRojCQOiUICMAyJ 8EyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777454219; x=1778059019; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aHuTkaAZtY5ZkKn7XTvSxnz29uYRoxbW0NTxEIzBxS4=; b=EiRIVscwXBZWMFqYivY1zqHQ5XVAbcaCJvrO38XSHqdSnmlT4XFDSHIcM0UuOpe0r0 tzdqnTzIavniP4iOS7CxzTp7qUuUuWViCg2d5WOfBvrRCfGH+nL77+pX8hJJhcXqvB8+ nZNyr+2q7gE+JBCZ6cVeJq4XtvC+xmmmH/KLUvBqX33D0DD353TeMphRBaovRFFsmBMd 7qBTUJg5lVwmlWqebglfYyOnXDnv/g0eyd+qyuMyLEWGdv/wXc+AvyWhjk+80lRORqZ3 3TuEoUPLhH1qLqNTw6ZfmfsYaCH2BlQJdFMi/ftIlULYyZK2e7AaKVqtqF2aVmXLlSHC nisw== X-Forwarded-Encrypted: i=1; AFNElJ/8an88iUyiNwh27cQAsexmfM5Bjg/AL9QR9Rp8jg5dYLG06BxABPh0Ojeh/wJ/RqVCnGppNoiv+soWuxo=@vger.kernel.org X-Gm-Message-State: AOJu0YypuVxFq4VJ+8s8t4CvexqlhmoFk5C9bT4d9vTt3mbSoPPHQ78A I9npx8As12B2iNxcwNrhInw6kcFSqwPlYZcflMQ9Q6jO9UoM53oKHb6/1GVPRvK8HgO9QKnE5xJ rE+qsxN43RhtfPOoUNuvKNuMNgX6xEGCpqlukvL29jHLSt24ZYxz9A/mct4xvDcF+3Hk= X-Gm-Gg: AeBDiet1CE7u4c9QTmcpgde5bVsOWEsOZ4ZI1OJtDzzv4w5PQJnMahmsWYPwkSU5eJx IKdkZsQqgDZlmsSnbtQ4bEr5JJeswLB348JyO9LlOuqR28XLFNsWJNmVzL5MfbcRTS6Db31usQQ Egw1b7WORqsqAd68VR3B608Q42zkjl32NI5HRA0YiVhX32yROUWW/rqSkpvDmESwJ4I7D03KkK0 faxBjJL8A1CK++713Fo+gerrsFElqtGd/6H0I38VGg1kApOlH3/39I2y6cLSMGttoxFBz9sApj/ 6HWpLYr1MFByw+I+JktvmM4qNrvVHAz/LF1QMx+o0EN/8DGDlqogfC3uSWYdZwQH9T08UxzN4uR QtiWfyYas553katdY/ItoU9kLQN1ZdpzyZADwO4ikeZnO/SvUmALEXd8tJ+0p+xB5Fh9xlR7k8T 9ab9HnfBPZwYKoBU+cWFIuvvp0NNfPRMk= X-Received: by 2002:a05:6a00:cc7:b0:82f:8b84:50c0 with SMTP id d2e1a72fcca58-834ddc8af4emr6280196b3a.45.1777454219211; Wed, 29 Apr 2026 02:16:59 -0700 (PDT) X-Received: by 2002:a05:6a00:cc7:b0:82f:8b84:50c0 with SMTP id d2e1a72fcca58-834ddc8af4emr6280164b3a.45.1777454218693; Wed, 29 Apr 2026 02:16:58 -0700 (PDT) Received: from WANGAOW-LAB01.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834ed80dfa6sm1496340b3a.57.2026.04.29.02.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 02:16:58 -0700 (PDT) From: Wangao Wang Date: Wed, 29 Apr 2026 17:16:48 +0800 Subject: [PATCH 1/2] media: qcom: iris: improve gop size support for gen1 encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260429-dynamic_encode-v1-1-c9fb691d8b3a@oss.qualcomm.com> References: <20260429-dynamic_encode-v1-0-c9fb691d8b3a@oss.qualcomm.com> In-Reply-To: <20260429-dynamic_encode-v1-0-c9fb691d8b3a@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Wangao Wang X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777454211; l=3022; i=wangao.wang@oss.qualcomm.com; s=20251021; h=from:subject:message-id; bh=1SuR6UH2DsN7PTT/NUCgzSGsYpfp8unFOGhnizEc+WA=; b=bDgr0ClfssHc7JudQ1BZLoZxKlcJPCvhZddeJP8cso7nLCPANcctGSJMXGhfYDM41uSI9PaDm RpyEtTLP7zvCL7rBESoF6X4apgi5QoLxTWgr3eBbvomwJEXEy4Rk3Ps X-Developer-Key: i=wangao.wang@oss.qualcomm.com; a=ed25519; pk=bUPgYblBUAsoPyGfssbNR7ZXUSGF8v1VF4FJzSO6/aA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDA5MiBTYWx0ZWRfX2ZHd+wSggluA yY1/hZuJxQ/0rRNy6JBDjGx9CS/82IpybhFa20BdZpe1shvKTkK3NjZi1KlTL2b1TtObEA9RXAc k14vKNFqI4vDp9F4jFYKxNCr6Ull463jlxsCU62UX4leylpFW5tg/Gqx7DUhMzCH1q1Pl18wgGd iyl6CYba+md0cOcrFHsiUDcOEJcmbXzrP/jmG9eoHTIq4IKHbUL6b8sIXXBlBkOOer+juzJVguc nuTxYzi3fOqF8yTJ0nsu7o77XYEWKtlAxORxtr0yVrxVdekNviP0X7CZ6ncRWLW+oO8a3Ny4B7h L3dsoYvlBVfp2+/I3aNgiWpsvuD+q2G9AMa7S/xEOeuCog+S6TeHNo2eH72R1xjKxxAVqbK+fBr O41aPuS0cg0EApgbpI41JFw+A4t0pSMMlxsRegMoAmv9K6EUuHdKR7U05H640unR/sIgS2JhgA6 BSUJV5DI9GgMDHPSPIA== X-Proofpoint-GUID: YF_6rb5HGRN5i3_GGFQ5cZ-0o__HMBw6 X-Authority-Analysis: v=2.4 cv=MuFiLWae c=1 sm=1 tr=0 ts=69f1cc8c cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=J-oyWT7ATPDHrUoQIokA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: YF_6rb5HGRN5i3_GGFQ5cZ-0o__HMBw6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 phishscore=0 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290092 The GOP_SIZE cap was missing an hfi_id, so it would not interact with the firmware but could still save the parameter passed by the client. INTRA_PERIOD was acting as GOP_SIZE here. The code was redundant, so the two caps have been merged. Signed-off-by: Wangao Wang --- drivers/media/platform/qcom/iris/iris_ctrls.c | 2 +- drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - drivers/media/platform/qcom/iris/iris_platform_gen1.c | 14 +++----------- 3 files changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c index 2ae0d1aa11f8a529b8916ae0ac96e3298e250355..51eb644f2f1aba95b72a6cc8706beb3d2d67451a 100644 --- a/drivers/media/platform/qcom/iris/iris_ctrls.c +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c @@ -1293,7 +1293,7 @@ int iris_set_use_and_mark_ltr(struct iris_inst *inst, enum platform_inst_fw_cap_ int iris_set_intra_period(struct iris_inst *inst, enum platform_inst_fw_cap_type cap_id) { const struct iris_hfi_command_ops *hfi_ops = inst->core->hfi_ops; - u32 gop_size = inst->fw_caps[GOP_SIZE].value; + u32 gop_size = inst->fw_caps[cap_id].value; u32 b_frame = inst->fw_caps[B_FRAME].value; u32 hfi_id = inst->fw_caps[cap_id].hfi_id; struct hfi_intra_period intra_period; diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index 3efe3121459c610af55ad2f930b21c376f0a085b..e1e8cff01f5be2554ce4704f74bcd76d2477a413 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -172,7 +172,6 @@ enum platform_inst_fw_cap_type { USE_LTR, MARK_LTR, B_FRAME, - INTRA_PERIOD, LAYER_ENABLE, LAYER_TYPE_H264, LAYER_TYPE_HEVC, diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c index 65156584326a1a83588e8055f1318ba1b62e6510..a1988f22f8aac72eb64f944f0d341a49e8b8ee5c 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c @@ -193,7 +193,9 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { .max = (1 << 16) - 1, .step_or_mask = 1, .value = 30, - .set = iris_set_u32 + .hfi_id = HFI_PROPERTY_CONFIG_VENC_INTRA_PERIOD, + .flags = CAP_FLAG_OUTPUT_PORT, + .set = iris_set_intra_period, }, { .cap_id = ENTROPY_MODE, @@ -303,16 +305,6 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8250_enc[] = { .value = 0, .flags = CAP_FLAG_OUTPUT_PORT, }, - { - .cap_id = INTRA_PERIOD, - .min = 0, - .max = 1, - .step_or_mask = 1, - .value = 0, - .hfi_id = HFI_PROPERTY_CONFIG_VENC_INTRA_PERIOD, - .flags = CAP_FLAG_OUTPUT_PORT, - .set = iris_set_intra_period, - }, { .cap_id = LAYER_ENABLE, .min = 0, -- 2.43.0