From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3980824E4B4 for ; Wed, 29 Apr 2026 01:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777426750; cv=none; b=ElUTUOaJzOo2PUJeFnTDP6OoAU+6zzK8DPKc5jt8GGw7OUIEI0DmOmBN3vJj8D12FGbzq7amnAa3BpNCWT30jm8Wrv/At4D/1MpVSn5Tsh8MKO7bdVDD2FuWVThhNbQ7WtwxqJcRqm2Tl+/slHD+5oEu67T9IFe9ldkoxFhEUZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777426750; c=relaxed/simple; bh=NuKdDMXxMHFfADUrXSz37+tncEQGzkzv+UR6zBbTJQE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KZSVspS4gmVjkh/NKF652ZexYNd1zBrxHdsE3nBplIp4/5TdaQeurYWgsrUQEOs0gfhQeuy7S8XeRlustbshA4Ib1GZyXUU2lqJtUn1oW/BWLIVOYZ7QQD+AiqE5uJtgN3IcsLGePRr6R+pIqEIlvnMNWdrJPCi7VApMzpqY/Pw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rf1nhXdY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rf1nhXdY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADF71C2BCC4; Wed, 29 Apr 2026 01:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777426750; bh=NuKdDMXxMHFfADUrXSz37+tncEQGzkzv+UR6zBbTJQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rf1nhXdYaZuPNSDKEjrXwSowqcANaZsvJDB4tbwF20WzWrEDsJaewE+jJp7uzGObs t/sSX9iRxGSYdjF5Oeoi1IhPsoAjK0Qn8swXcJXLAt/89Wx7On7VNq3T8+doULmLPn 0OnGVmbdKvs3oSvrROP9bFT+hlGbcQhgjYkHK9WgNDXSWe2PI7nbuRllHXeqwhrLKT h9Hq8S+pU5BTXzEtIGftQuKjL1AbG2j4bJP25gvvDNphft0c9UjVC+fk7o/XT4D0GO bT3AClZL13UsNc6yHPWBHPegnWW4yhwRHeMHqGjR3RRsyVIzEyTvSMSeUsUUtvmGbg UJ6CLy9HgqFuQ== From: SeongJae Park To: Zi Yan Cc: SeongJae Park , "zhen.ni" , akpm@linux-foundation.org, vbabka@kernel.org, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mm/page_owner: add filter infrastructure Date: Tue, 28 Apr 2026 18:39:01 -0700 Message-ID: <20260429013902.89104-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, 28 Apr 2026 09:13:03 -0400 Zi Yan wrote: > On 27 Apr 2026, at 23:33, zhen.ni wrote: > > > 在 2026/4/27 23:35, Zi Yan 写道: > >> On 19 Apr 2026, at 11:55, Zhen Ni wrote: > >> > >>> Add data structure for page_owner filtering functionality and create > >>> debugfs directory for filter controls. > >>> > >>> This adds: > >>> - enum page_owner_print_mode with values for full_stack and stack_handle > >>> - struct page_owner_filter with print_mode and nid_mask fields > >>> - Static owner_filter instance initialized with default values > >>> - page_owner_filter debugfs directory > >>> > >>> The filter infrastructure will be used to add print_mode and NUMA node > >>> filtering capabilities in subsequent commits. > >>> > >>> Link: https://lore.kernel.org/linux-mm/20260417154638.22370-2-zhen.ni@easystack.cn/ > >>> Suggested-by: Zi Yan > >>> Signed-off-by: Zhen Ni > >>> --- > >>> > >>> Changes in v2: > >>> - Use enum page_owner_print_mode instead of bool 'compact' for better clarity > >>> - Use nodemask_t instead of int 'nid' to support multi-node filtering > >>> --- > >>> mm/page_owner.c | 20 +++++++++++++++++++- > >>> 1 file changed, 19 insertions(+), 1 deletion(-) > >> > >> The patch can be folded into Patch 2. Otherwise, these new types are not > >> used and page_owner_filter folder is just empty. > >> > > > > > > Thanks for your review and suggestion. > > > > I kept the 3-patch structure mainly for clear functional separation, > > which also makes review easier. Patch 1 adds the infrastructure, > > What is the point of adding unused code in a separate patch? > Patch 1 has no functional addition and should be part of Patch 2. I agree. While I was reviewing the v3 of this series, I had to move between the patch 2 and patch 1 to check the value of the print_mode enum. Having those on single patch will be easier to read for people like me. Thanks, SJ [...]