From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BF2532ED29 for ; Wed, 29 Apr 2026 02:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777431004; cv=none; b=Aky6sZFflGZyIVOTSAZEbCW4eGcCPfwXhBeZBerwgfsAkNXxehiKwITMwgFwzZxQoyDVT4XTAekYYVlzB2zJI2wAMQC48YiGRzYEjBSGxiQboQZ9uD+b8dQIdRVQZIo60SVCeZoC8HTA9dLKg1phGUp0OY+d8S5eW83PT65Hh08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777431004; c=relaxed/simple; bh=MddW6pRRvyoIpn6lOgfMUaVg0ZbDjtvAH7IqgdP0wSc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=W8BnOU8NeJ3+sY332Lq1KMz2CGKmyFew9nd8ffC/aGKqwkUYeAz6V1XWMgF3a3qd2+qiSLmP0VnQmM48PKhRaEOmjzeY1L6rGCRt+LS2Y2grWSLfJ8/fZ8f9cueXUdeyNLYQ/8JMksgO3e9nb5BuVqU+evWOoSnvpZOoE2jmQtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mcb6kFkY; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mcb6kFkY" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-79a46260385so140536267b3.3 for ; Tue, 28 Apr 2026 19:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777431002; x=1778035802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bEcKFoy1o4f1may1pNJc6Ss/wPvSop5G6kcO/t8tvuA=; b=mcb6kFkYPIFU/RRb1llIIqCe41+kNsQc00qWfmpVUR9qnIS5EkOLa4sl0BgWWXPE+1 TDIYdD3IKR/4mIxm1DfkOQa212NrZflP/u2R2NzzvHXqQD1TvDBhuPA9O2OtiScV7RdW NcH8X0SWpN8/Zhi58hnLid7wuDVrVrflfqgE3D4Nk+3e9Lk0XT68RhRjTI6NTEE7fnL4 stJ0S4OmnLecyTbUQp9wT2gKovnc+RYaD2u/rBk9iXIbrBDFa6D4ZMVgldL6IwQ9Vwct TXQrfMz5qC8t1LgpnappzQNHaIAQv6a73K8+lWvO4AyWDzEdAZ+HY/KwhaP2HzPJhSjq b9Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777431002; x=1778035802; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bEcKFoy1o4f1may1pNJc6Ss/wPvSop5G6kcO/t8tvuA=; b=BKWyWd2WoNliHAk81CqBtcyWdZa0TGq3HM+heggZ6AnSrtsrgdoGhhBIuJ+VSfyPT6 4o/CZFC5bVjAuJ4/RecDCXPejNN+LQMDUeSjE3GY7OuOqTLUV6D/6ZttTQ5NIYy8lt7W H3dzKx/Vhq/A1DnJzXG9PJOg5sFYsE/RmRqtMyY3pq/thal7CINQK5lxyskC0EEKTMcf XKr5GvJeiv230WO43lbzJ1k+C0hzMQP75ixLAS31TVdTwT1rU5ewvd/vcLub+LgpE2u1 WJU1/MeTA3veC67D15nrRAKLcmxGSgZs5cdzM/c/3gIEqo0zOkQTZgh01wDZKJS0xiWz mwOw== X-Forwarded-Encrypted: i=1; AFNElJ9RgTGiPWhGxWcHsNb7vqwR+kql6rJNgp2hKgSfWDCncmSGCgVAQzR41QruEG9bsyxi4kfMxy+5NqviPr0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+bLm2YfY+LxChSlbuF5RwcRA5d7cwj+lAE5xoFgxsnHcfEYWt 76E8zrEk9D25pwADJD96QSG/QFTiH9MakIP002WC7TnZcFRvaWyh/yfv X-Gm-Gg: AeBDietowlvW62QSUuTjNxW2XBcNGyQknzy/aZLMoFVyqWI7hved9hpbKTnDT0P6n30 gqnAG3CypXXEQvVhR1ULoJqJ0RuP+V+3b+2XiRWH2MHNuCkNg+Mq73c23H/enpZfxD8Bs5BTtdw T7pcceg3tqangnzXQ5a+EG5w9i8G16uWjdM7Uzd6T3hT1VBrti68dkChl5iJ5YCM3fFWjYZ2Bob 9S810Tij4Na9ruI+lOJnP0DEuItIlDvWyq89lz+9HI6wDvvh7puSTysp8aFXYVlprLKmGeY1QSn 34qW1yxD7J1uXzZTd5MeNouYx6BUIdCc7GXzJzRAbDUqAgZSla2cqsvz8Ec+F34j3Q+6sKNyftT TUTqg2kZOT2s8BOEK2YeJXkL7HBeMsNxBrk6cytvVbckn/IQiJ1yUAtse6iUU4Q+/yuf5EJ9TEz mxWjRYgYyFNCBycMQH4Yrkexy8mVqvgcVdzzfQdY8dfwnji7zYtXbCJETXpwxumGIxHgsGYbJdX c9sbfZRYvc6mdiCOB35Ag2QF7hSvMTumz4= X-Received: by 2002:a05:690c:2610:b0:7b9:ed52:deed with SMTP id 00721157ae682-7bd1d851418mr23852557b3.26.1777431002488; Tue, 28 Apr 2026 19:50:02 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::111d]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd259e3d9asm8380007b3.45.2026.04.28.19.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 19:50:02 -0700 (PDT) From: Ethan Tidmore To: Jagan Teki Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Linus Walleij , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/panel: jadard-jd9365da-h3: Fix signedness bug Date: Tue, 28 Apr 2026 21:49:54 -0500 Message-ID: <20260429024954.697411-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function drm_of_get_data_lanes_count_remote() returns negative error codes and dsi->lanes is an unsigned integer, so the check (dsi->lanes < 0) is always impossible. Detected by Smatch: drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c:2959 jadard_dsi_probe() warn: unsigned 'dsi->lanes' is never less than zero. Fixes: eb019688f2a97 ("drm/panel: jadard-jd9365da-h3: support variable DSI configuration") Signed-off-by: Ethan Tidmore --- drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c index 7157b1299bfd..f6b04de1182e 100644 --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c @@ -2955,9 +2955,11 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi) dsi->format = desc->format; dsi->lanes = desc->lanes; if (!dsi->lanes) { - dsi->lanes = drm_of_get_data_lanes_count_remote(dsi->dev.of_node, 0, -1, 2, 4); - if (dsi->lanes < 0) - return dsi->lanes; + ret = drm_of_get_data_lanes_count_remote(dsi->dev.of_node, 0, -1, 2, 4); + if (ret < 0) + return ret; + dsi->lanes = ret; + if (dsi->lanes == 4) { if (!desc->mode_4ln) { dev_err(&dsi->dev, "4-lane config is not supported\n"); -- 2.54.0