From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D747F337BAC for ; Wed, 29 Apr 2026 03:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777432131; cv=none; b=kTGW9nlenVYeIiA5P8iKZJ9YzqssxrEaPMZDN58kQW0GkMQvLyLAsB5PwgR8yosrrw1cqpbTJuBC2JhUv1RODl6XObo5gP4byMYwYN+lqV5v7M7rt8YFpkXcBLmjyNJWcTxR0SP9uVHTuVhtZXpLXxJB8Q4dZnszTclRRjBBAxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777432131; c=relaxed/simple; bh=tJIdrapxu8m4nx4eo+QZKBRLdPZcGLJJj1JnOKnLW/Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l9A1JmrZkznRHEayer0NrsDVvj6azsstJQZzVJ9ThWtT2nGijIJikpi8f7tOAwa/7DvLh6OF/4HFLeewuJomRniv2Sm+iyciFb7yzoQPMk67kKjPVc69K9rMjEXIW55N6b8TwSKTMltIFIq2GV8Mi3tdmtj4vXpc3OktxJpNTqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FigKXPpB; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FigKXPpB" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7927261a3acso109543217b3.0 for ; Tue, 28 Apr 2026 20:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777432129; x=1778036929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pK3hSHFPCb7iAbpW1nQuRwBugG9K8FcaZDqruZMNM7A=; b=FigKXPpBsHDezYAeZQ1QZfmo8vcX8uQHCdEVLi3qsxByvJEdQqmckgyVAASrasJfSN WVvxoarn5o7S+y2pLBz6b+e94JRbdze00V/UDTUXngiaM6I0HaeXQu/BlnvgMde2796p u+lcFTRcbQ6hr/hiMbr8v+ZGYBMEkDilSGaTvNzfsDGT6Bz7xjUAMUwyXkGSNF3k5F9w AlX805tMmfHRsIFewaVUDHdrynLH9j+yjHgufxPJsIR4eJyMhz8qca+ivgwZ7P2x8/sa OUyv0vU0/WP9fhUPTd8uWwwWNfVxHtDISUO4u/pAN2cbMxYmVOLCqpo0bRQtqz734PV7 U99g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777432129; x=1778036929; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pK3hSHFPCb7iAbpW1nQuRwBugG9K8FcaZDqruZMNM7A=; b=kKNQN+hqD86PGik0eBJqGiuXQ/ELUzgWNryki52wUy2ZEzL8VQaJo6GZCRK7CMKX33 rmhAiG5nE/spsieNQCDV2QG7VGBJlz0ADgzIDsSG6Pnmg+cgwLY0PfcDwr7vVAH5UVzY KMDczSY/8hsqszxxubl2BKoPoEMkDCs3iTpyq0Rg+wwaDk44FXqMo11bFe7JwSn+NmbU ebgODhcwRyD4sum9kz9x5QV+ARe+qqr0elxHG/tjQc3ASSAx7OilLG9tEWim1uTR5Duq Z4QVRq8dArPf7eYhl+LmaPb63vRPn5nedkwTcXl1i7DzI8T0HiEIsuKp5tFadXqWNRF7 zAIQ== X-Forwarded-Encrypted: i=1; AFNElJ8uPsfzw/mlshltJkQv7f6qBhBa4TR+cXcwPZ7rDCndXV+Z5ApjxuoYSra0oOtL9HMepP18+JqTDajviNc=@vger.kernel.org X-Gm-Message-State: AOJu0YxxVcBz/XutrwVAcBzl2UUxqmUtL3T2MSnYinGjpHmW/qPUqUcH Y7uFO8v5DVEOpZ7iIDnWo08GiW4yKxkHEbnHvTJfq7W/Ndg7UvpoDoFI X-Gm-Gg: AeBDiesX0SUExiKclC0YI7ZK6wnf0NWsd0KhgfYkzH4qa5yu9TjREuuAAs6l1SQfJ+N DykdpRSWRJ6UCNG2sTm0R85j5XEAuiza3vwOWoJfFwbCmR2r8Oi822Tk7HVgJZK7p42yYtarOed 1sifG7Q4AmDrhNGjl/vVfmb01DkaBqXgKRvqZXzS+QM2qlWgqpD8P0LhnVyNKz9n4qzn/uxeNmA 22RhyVeN5keU1lv9jPYGKhBNlR6CzK7kpVntEZUpCqFsU+2xrkrIWnVU5NVhQdq2/QgSqduAEm8 10Hc1M/nCfIOd1wy3nI+uLUIPXr41RGW5eUGLbTnAU+zTJgAB1AflBrME5cY2J0O1o54KyfBP91 xkSbbks5L9zrtbe+jWWseim72G7aM1D/33AzJy9Qg0MAaKAiGnCn/Ax4cWmDbxKtoq9da96KEzc UGXcwlfONgxHDy4HjJxH7KOCzbPp1fT8hcqBeskyWk9bUQTGvglHsaIqDpAOm5UeBnQnkOeHouU aVz3aUFrQH367baHCcY985oE6Nfu416Pgk= X-Received: by 2002:a05:690c:e3ea:b0:79b:cf31:9787 with SMTP id 00721157ae682-7bcf5573e9emr55855817b3.28.1777432128767; Tue, 28 Apr 2026 20:08:48 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::111d]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd25af5385sm8674627b3.48.2026.04.28.20.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 20:08:48 -0700 (PDT) From: Ethan Tidmore To: Andrzej Hajda , Neil Armstrong , Robert Foss , Damon Ding Cc: Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Luca Ceresoli , Dmitry Baryshkov , Heiko Stuebner , Marek Szyprowski , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Date: Tue, 28 Apr 2026 22:08:40 -0500 Message-ID: <20260429030840.704252-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In devm_drm_panel_bridge_add() error path the pointer error should be extracted from dp->plat_data->next_bridge but instead it is extracted from bridge, which is a valid pointer and not part of this error path. Extract error pointer from correct variable. Detected by Smatch: drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind() warn: passing a valid pointer to 'PTR_ERR' Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper") Signed-off-by: Ethan Tidmore --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 460729fdcecd..3e46350170d4 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1486,7 +1486,7 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev) dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev, dp->plat_data->panel); if (IS_ERR(dp->plat_data->next_bridge)) { - ret = PTR_ERR(bridge); + ret = PTR_ERR(dp->plat_data->next_bridge); goto err_unregister_aux; } } -- 2.54.0